Roan Kattouw [Tue, 15 Jan 2008 16:08:21 +0000 (16:08 +0000)]
API: Adding wlshow parameter to list=watchlist to allow for filtering (non-)minor, (non-)bot and (non-)anon edits
Roan Kattouw [Tue, 15 Jan 2008 16:04:50 +0000 (16:04 +0000)]
Reverting r29798 on the committer's request, part 1 of 2
ThomasV [Tue, 15 Jan 2008 15:53:09 +0000 (15:53 +0000)]
fix for IE
Roan Kattouw [Tue, 15 Jan 2008 15:38:30 +0000 (15:38 +0000)]
(bug 12585) Added a bunch of parameters to the revertpage message (rollback summary). These parameters currently aren't used in the default message, but custom messages could use them.
$3: revid of the revision reverted to
$4: timestamp of the revision reverted to
$5: revid of the revision reverted from
$6: timestamp of the revision reverted from
Roan Kattouw [Tue, 15 Jan 2008 15:23:27 +0000 (15:23 +0000)]
API: Adding cascade flag to prop=info&inprop=protection
Aryeh Gregor [Tue, 15 Jan 2008 15:02:36 +0000 (15:02 +0000)]
Adjust some function definitions for abstract classes to stop annoying PHP strict warnings. Also moved some @public notices to the public keyword.
Rotem Liss [Tue, 15 Jan 2008 14:49:17 +0000 (14:49 +0000)]
Update for he.
Aryeh Gregor [Tue, 15 Jan 2008 14:48:24 +0000 (14:48 +0000)]
(bug 12202) Strict standards: mark static methods static.
Raimond Spekking [Tue, 15 Jan 2008 10:56:57 +0000 (10:56 +0000)]
Localisation updates German
Raimond Spekking [Tue, 15 Jan 2008 07:51:01 +0000 (07:51 +0000)]
Another fix for r29765: Avoid PHP notices
Thanks to ialex
Raimond Spekking [Tue, 15 Jan 2008 07:27:16 +0000 (07:27 +0000)]
Fix for r9765:
* Readd 'userrights-available-remove', still in use
* Update messages.inc
Brion Vibber [Tue, 15 Jan 2008 01:55:48 +0000 (01:55 +0000)]
* (bug 12567) Fix for misformatted read-only messages on edit, protect.
Also added proper read-only checks to several special pages.
Have removed read-only checks from the general user permission framework
since it doesn't belong there; user authorization is independent from
the database's read-only state, and the way we check and present error
conditions is necessarily different. Further, as a detail it was formatting
the actual message incorrectly as an inline message when historically it's a
big block message with tables and images and stuff.
Brion Vibber [Tue, 15 Jan 2008 01:20:12 +0000 (01:20 +0000)]
Remove default 'deleted' directory; gets in the way and makes it impossible to delete images in a default install unless you then go on to figure out what's wrong and fix the permissions. A fresh directory will be created when needed.
River Tarnell [Mon, 14 Jan 2008 23:57:43 +0000 (23:57 +0000)]
* $wgGroupsAddToSelf, $wgGroupsRemoveFromSelf: allow users to add or remove
themselves from specified groups via Special:Userrights.
Brion Vibber [Mon, 14 Jan 2008 23:36:36 +0000 (23:36 +0000)]
* (bug 12617) Decimal and thousands separators for Romanian
Brion Vibber [Mon, 14 Jan 2008 20:17:05 +0000 (20:17 +0000)]
Revert r29705. Simply provide rollback permission if you want people to be able to use rollback.
Otherwise you're going to end up with the restricted portions of it incorrectly allowed when they're not meant to be by accident, which seems pretty senseless.
Victor Vasiliev [Mon, 14 Jan 2008 18:52:55 +0000 (18:52 +0000)]
Autopromotion:
* Add APCOND_INGROUPS
* Fix comment
* Don't use array_unique() since we have groups as *keys* of $wgAutopromote
Victor Vasiliev [Mon, 14 Jan 2008 18:48:57 +0000 (18:48 +0000)]
Update README
Victor Vasiliev [Mon, 14 Jan 2008 18:46:31 +0000 (18:46 +0000)]
Tweak profileinfo.php:
* Added average calls per request column
* Added time % column
Victor Vasiliev [Mon, 14 Jan 2008 18:44:29 +0000 (18:44 +0000)]
* Add caching to the AJAX search
Victor Vasiliev [Mon, 14 Jan 2008 18:42:39 +0000 (18:42 +0000)]
* (bug 12536) User should be able to get MediaWiki version from any page
* (bug 12622) A JavaScript constant to declare whether api.php is available
Aryeh Gregor [Mon, 14 Jan 2008 18:12:43 +0000 (18:12 +0000)]
(bug 12614) Prevent logging of null change on Userrights . . . for real this time.
Raimond Spekking [Mon, 14 Jan 2008 16:04:08 +0000 (16:04 +0000)]
Localisation updates. Specific German messages for formal address only.
Raimond Spekking [Mon, 14 Jan 2008 15:20:54 +0000 (15:20 +0000)]
Localisation updates.
Set fallback to 'de'. Specific formal address messages follows soon.
Raimond Spekking [Mon, 14 Jan 2008 15:02:38 +0000 (15:02 +0000)]
Localisation updates. Introduce formal address of German ("Sie")
See next commit too.
Raimond Spekking [Mon, 14 Jan 2008 14:22:32 +0000 (14:22 +0000)]
Localisation updates Kazakh translations
(bug 12145) Patch by AlefZet
Victor Vasiliev [Mon, 14 Jan 2008 13:57:40 +0000 (13:57 +0000)]
Revert accidentally commited image moving stuff
Victor Vasiliev [Mon, 14 Jan 2008 13:50:55 +0000 (13:50 +0000)]
* Introduce getUserPermissionsErrorsExpensive hook
Domas Mituzas [Mon, 14 Jan 2008 12:50:20 +0000 (12:50 +0000)]
Cleanup for Special:Randompage and Special: Randomredirect after r29725 - bugzilla.wikimedia.org/show_bug.cgi?id=12624
Thanks to: alex.emsenhuber
Rotem Liss [Mon, 14 Jan 2008 12:47:15 +0000 (12:47 +0000)]
Update for he.
Raimond Spekking [Mon, 14 Jan 2008 12:02:33 +0000 (12:02 +0000)]
* Updates German
Siebrand Mazeland [Mon, 14 Jan 2008 12:01:14 +0000 (12:01 +0000)]
Localisation updates for core messages from Betawiki (2008-01-14 12:52 CET)
Raimond Spekking [Mon, 14 Jan 2008 11:13:51 +0000 (11:13 +0000)]
* Updates German
Patch by Tim 'avatar' Bartel
Domas Mituzas [Mon, 14 Jan 2008 10:23:48 +0000 (10:23 +0000)]
* Shortcutted Title::userCanRead() for public wikis
* Moved redirects code in OutputPage before skins and ajax stuff, to handle likely scenario better
* Stripped off lots of fat (like... 30-50% of execution time) from Special:Randompage - mwahaha... ha... hahaha...
Huji [Mon, 14 Jan 2008 09:26:36 +0000 (09:26 +0000)]
(bug 12608) (in continuation of r29719) Unifying the spelling of getDBkey() in the code.
Huji [Mon, 14 Jan 2008 09:13:04 +0000 (09:13 +0000)]
(bug 12608) Unifying the spelling of getDBkey() in the code.
Tim Starling [Mon, 14 Jan 2008 06:59:20 +0000 (06:59 +0000)]
* Fixed loop detection in LST
* Renamed some LST parser tests
* Fixed <gallery> caption behaviour .It should not generate <pre> when there are spaces at the start. Used recursiveTagParse() instead of parse(), to avoid generation of a limit report, among other things.
* Refactored template loop check
* Updated a couple of parser tests
Shinjiman [Mon, 14 Jan 2008 05:43:20 +0000 (05:43 +0000)]
* Update Cantonese translations
Tim Starling [Mon, 14 Jan 2008 03:43:14 +0000 (03:43 +0000)]
* Fix heading immediately after comment-on-own-line
* Fix ===== on own line
Siebrand Mazeland [Sun, 13 Jan 2008 22:46:51 +0000 (22:46 +0000)]
Localisation updates for core messages from Betawiki (2008-01-13 23:37 CET)
Aryeh Gregor [Sun, 13 Jan 2008 22:26:08 +0000 (22:26 +0000)]
Tweak tweaks.
Aryeh Gregor [Sun, 13 Jan 2008 22:23:36 +0000 (22:23 +0000)]
Random small fixes: formatting/whitespace, comments, fix inexplicably misleading profiling name in getUserPermissionsErrorsInternal.
Aryeh Gregor [Sun, 13 Jan 2008 21:36:08 +0000 (21:36 +0000)]
The 'rollback' permission now only affects whether rollback is made available through the interface. Users without the rollback permission can still use it by generating the proper token through a script. This does nothing but allow automated rollback scripts to generate less load on both the client and the server, without allowing them to do anything extra. This was inspired by an anti-vandal bot operator on enwiki who showed me his server load dropping in half when his bot switched from manual reverts to rollback.
Bertrand Grondin [Sun, 13 Jan 2008 21:15:14 +0000 (21:15 +0000)]
Localisation updates for extensions from Betawiki (2008-01-13 21:14 UTC)
Victor Vasiliev [Sun, 13 Jan 2008 17:58:14 +0000 (17:58 +0000)]
* (bug 12611) Bot flag ignored in recent changes
Domas Mituzas [Sun, 13 Jan 2008 13:34:45 +0000 (13:34 +0000)]
don't open transactions for SHOW and SET statements - reduces some redundancy of transaction startup
Tim Starling [Sun, 13 Jan 2008 12:47:38 +0000 (12:47 +0000)]
Expansion cache for template arguments. Fixes the most common <ref> numbering bugs. I think the rest can be fixed in the Cite extension itself. I will give that a go later.
Domas Mituzas [Sun, 13 Jan 2008 12:29:43 +0000 (12:29 +0000)]
avoid calling things on $wgTitle that might be not yet initialized
Siebrand Mazeland [Sun, 13 Jan 2008 11:40:17 +0000 (11:40 +0000)]
Localisation updates for core messages from Betawiki (2008-01-13 12:23 CET)
Bertrand Grondin [Sun, 13 Jan 2008 10:07:18 +0000 (10:07 +0000)]
Update french localization file
* Add Special aliases names
* Add Special magic words
* Add Skin names
Tim Starling [Sun, 13 Jan 2008 09:23:58 +0000 (09:23 +0000)]
Third time lucky? More complex method to obtain precise bug-for-bug compatibility with the old parser.
Tim Starling [Sun, 13 Jan 2008 08:51:09 +0000 (08:51 +0000)]
Improved tplarg whitespace fix, following on from buggy r29685.
Tim Starling [Sun, 13 Jan 2008 06:40:14 +0000 (06:40 +0000)]
Fix handling for whitespace in template arguments.
Tim Starling [Sun, 13 Jan 2008 03:47:07 +0000 (03:47 +0000)]
Revert r29671, it was based on a misunderstanding of the purpose of the LoggedOut cookie. The LoggedOut cookie is there to suppress the client-side cache, not the server-side cache. It prevents privately cached logged-in pages from being displayed after the user logs out. Feel free to special-case it in squid if you're worried about the server-side cache hit ratio, but note that IMS requests would need special handling.
* Credential data in the session is destroyed, so the session is harmless. But it is still useful for abuse tracking (logout/login sequences) and similar analysis.
* Not much point in removing the username persistence feature if you can't improve the squid cache hit ratio, which was obviously your goal.
Aryeh Gregor [Sun, 13 Jan 2008 01:03:28 +0000 (01:03 +0000)]
Clarify comment on $wgRateLimits.
Domas Mituzas [Sat, 12 Jan 2008 23:52:46 +0000 (23:52 +0000)]
should have some coffee - one more typo :)
Domas Mituzas [Sat, 12 Jan 2008 23:12:51 +0000 (23:12 +0000)]
damn, how did this typo slip in :)
Domas Mituzas [Sat, 12 Jan 2008 23:10:08 +0000 (23:10 +0000)]
Well, logging out is an action, where people don't want to have any of their their credentials still sit in browser.
Actually, keeping a session is still bad. And trying to ensure that they don't see cached content... Well, thats wrong idea.
See, if someone is logged out, he is anonymous and deserves to see cached content as everyone else.
So, let's destroy all cookies.
Domas Mituzas [Sat, 12 Jan 2008 22:51:16 +0000 (22:51 +0000)]
Few sanity things for database activity:
* Provide function to COMMIT master connection in case there were any changes
* Use it at cleanup, instead of sending too many COMMITs to all slaves
* Don't acquire master connection, if no updates are to be done
* Don't care about closing database connections, let PHP do that (would close HTTP socket few nanoseconds earlier)
Domas Mituzas [Sat, 12 Jan 2008 17:51:21 +0000 (17:51 +0000)]
* importing livehack for profiling errors output
* fixing some of CPU profile elimination errors :)
Domas Mituzas [Sat, 12 Jan 2008 17:39:02 +0000 (17:39 +0000)]
remove Cpu from here too
Domas Mituzas [Sat, 12 Jan 2008 17:32:21 +0000 (17:32 +0000)]
aaaAAAAAAAAAaaaaaAAAAAAAAAAaaaaaaAAAAAAAAAAAAAAAAAAAAAAAAAAAAAaaaaaaAAAAAAAAAAAAAAAAAAAaaaaaaaAAAAAAAAAaaaaaAAAAAAAAAAAAAAAAAAAAAAAAaaaaaaaaaaaaaaaaaaaaaaAAAAAAAAAAAAAAAAAAAaaaaaaAAAAAAAAAAAAAAAAAAAaaaaaaaAAAAAAAAAaaaaaAAAAAAAAAAAAAAAAAAAAAAAAaaaaaaaaaaaaaaaaaaaaaaAAAAAAAAAAAAAAAAAAAaaaaaaAAAAAAAAAAAAAAAAAAAaaaaaaaAAAAAAAAAaaaaaAAAAAAAAAAAAAAAAAAAAAAAAaaaaaaaaaaaaaaaaaaaaaaa:
* ditch CPU profiling from ProfilerSimple, because:
** getrusage() is updated just on end of quant, which is 10ms on our new servers and 1ms on old ones:
*** All CPU profiling before looked reasonable just just just because lots of 0's and 10's sometimes add up to reasonable guestimate.
Siebrand Mazeland [Sat, 12 Jan 2008 17:29:42 +0000 (17:29 +0000)]
Localisation updates. Updating special pages.
Siebrand Mazeland [Sat, 12 Jan 2008 16:41:20 +0000 (16:41 +0000)]
Localisation updates for core messages from Betawiki (2008-01-12 17:18 CET)
Tim Starling [Sat, 12 Jan 2008 13:44:08 +0000 (13:44 +0000)]
Revert r29647, as per my comment on bug 12536.
Victor Vasiliev [Sat, 12 Jan 2008 12:31:20 +0000 (12:31 +0000)]
* (bug 12536) User should be able to get MediaWiki version from any page
Bertrand Grondin [Sat, 12 Jan 2008 10:53:52 +0000 (10:53 +0000)]
Localisation updates for extensions from Betawiki (2008-01-12 11:53 UTC)
Daniel Cannon [Sat, 12 Jan 2008 07:08:17 +0000 (07:08 +0000)]
API: Various docu and clean-up.
Brion Vibber [Sat, 12 Jan 2008 00:13:53 +0000 (00:13 +0000)]
* Use only default options when generating RSS and Atom syndication links.
This should help prevent infinite link loops that some software may follow,
and will generally keep feed behavior cleaner.
Combined duplicate link expansion from OutputPage and SkinTemplate into OutputPage::getSyndicationLinks()
Siebrand Mazeland [Fri, 11 Jan 2008 22:48:20 +0000 (22:48 +0000)]
Localisation updates for core messages from Betawiki
* adding pag/Pangasinan
Siebrand Mazeland [Fri, 11 Jan 2008 22:04:05 +0000 (22:04 +0000)]
Localisation updates for core messages from Betawiki
* adding pap/Papiamento
Brion Vibber [Fri, 11 Jan 2008 21:10:51 +0000 (21:10 +0000)]
* (bug 12588) Fix selection in namespace selector on Special:Newpages
Godawful hack... we'll be frequently passed selected namespaces as strings since PHP is such a shithole.
But we also don't want blanks and nulls and "all"s matching 0, so let's convert *just* string ints to clean ints.
Aryeh Gregor [Fri, 11 Jan 2008 21:02:39 +0000 (21:02 +0000)]
I doubt we'll get $this->hookError set to '0', but let's head that off at the pass.
Brion Vibber [Fri, 11 Jan 2008 20:52:54 +0000 (20:52 +0000)]
* (bug 12584) Don't reset cl_timestamp when auto-updating sort key on move
Also cleaned up comment and ugly manual query
Aryeh Gregor [Fri, 11 Jan 2008 20:51:53 +0000 (20:51 +0000)]
Some random code cleanup/prettification.
Siebrand Mazeland [Fri, 11 Jan 2008 14:32:45 +0000 (14:32 +0000)]
Localisation updates for core messages from Betawiki (2008-01-11 15:07 CET)
Shinjiman [Fri, 11 Jan 2008 14:16:42 +0000 (14:16 +0000)]
* (bug 12145) Update Kazakh translations
Patch by AlefZet
Shinjiman [Fri, 11 Jan 2008 12:15:12 +0000 (12:15 +0000)]
* Update Chinese translations
* Update Cantonese translations
* Update Old Chinese / Late Time Chinese translations
Aaron Schulz [Fri, 11 Jan 2008 05:06:10 +0000 (05:06 +0000)]
Explicitly use 0 like the other checks here
Brion Vibber [Fri, 11 Jan 2008 04:55:48 +0000 (04:55 +0000)]
Redo r29565, but as far as I see working now. :)
getRestrictions() always returns an array -- just use a standard boolean condition, not is_array().
Marked Title::getTitleProtection() private.
Brion Vibber [Fri, 11 Jan 2008 04:41:11 +0000 (04:41 +0000)]
Tweak for r29561: don't grab a database object until we need it
Tim Starling [Fri, 11 Jan 2008 03:25:41 +0000 (03:25 +0000)]
* Fixed template loop check, broken by changes in parse order
* Added template recursion depth limit. It needs a small limit, because of exorbitant stack space usage, xdebug compatibility problems, and the potential for O(N^2) memory usage in the template loop check.
* Made these two error messages more obvious in the parser output, with <span class="error"> instead of a comment. This is similar to the #expr error messages, which seem to have been well received by our template programmer community.
Aaron Schulz [Thu, 10 Jan 2008 23:28:08 +0000 (23:28 +0000)]
Revert back for now, this is not quite correct
Aaron Schulz [Thu, 10 Jan 2008 23:13:45 +0000 (23:13 +0000)]
Don't call getTitleProtection(). That is really just an internal function for a DB query. It shouldn't even by public as it is. Just check 'create' restrictions. This is where they are saved too.
Niklas Laxström [Thu, 10 Jan 2008 22:15:33 +0000 (22:15 +0000)]
* No need to query database for special namespaces
Aryeh Gregor [Thu, 10 Jan 2008 19:27:49 +0000 (19:27 +0000)]
Right, *this* was the vulnerability that existed. Users couldn't mark the other edits bot, but they could mark their own rollback revision as bot.
Siebrand Mazeland [Thu, 10 Jan 2008 18:16:14 +0000 (18:16 +0000)]
Localisation updates for core messages from Betawiki (2008-01-10 18:51 CET)
Thomas Bleher [Thu, 10 Jan 2008 16:51:45 +0000 (16:51 +0000)]
Fix some places where globals where used without being declared as
being global. Also remove one unused variable.
Roan Kattouw [Thu, 10 Jan 2008 13:37:01 +0000 (13:37 +0000)]
Removing unused global $wgRequest; that I missed in the previous commit.
Roan Kattouw [Thu, 10 Jan 2008 13:33:23 +0000 (13:33 +0000)]
Fixing the mess that was r29539:
* $wgRequest shouldn't be used in functions like Article::doEdit() that are also called by API modules
* Moving code that decides whether the edit is bot out of DB logic and into UI logic: API and UI each decide indepentently from one another
* Removing $bot==='default' behavior from RecentChange::notifyEdit() and notifyNew(): nobody uses it, and it shouldn't be used anyway; whether the edit is bot should've been decided long ago
Daniel Cannon [Thu, 10 Jan 2008 09:54:35 +0000 (09:54 +0000)]
* (bug 12574) Allow bots to specify whether an edit should be marked as a bot
edit, via the parameter 'bot'. (Default: '1')
Patch by Cobi <Winbots at gmail dot com>.
Roan Kattouw [Thu, 10 Jan 2008 07:52:09 +0000 (07:52 +0000)]
Revert r29525: this vulnerability never existed; Article::doRollback() does the check already. Besides, the permission is called markboteditS
Aryeh Gregor [Thu, 10 Jan 2008 02:28:58 +0000 (02:28 +0000)]
Do not log user rights change that didn't change anything
Aryeh Gregor [Thu, 10 Jan 2008 02:21:16 +0000 (02:21 +0000)]
Fix vulnerability (hopefully): anyone with rollback privileges can mark the rollback as bot, despite r27657.
Siebrand Mazeland [Thu, 10 Jan 2008 00:19:23 +0000 (00:19 +0000)]
Localisation updates. Update namespaces per ast.wikipedia.org/w/index.php?title=Uiquipedia:Votaciones&oldid=216561
Siebrand Mazeland [Wed, 9 Jan 2008 23:57:15 +0000 (23:57 +0000)]
Localisation updates for core messages from Betawiki (2008-01-10 0:38 CET)
* fallback for 'lij' to 'it'
Domas Mituzas [Wed, 9 Jan 2008 23:23:53 +0000 (23:23 +0000)]
this profiling section is nearly identical to our already verbose Database::open and dbconnect ones
Aryeh Gregor [Wed, 9 Jan 2008 21:40:40 +0000 (21:40 +0000)]
Clean up some braces, indentation; add profiling to LoadBalancer::reallyOpenConnection.
Domas Mituzas [Wed, 9 Jan 2008 20:47:46 +0000 (20:47 +0000)]
set OutputPage::mContainsOldMagic only for specific listed magic words
For now the suggested times are ignored and base 3600 is used for all dynamic ones
This makes templates more friendly parser-cache wise.
Huji [Wed, 9 Jan 2008 15:26:43 +0000 (15:26 +0000)]
Added translations for the remaining EXIF messages.