Chad Horohoe [Tue, 14 Dec 2010 12:59:17 +0000 (12:59 +0000)]
Per r76225 CR: Get rid of Autoloader::loadAllExtensions() "Anything that needs it is badly written and needs to use the AutoLoader properly."
Chad Horohoe [Tue, 14 Dec 2010 12:51:59 +0000 (12:51 +0000)]
Style fix for r76220
Chad Horohoe [Tue, 14 Dec 2010 12:47:37 +0000 (12:47 +0000)]
rm double comment
Chad Horohoe [Tue, 14 Dec 2010 12:47:07 +0000 (12:47 +0000)]
Fix for r78322, check $result not $value
Alexandre Emsenhuber [Tue, 14 Dec 2010 12:25:34 +0000 (12:25 +0000)]
Changed $wgArticle to local variable, not needed
Alexandre Emsenhuber [Tue, 14 Dec 2010 12:15:55 +0000 (12:15 +0000)]
Article::insertNewArticle() -> Article::doEdit()
Roan Kattouw [Tue, 14 Dec 2010 11:47:13 +0000 (11:47 +0000)]
Improve some of the descriptions added in r68482
Tim Starling [Tue, 14 Dec 2010 11:11:38 +0000 (11:11 +0000)]
Cleaned up r70342 and r70343: removed commented-out code.
Roan Kattouw [Tue, 14 Dec 2010 11:09:30 +0000 (11:09 +0000)]
Followup r78104: set the cookie unconditionally, so its expiry is renewed every time sessionId() is called
Tim Starling [Tue, 14 Dec 2010 10:57:41 +0000 (10:57 +0000)]
Update references for wfEscapeShellArg() for r69732 etc. The very useful mailing list post that I cited has disappeared from the web!
Tim Starling [Tue, 14 Dec 2010 09:01:48 +0000 (09:01 +0000)]
Fixed comments and indenting style from r68491.
Rotem Liss [Tue, 14 Dec 2010 08:44:09 +0000 (08:44 +0000)]
Localization update for he.
Tim Starling [Tue, 14 Dec 2010 08:14:55 +0000 (08:14 +0000)]
Fixed typos in file names from r65967
Krinkle [Tue, 14 Dec 2010 00:08:54 +0000 (00:08 +0000)]
merging the two addModules() calls into one, (they take an array, so might as well me together); + using mw instead of mediaWiki in mediawiki.util.js
Trevor Parscal [Tue, 14 Dec 2010 00:08:07 +0000 (00:08 +0000)]
Added comment about why you should not be depending on mediaWiki.user.sessionId before mediaWiki.loader.go is called.
Trevor Parscal [Tue, 14 Dec 2010 00:02:21 +0000 (00:02 +0000)]
Fixes r78104 much better than r78344 did. By adding jquery.cookie to the loading queue just after declaring mediaWiki we can ensure it's in the first batch of modules that are fetched - essentially adding it to the initial payload.
Krinkle [Mon, 13 Dec 2010 23:52:45 +0000 (23:52 +0000)]
added compareObject function to mediaWiki core jQuery prototyping utilities
Trevor Parscal [Mon, 13 Dec 2010 23:51:29 +0000 (23:51 +0000)]
Fixed issue in r78104 where jquery.cookie wouldn't load properly. Changed the mediaWiki User object to load jquery.cookie on demand.
Alexandre Emsenhuber [Mon, 13 Dec 2010 22:33:08 +0000 (22:33 +0000)]
Checking namespace restriction with $wgUser while calling Title::getUserPermissionsErrors() with anoter User object is really not a good idea
Raimond Spekking [Mon, 13 Dec 2010 20:58:38 +0000 (20:58 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-13 20:33:00 UTC)
Derk-Jan Hartman [Mon, 13 Dec 2010 20:34:35 +0000 (20:34 +0000)]
Followup to r77836. Update parserTests
Krinkle [Mon, 13 Dec 2010 20:13:39 +0000 (20:13 +0000)]
Make the Map-class publicly available
Bryan Tong Minh [Mon, 13 Dec 2010 20:04:06 +0000 (20:04 +0000)]
Follow-up r66364: wincache fixes
* Return the result of wincache_ucache_get() in get()
* In command line mode $info['ucache_entries'] returned from wincache_ucache_info() is null, so don't iterate over a non-array
Bryan Tong Minh [Mon, 13 Dec 2010 20:00:43 +0000 (20:00 +0000)]
Follow-up r78297: allow the hook to break the execution; added &$term: could be useful for modifying the edit link
Alexandre Emsenhuber [Mon, 13 Dec 2010 19:47:34 +0000 (19:47 +0000)]
Removed trailing whitespaces
Roan Kattouw [Mon, 13 Dec 2010 16:39:48 +0000 (16:39 +0000)]
Followup r64047: pass static callbacks in array form, not string form
Platonides [Mon, 13 Dec 2010 15:49:05 +0000 (15:49 +0000)]
Do not assume that the current working dir is phase3/config
Chad Horohoe [Mon, 13 Dec 2010 15:30:41 +0000 (15:30 +0000)]
Fix for r75858: Move $IP detection further up so it can be used in child constructors
Alexandre Emsenhuber [Mon, 13 Dec 2010 15:16:05 +0000 (15:16 +0000)]
Fix comment: Article::insertNewArticle() -> Article::doEdit() and Article::insertOn()
Alexandre Emsenhuber [Mon, 13 Dec 2010 15:13:06 +0000 (15:13 +0000)]
Changed global variables ($wgTitle and $wgArticle) to local ones
Roan Kattouw [Mon, 13 Dec 2010 13:13:29 +0000 (13:13 +0000)]
Followup r76220: locateExecutableInDefaultPaths() was made static, so use static calls
Roan Kattouw [Mon, 13 Dec 2010 12:44:34 +0000 (12:44 +0000)]
Fix variable name in doc comment added in r78192
Roan Kattouw [Mon, 13 Dec 2010 12:40:08 +0000 (12:40 +0000)]
Fix r78196: readd accidentally removed lines in shared.css
Sam Reed [Mon, 13 Dec 2010 12:38:44 +0000 (12:38 +0000)]
Followup r78295, seems I didn't even bother to rename it last time
Sam Reed [Mon, 13 Dec 2010 11:06:57 +0000 (11:06 +0000)]
Followup r78268, do it as Bryan suggested, not as how I'd interpretted it for some daft reason
Benjamin Lees [Sun, 12 Dec 2010 23:19:24 +0000 (23:19 +0000)]
Follow-up to r77956: instead of making $wgFileExtensions override $wgFileBlacklist, make sure the upload page does not mark blacklisted extensions as "Permitted file types". I've updated the MediaWiki.org pages to explain how to remove items from the blacklist.
Krinkle [Sun, 12 Dec 2010 22:30:02 +0000 (22:30 +0000)]
(mw.util.test) Escape the 'does return, the same way as the 'should return' (mw.html.escape() and spaces to non-breaking)
Alexandre Emsenhuber [Sun, 12 Dec 2010 20:45:32 +0000 (20:45 +0000)]
Fix fatal error from r78264
Raimond Spekking [Sun, 12 Dec 2010 20:34:19 +0000 (20:34 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-12 20:19:00 UTC)
Sam Reed [Sun, 12 Dec 2010 18:57:10 +0000 (18:57 +0000)]
Followup r65114 (per CR cabal), remove SpecialSearchGomatch, replace with SpecialSearchGo in SearchEngine::getNearMatch
Alexandre Emsenhuber [Sun, 12 Dec 2010 18:54:33 +0000 (18:54 +0000)]
Moved the check for the "printable" parameter to performRequestForTitle() instead of checkInitialQueries(), I don't know why we need to do this check that early
Alexandre Emsenhuber [Sun, 12 Dec 2010 18:47:04 +0000 (18:47 +0000)]
It's easier to use addWikiMsgArray()
Sam Reed [Sun, 12 Dec 2010 18:35:19 +0000 (18:35 +0000)]
Followup r75763, fixup wrong change of deprecated method
No need to do separate htmlspecialchars et al, Xml::expandAttributes
Sam Reed [Sun, 12 Dec 2010 18:17:33 +0000 (18:17 +0000)]
Fix typo in hooks.txt
Chad Horohoe [Sun, 12 Dec 2010 17:50:35 +0000 (17:50 +0000)]
&& not and, || not or
Chad Horohoe [Sun, 12 Dec 2010 17:25:56 +0000 (17:25 +0000)]
Remove bogus session_path checks. Reverts r67465, r63813, r75256, r64717.
Roan Kattouw [Sun, 12 Dec 2010 16:18:08 +0000 (16:18 +0000)]
Redo r78254 without the syntax error
Platonides [Sun, 12 Dec 2010 16:15:35 +0000 (16:15 +0000)]
This is not an array, but a parameter. Revert r78254. Is the precommit hook not working?
PHP Parse error: syntax error, unexpected T_DOUBLE_ARROW in includes/Title.php on line 3752
Roan Kattouw [Sun, 12 Dec 2010 15:55:03 +0000 (15:55 +0000)]
Folllowup r72866: use array syntax for rev_page = foo condition
Bryan Tong Minh [Sun, 12 Dec 2010 15:50:25 +0000 (15:50 +0000)]
Follow-up r65652: Do not double-slash the path if it came from PATH_INFO
Happy-melon [Sun, 12 Dec 2010 15:40:41 +0000 (15:40 +0000)]
Follow-up r64903: rm leftover debugging code.
Happy-melon [Sun, 12 Dec 2010 15:38:54 +0000 (15:38 +0000)]
Follow-up r78246: clean several integer preferences before saving. It's not dangerous to not do this, here or elsewhere, because it is done implicitly whenever the value is treated as a number; but it keeps the database tidier.
Happy-melon [Sun, 12 Dec 2010 15:32:29 +0000 (15:32 +0000)]
Follow-up to r64866: follow the HTML5 spec when validating floats and ints, and support 'required' attribute universally (apart from type=hidden).
Chad Horohoe [Sun, 12 Dec 2010 15:29:47 +0000 (15:29 +0000)]
Per CR on r71359: Fix DB_MASTER where it should be __METHOD__
Aryeh Gregor [Sun, 12 Dec 2010 00:30:06 +0000 (00:30 +0000)]
Make ul.gallery block, not inline-block
As suggested by fomafix at
<https://bugzilla.wikimedia.org/show_bug.cgi?id=3276#c33>. This makes
it play nicer with floats, at least in Firefox 4, and doesn't seem to
otherwise break stuff (but I haven't tested in many browsers).
Platonides [Sat, 11 Dec 2010 22:54:41 +0000 (22:54 +0000)]
Remove that ugly unset( $vars['_lsExists'] );
Shouldn't the second file_exists() also need a wfSuppressWarnings?
Follow up to r78118.
Platonides [Sat, 11 Dec 2010 22:44:42 +0000 (22:44 +0000)]
Follow up r77981,r77982. Rename the new globalcsspreview/globaljspreview to sitecsspreview/sitejspreview per CodeReview.
Raimond Spekking [Sat, 11 Dec 2010 22:05:32 +0000 (22:05 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-11 22:46:00 UTC)
Alexandre Emsenhuber [Sat, 11 Dec 2010 20:26:14 +0000 (20:26 +0000)]
Fix whitespaces
Alexandre Emsenhuber [Sat, 11 Dec 2010 20:07:49 +0000 (20:07 +0000)]
* Per Ilmari Karonen, fix for r78224: make it work correctly with API
* Renamed $mName to $mUsername since it was conflicting with a member variable of SpecialPage
Alexandre Emsenhuber [Sat, 11 Dec 2010 17:44:57 +0000 (17:44 +0000)]
* Converted Special:Userlogin to subclass SpecialPage
* Removed useless calls to $wgOut->setArticleRelated() and $wgOut->setRobotPolicy(), they are already handled by SpecialPage::setHeaders()
Aaron Schulz [Sat, 11 Dec 2010 05:32:48 +0000 (05:32 +0000)]
* Removed redundant revdelete msg above content
* Show bottom patrol link even if hook replaces preview content
* Hook doc tweaks
* Assorted minor cleanups
Mark A. Hershberger [Sat, 11 Dec 2010 03:53:22 +0000 (03:53 +0000)]
* Add FIXME about the bug I found during testing
* Make the only instance of the ParserOptions::getMaxIncludeSize() that doesn't match its method signature match.
Mark A. Hershberger [Sat, 11 Dec 2010 03:52:35 +0000 (03:52 +0000)]
Whitespace changes (before others) — “svn diff -x-w” shows no changes
Priyanka Dhanda [Fri, 10 Dec 2010 22:47:16 +0000 (22:47 +0000)]
If we only want to show the diff this should make it faster. Sort of related to to bug 25757
Raimond Spekking [Fri, 10 Dec 2010 22:45:37 +0000 (22:45 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-12-10 22:29:00 UTC)
Ilmari Karonen [Fri, 10 Dec 2010 22:42:46 +0000 (22:42 +0000)]
followup r78209: fix typo, better word choice
Ilmari Karonen [Fri, 10 Dec 2010 22:39:17 +0000 (22:39 +0000)]
(bug 16019) Make WebRequest::interpolateTitle() do nothing when run from api.php
Alexandre Emsenhuber [Fri, 10 Dec 2010 20:51:06 +0000 (20:51 +0000)]
* Converted Special:Search to subclass SpecialPage
* Removed useless calls to $wgOut->setArticleRelated() and $wgOut->setRobotPolicy(), they are already handled by SpecialPage::setHeaders()
Alexandre Emsenhuber [Fri, 10 Dec 2010 19:47:54 +0000 (19:47 +0000)]
Moved 1.17 RELEASE-NOTES entries to HISTORY
Alexandre Emsenhuber [Fri, 10 Dec 2010 19:40:19 +0000 (19:40 +0000)]
Whoops, forgot to commit this with r78201
Chad Horohoe [Fri, 10 Dec 2010 19:38:58 +0000 (19:38 +0000)]
Fix for r78192, forgot to revert a test
Alexandre Emsenhuber [Fri, 10 Dec 2010 18:48:11 +0000 (18:48 +0000)]
Moved constant values from constructor to class definition
Alexandre Emsenhuber [Fri, 10 Dec 2010 18:23:33 +0000 (18:23 +0000)]
Fixes for r78201:
* Per Reedy, add braces where needed
* Revert one change that should not have been there
Alexandre Emsenhuber [Fri, 10 Dec 2010 18:17:20 +0000 (18:17 +0000)]
* (bug 19006) {{REVISIONUSER}} no longer acts like {{CURRENTUSER}} in some cases
* Removed other usages of $wgUser in Parser stuff, as stated in doc
* Added mechanism to get an User object in Parser, based either on the object given in Paser::preSaveTransform() or the ParserOptions otherwise
Roan Kattouw [Fri, 10 Dec 2010 17:21:09 +0000 (17:21 +0000)]
Make load.php output a comment explaining what's going on when no modules were requested rather than outputting nothing. Max made me do this because he hates blank pages
Roan Kattouw [Fri, 10 Dec 2010 17:06:00 +0000 (17:06 +0000)]
(bug 26130) ob_start( 'ob_gzhandler' ) in LocalSettings.php broke gzip output from load.php . This is caused by bugs.php.net/bug.php?id=36514 (ob_clean() removes GZIP header). Also noticed that load.php is affected by http://bugs.php.net/bug.php?id=51579 (ob_gzhandler generates non-empty 304s, invalid HTTP, triggers a Firefox bug) as well and fixed that too while I was at it.
Chad Horohoe [Fri, 10 Dec 2010 16:03:57 +0000 (16:03 +0000)]
Revert r68230, r68231 (mode="grid" on tables) per CR. It's in the history if anyone wants to work on this again
Sam Reed [Fri, 10 Dec 2010 15:48:17 +0000 (15:48 +0000)]
Followup r78101 fixme, remove wfQuotedPrintable per Roans CR
Chad Horohoe [Fri, 10 Dec 2010 15:15:16 +0000 (15:15 +0000)]
Fix for r71961 (moved SpecialPage constructor from named to __construct()). Intercept calls to parent::SpecialPage() with __call() so we don't break people still using the old constructor.
Niklas Laxström [Fri, 10 Dec 2010 14:44:01 +0000 (14:44 +0000)]
Reduce debug log spamming, which I assume is related to this line:
1340: function isBlocked( $bFromSlave = true ) { // hacked from false due to horrible probs on site
Niklas Laxström [Fri, 10 Dec 2010 14:40:50 +0000 (14:40 +0000)]
Better debug logging which isn't misleading
Chad Horohoe [Fri, 10 Dec 2010 14:17:13 +0000 (14:17 +0000)]
Last $wgDBtype usages in core. Use a $db member variable so we can use it in other useful places too.
Chad Horohoe [Fri, 10 Dec 2010 14:04:00 +0000 (14:04 +0000)]
One more $wgDBtype. I think this is the last offender in core; all the remaining usages are justified
Chad Horohoe [Fri, 10 Dec 2010 13:56:17 +0000 (13:56 +0000)]
Get rid of a bunch of $wgDBtypes in maintenance/
Chad Horohoe [Fri, 10 Dec 2010 13:39:42 +0000 (13:39 +0000)]
Kill $wgDatabase in trunk (no need to backport this to REL1_17, it's harmless). Isn't used in extensions in 1.15 or above.
There is a $wgDatabase in Metavidwiki (and StarterWiki in 1.16), but it constructs it itself, so it's not the same as the global I'm killing
Chad Horohoe [Fri, 10 Dec 2010 13:30:26 +0000 (13:30 +0000)]
Old installer is dead. Any leftover DBMS-specific old installer code is in initial_setup() or setup_database()
Niklas Laxström [Fri, 10 Dec 2010 13:18:11 +0000 (13:18 +0000)]
Fix regression in r70657. Misplaced else condition was causing cache misses
to try to load the message text and cache the result individually. However
in the default configuration cache miss always means that the message doesn't
exists in the database.
Niklas Laxström [Fri, 10 Dec 2010 12:03:39 +0000 (12:03 +0000)]
Don't unstub $wgOut just for adding debug messages
Roan Kattouw [Fri, 10 Dec 2010 11:33:51 +0000 (11:33 +0000)]
Followup r78117: information was still leaked through the caption of the Edit tab (which is "Create" for nonexistent pages) for users who had edit but not read rights. This may seem like a ridiculous case, but since we automatically disallow edit if you can't read, it's easy to forget to disallow editing as well as reading. Fixed this by not showing the edit tab at all if the user can't read (which makes sense since it's also hidden if the user is explicitly forbidden from editing).
Roan Kattouw [Fri, 10 Dec 2010 10:55:41 +0000 (10:55 +0000)]
Fix regression in r78117 per CR, was causing read, edit and history tabs to disappear for users who couldn't edit due to $wgEmailConfirmToEdit or $wgNamespaceProtection
Tim Starling [Fri, 10 Dec 2010 03:02:03 +0000 (03:02 +0000)]
* Hide the "back" buttons on the completion pages, they are potentially confusing and almost useless.
* Made the links to the wiki on the completion pages open in the same window, not a popup.
* Do not allow the user to regenerate LocalSettings.php when $wgUpgradeKey was given and the DB settings were prefilled, since this allows a leak of $wgUpgradeKey to escalate to a leak of $wgDBpassword. It's not unreasonable to require that the user removes their old LocalSettings.php when they wish to generate a new one.
* Rewrote the doc comment on $wgUpgradeKey, to discourage users from setting it to an easily guessable string, per concerns on CR r78118.
Aaron Schulz [Fri, 10 Dec 2010 00:16:28 +0000 (00:16 +0000)]
*Follow-up r78099,r76275:
**Converted CheckUser to use RL
**Made checkuser.js borrow block.js IP functions to avoid ugly duplication (and fix the IP recognition)
**Added missing backslashes to block.js regex strings and avoided backreferences (which work the opposite of PCRE when referencing an unmatched group)
*Made CU not give a common prefix if both v6 and v4 addresses are on the list
Krinkle [Fri, 10 Dec 2010 00:13:34 +0000 (00:13 +0000)]
whitespace clean up mw.util
Roan Kattouw [Fri, 10 Dec 2010 00:06:50 +0000 (00:06 +0000)]
Revert r78158, Aryeh tells me it's a deliberate browser hack
Roan Kattouw [Thu, 9 Dec 2010 23:47:59 +0000 (23:47 +0000)]
Fix bad CSS syntax from r77411
Krinkle [Thu, 9 Dec 2010 23:42:29 +0000 (23:42 +0000)]
Added a way to hide the jsMessage by calling with empty string, null or no arguments
Krinkle [Thu, 9 Dec 2010 23:29:26 +0000 (23:29 +0000)]
Ported jsMsg to mw.util; Fixing bugs and modernising mediawiki.action.watch.ajax.js a little more
* Using the raw element instead of jQuery object to get href. This way it's the complete url instead of what could potentially be a relative path (window.location.href is best passed a complete url)
* Adding 'mediawiki.legacy.ajax' as dependency for mediawiki.action.watch.ajax as it is and has been for a while.
* Ported jsMsg (legacy.wikibits) to mw.util.jsMessage()
Krinkle [Thu, 9 Dec 2010 22:47:58 +0000 (22:47 +0000)]
Follow-up r78150, removed accidental left-over console.logs calls
Krinkle [Thu, 9 Dec 2010 22:45:49 +0000 (22:45 +0000)]
Fixing bugs and modernising mediawiki.action.watch.ajax.js a little bit
* add() takes the selector directly. Passing a jQuery object either doesn't work or is an undocumented feature.
* using the mw.util functions instead of a less than perfect regex.
* closest() instead of parents() is faster and should be used whenever possible
* The this in processResult() didn't refer to the jQuery object of the anchor tag. It was probably never noticed since it's only used in the else{}-fallback (hard to mis). Fixed now by passing the link in the function
* The this in .bind('mw-ajaxwatch') didn't refer to this either, fixed also by passing into the function
* Replace() function in .bind('mw-ajaxwatch') didn't work, the slashes causes nothing to be matched at all. Before this the href stayed the same and didn't change accordingly.