Niklas Laxström [Tue, 11 Jan 2011 14:30:03 +0000 (14:30 +0000)]
No space after unary minus
Niklas Laxström [Tue, 11 Jan 2011 14:28:35 +0000 (14:28 +0000)]
Spell false with small latter
Niklas Laxström [Tue, 11 Jan 2011 14:27:15 +0000 (14:27 +0000)]
Use same wording as in skintemplate
Chad Horohoe [Tue, 11 Jan 2011 14:00:47 +0000 (14:00 +0000)]
Fix copy+paste mistake from r79989
Chad Horohoe [Tue, 11 Jan 2011 13:54:05 +0000 (13:54 +0000)]
Fix callback issue noted in r79989 (broken in r78774).
$this makes a difference.
I'm an idiot.
Roan Kattouw [Tue, 11 Jan 2011 13:51:49 +0000 (13:51 +0000)]
Followup r80003: array_unique() preserves keys, so we got module arrays that looked like {"0": "ext.liquidThreads", "58": "mediawiki.legacy.wikibits", "59": "mediawiki.util", ... } . To prevent this from happening, use array_values() to reindex the arrays
Niklas Laxström [Tue, 11 Jan 2011 13:46:31 +0000 (13:46 +0000)]
rm stray tab
Roan Kattouw [Tue, 11 Jan 2011 13:41:40 +0000 (13:41 +0000)]
Apply array_unique() to module lists in OutputPage, should prevent lots of duplicate 'ext.liquidThreads' elements in the module array reported by thedj
Alexandre Emsenhuber [Tue, 11 Jan 2011 13:08:28 +0000 (13:08 +0000)]
Seems there was a logic error in r80001 :)
Alexandre Emsenhuber [Tue, 11 Jan 2011 13:04:55 +0000 (13:04 +0000)]
Simplify a bit:
* replaced calls to Article::getLatest() by Title::getLatestRevID()
* introduced Skin::isRevisionCurrent()
* made checks on Skin::pageStats() more coherent
Raimond Spekking [Tue, 11 Jan 2011 07:37:42 +0000 (07:37 +0000)]
Follow-up r79964: Use the existing message 'parentheses' instead of introducing an identical one.
OverlordQ [Tue, 11 Jan 2011 03:07:45 +0000 (03:07 +0000)]
I have no clue how the callbacks work, this at least sets up a database, everything after that is fubar
Sam Reed [Tue, 11 Jan 2011 02:46:55 +0000 (02:46 +0000)]
Parent in DatabaseInstaller is a CoreInstaller, not just an Installer
Priyanka Dhanda [Tue, 11 Jan 2011 01:01:54 +0000 (01:01 +0000)]
New test database resource file with some test configuration changes for it. Follow up to r79421 and r79982
Sam Reed [Tue, 11 Jan 2011 00:55:20 +0000 (00:55 +0000)]
Fixup some of the ordering of API Autoloader stuff
$reedy->ocd++;
Priyanka Dhanda [Tue, 11 Jan 2011 00:36:36 +0000 (00:36 +0000)]
Follow up to #79421. Cleaned up some globals and some typos. Going to follow up with some actual test changes
Sam Reed [Mon, 10 Jan 2011 22:36:26 +0000 (22:36 +0000)]
Normalise casing of svn:keywords Id
Add missing Id to ApiFormatDump and ApiUpload
Derk-Jan Hartman [Mon, 10 Jan 2011 22:18:08 +0000 (22:18 +0000)]
Move the () surrounding description strings of files, out of the description and into the interface.
Follows up r68324 and r68325
Sam Reed [Mon, 10 Jan 2011 22:13:01 +0000 (22:13 +0000)]
Explicitally add ApiFormatXmlRsd to the AutoLoader
Trevor Parscal [Mon, 10 Jan 2011 21:31:12 +0000 (21:31 +0000)]
Resolves bug #26655 - adds support for space before and after the URL inside the parenthesis of a url() statement in CSS.
Raimond Spekking [Mon, 10 Jan 2011 21:09:58 +0000 (21:09 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-10 20:56:00 UTC)
Raimond Spekking [Mon, 10 Jan 2011 20:54:49 +0000 (20:54 +0000)]
Follow-up r79915: Add new section in maintenance file too
Jure Kajzer [Mon, 10 Jan 2011 20:11:43 +0000 (20:11 +0000)]
* fixed oracle code for updater (corrected not null BLOB field adding)
* added required DB vars in WebInstaller_ExistingWiki
* oracle upgrades normally 1.16=>1.17
Antoine Musso [Mon, 10 Jan 2011 19:55:30 +0000 (19:55 +0000)]
Fix RFC 5322 'atext'
An additional character was introducted in the RFC 5322 atext fragment.
Spotted with r79924 which send the file as latin1 encoding.
Jure Kajzer [Mon, 10 Jan 2011 19:22:27 +0000 (19:22 +0000)]
* fixed Oracle code for installer and phpunit tests
* removed ORABlob class
Chad Horohoe [Mon, 10 Jan 2011 19:18:28 +0000 (19:18 +0000)]
More postgres
* Add user creation form like MySQL
* Fix canCreateAccounts() check
* Fix ts2 setup callback
* Still needs schema creation and other misc. stuff from lines ~370-530 of DatabasePostgres
Chad Horohoe [Mon, 10 Jan 2011 18:43:59 +0000 (18:43 +0000)]
More silly whitespace
Chad Horohoe [Mon, 10 Jan 2011 18:41:31 +0000 (18:41 +0000)]
rm big whitespace
Chad Horohoe [Mon, 10 Jan 2011 18:34:59 +0000 (18:34 +0000)]
Move table prefixes to constants, add doc to addDBData()
Sam Reed [Mon, 10 Jan 2011 18:08:54 +0000 (18:08 +0000)]
* (bug 26650) Remove $wgAPICacheHelp in favour of $wgAPICacheHelpTimeout
Alexandre Emsenhuber [Mon, 10 Jan 2011 08:33:19 +0000 (08:33 +0000)]
Be sure to use the latest rev id and not whatever getRevIdFetched() could be
Krinkle [Mon, 10 Jan 2011 05:33:03 +0000 (05:33 +0000)]
Removing unneeded wraps and using $ and mw instead of jQuery or mediaWiki since r79246 enabled the private scope by default. No need for two wraps.
(the wraps had an extra indention, hence the diff will probably look huge)
Krinkle [Mon, 10 Jan 2011 05:02:05 +0000 (05:02 +0000)]
Adding comma's at end of arrays where this hasn't been done already for consistency
Krinkle [Mon, 10 Jan 2011 04:47:38 +0000 (04:47 +0000)]
traversal indention. Follow-up r79924
Sam Reed [Mon, 10 Jan 2011 04:44:33 +0000 (04:44 +0000)]
Documentation addition/tweaks
Krinkle [Mon, 10 Jan 2011 04:40:57 +0000 (04:40 +0000)]
* Consistent single quotes
* The problem with onKeyUp was that is shows errors even when initially typing a (possibly valid) address. onBlur has the downside of not giving feedback while correcting the mistake + since e-mail is the last input element at the moment, it doesn't blur on submit and required a seperate event handler.
** Solution: Bind onBlur once, and then listen for onKeyUp.
* Adding missing semicolon(s)
* Compare with strict (===) to empty string / null
* Moved non-global wfFunction to mw.util
** The "FIXME:" note was kept
* Comment "apostrophe" fixed to "at". Comments don't run :)
* Caching selector in wfUpdateMailValidityLabel
* Renaming "wfUpdateMailValidityLabel" to "updateMailValidityLabel"
( Ping r79910, r75670, r75627 )
Derk-Jan Hartman [Sun, 9 Jan 2011 22:54:51 +0000 (22:54 +0000)]
Followup r68325, with comment describing intent of code.
Antoine Musso [Sun, 9 Jan 2011 20:30:31 +0000 (20:30 +0000)]
Correct {,in}valid js messages in UserPreferences
Add them to messages.inc
Thanks Roan and ^demon for the translation.
FU r79904
Antoine Musso [Sun, 9 Jan 2011 19:06:02 +0000 (19:06 +0000)]
Add a .tld to emails when testing for white space before/after.
This might avoid confusion when testing. Currently, an email without
a tld is invalid (ex user@host). The assertions could have been
invalid just by the lack of tld, not the spaces!
Antoine Musso [Sun, 9 Jan 2011 18:36:05 +0000 (18:36 +0000)]
js email validation improvment (onBlur)
commit log more or less follow the diff order:
* adds an id to the UserPreferences form (#mw-prefs-form)
* Add an handler on the form submission to validate the email. This also
update the label and, when email is invalid, get focus on the field.
* use onBlur javascript event instead of onKeyUp (per r75670 CR)
* Label update is now a function ... (wfUpdateMailValidityLabel)
* ... let us update the label on form submission
* Clear the label message when email is empty (null)
* Made the js regexp to stop capturing
* Fix js email validation function to return a boolean
(it still return 'null' when given an empty email address)
Niklas Laxström [Sun, 9 Jan 2011 18:31:52 +0000 (18:31 +0000)]
Partial revert of r79903, unstubbing needs localisation cache which might need database
Alexandre Emsenhuber [Sun, 9 Jan 2011 17:41:42 +0000 (17:41 +0000)]
Fix for r79874: only set $mRevIdFetched from fetchContent(), it was overriden by the loadLastEdit() call in getRevIdFetched() for old versions which caused it to be always the latest rev id
Antoine Musso [Sun, 9 Jan 2011 17:09:16 +0000 (17:09 +0000)]
js email validation fixed + i18n support
The Javascript email validation in User:Preference got broken by an id change,
this patch fix the issue.
A long standing issue was a lack of proper i18n support, message helper
was hard coded in the js file. It now use the resourceloader to get the
i18nized message.
Follow up r75670
Niklas Laxström [Sun, 9 Jan 2011 17:08:40 +0000 (17:08 +0000)]
Follow-up r79880: check if $wgLang can be used.
Changed the checks in Database.php to use is_object because of stub objects
Roan Kattouw [Sun, 9 Jan 2011 16:24:09 +0000 (16:24 +0000)]
Fix bug in ResourceLoader causing LTR->RTL flipping to only be applied to the first CSS file of every module. Thanks to thedj for reporting and investigating this bug and to Nikerabbit for finding the culprit (bad use of array_map)
Niklas Laxström [Sun, 9 Jan 2011 13:10:56 +0000 (13:10 +0000)]
* (bug 26208) Mark directionality of some interlanguage links
Niklas Laxström [Sun, 9 Jan 2011 12:56:04 +0000 (12:56 +0000)]
Bug 25010 - Bashkir-language interwikis: linktext change from Башҡорт to Башҡортса
Roan Kattouw [Sun, 9 Jan 2011 12:48:30 +0000 (12:48 +0000)]
Avoid dot bloat in paths
Niklas Laxström [Sun, 9 Jan 2011 12:46:40 +0000 (12:46 +0000)]
* (bug 25506) Exception is thrown if OutputPage::parse is called inside a tag hook, which would reset parser state
Roan Kattouw [Sun, 9 Jan 2011 12:29:02 +0000 (12:29 +0000)]
Followup r78924: keep track of exception/warning comments separately, to prevent them from being eaten by the minifier. This also prevents filter cache pollution. Additionally, uncomment some wrongfully commented-out code introduced in r78924, and add newlines after exception/warning comments
Niklas Laxström [Sun, 9 Jan 2011 12:23:41 +0000 (12:23 +0000)]
Fix syntax terror from r79884
Niklas Laxström [Sun, 9 Jan 2011 12:04:28 +0000 (12:04 +0000)]
* (bug 25708) Update case mappings and normalization to Unicode 6.0.0
Alexandre Emsenhuber [Sun, 9 Jan 2011 12:01:58 +0000 (12:01 +0000)]
Kill Article::$mCurID, not set anywhere, not used anywhere (including extensions)
Alexandre Emsenhuber [Sun, 9 Jan 2011 11:48:10 +0000 (11:48 +0000)]
Fix typo from r79874
Alexandre Emsenhuber [Sun, 9 Jan 2011 11:46:15 +0000 (11:46 +0000)]
Changed to calls to Article::getContent() to Article::getRawText():
- in Article::insertRedirect(): if this will be saved in the redirect table, it should only be checked with the current text (in fact this is never called when viewing an old revision, but just in case someone breaks this)
- in Article::prepareTextForEdit(): as for Article::doEdit() this should be actual page's contents
Roan Kattouw [Sun, 9 Jan 2011 11:44:52 +0000 (11:44 +0000)]
Add a hook for registering variables in ResourceLoaderStartUpModule::getConfig() to complement MakeGlobalVariablesScript
Niklas Laxström [Sun, 9 Jan 2011 11:30:36 +0000 (11:30 +0000)]
* (bug 26187) Confirmrecreate no longer parses the edit summary
Niklas Laxström [Sun, 9 Jan 2011 11:12:06 +0000 (11:12 +0000)]
Horrible tabsoup converted to spaces
Niklas Laxström [Sun, 9 Jan 2011 10:56:46 +0000 (10:56 +0000)]
Fix encoding
Niklas Laxström [Sun, 9 Jan 2011 10:50:42 +0000 (10:50 +0000)]
The actual error is always in English, so wrap it in ltr element
Niklas Laxström [Sun, 9 Jan 2011 10:36:13 +0000 (10:36 +0000)]
* (bug 26638) Database error pages display correctly in RTL languages
Rob Lanphier [Sun, 9 Jan 2011 02:38:04 +0000 (02:38 +0000)]
Followup to r79856: s/0.4/0.5/ and added "bytes" attribute to "text" element
Rob Lanphier [Sun, 9 Jan 2011 02:27:56 +0000 (02:27 +0000)]
Creating export-0.5.xsd as part of followup to r79856
Rob Lanphier [Sun, 9 Jan 2011 02:12:35 +0000 (02:12 +0000)]
Made it so that our existing 0.4 exports validate
Raimond Spekking [Sat, 8 Jan 2011 20:42:59 +0000 (20:42 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-09 20:27:00 UTC)
Alexandre Emsenhuber [Sat, 8 Jan 2011 20:07:18 +0000 (20:07 +0000)]
Only set $mUser, $mUserText, $mComment and $mTimestamp fields in fetchContent() if we have loaded the latests revision
Alexandre Emsenhuber [Sat, 8 Jan 2011 19:42:24 +0000 (19:42 +0000)]
Added QuickTemplate::getSkin(), useful for extensions when executing hooks passing only the template as parameter
Alexandre Emsenhuber [Sat, 8 Jan 2011 19:21:37 +0000 (19:21 +0000)]
Fix for r33432: isArticle() is to check if the content displayed is the one of the article, isArticleRelated() is more appropriate here
Krinkle [Sat, 8 Jan 2011 17:14:39 +0000 (17:14 +0000)]
Follow-up r79868
Krinkle [Sat, 8 Jan 2011 16:43:25 +0000 (16:43 +0000)]
Clean up mediawiki.special.upload.js
* (Whitespace) conventions [[Manual:Coding conventions]]
* Single quotes where possible
* Removing useless parens in some cases
* Missing semicolons (JSLint)
(Kindafollowupon r79867)
Bryan Tong Minh [Sat, 8 Jan 2011 16:24:11 +0000 (16:24 +0000)]
Follow-up r79845: Add rotation support to the upload preview using the <canvas> element. The actual rotation angle still needs to be extracted from the file using a library such as jsjpegmeta <benno.id.au/jpegmetaexample/jpegmeta.js>
Roan Kattouw [Sat, 8 Jan 2011 16:06:06 +0000 (16:06 +0000)]
(bug 26620) JavaScript error in insertTags() when jQuery is present but currentFocused is not set (e.g. on Special:Upload)
Roan Kattouw [Sat, 8 Jan 2011 16:01:31 +0000 (16:01 +0000)]
Followup r74298: add ORDER BY wl_namespace, wl_title to the query in WatchlistEditor.php , rather than conditionally adding an ORDER BY that only seems to play nice on Postgres
Roan Kattouw [Sat, 8 Jan 2011 15:54:41 +0000 (15:54 +0000)]
Per r79581 CR, add @embed comments to jQuery UI's default theme's CSS too, and combine a few background rules to prevent duplicate embedding.
Roan Kattouw [Sat, 8 Jan 2011 15:41:55 +0000 (15:41 +0000)]
Attempt at fixing bug 26370, which seems to be an infinite loop caused by ob_get_level() never going all the way down to 0 no matter how many output buffers we destroy. Use a for loop instead
Alexandre Emsenhuber [Sat, 8 Jan 2011 14:19:53 +0000 (14:19 +0000)]
No longer correct
Antoine Musso [Sat, 8 Jan 2011 13:06:17 +0000 (13:06 +0000)]
Removes $wgSecureLoginStickHTTPS which was never really used
Follow up r75585
Bryan Tong Minh [Sat, 8 Jan 2011 11:49:09 +0000 (11:49 +0000)]
Follow-up r79845: add function documentation; only call wfMakeDirsParent if we have a dest path.
On r79845 I submitted a wrong commit summary, here is it for reference:
(bug 6672) Images are now autorotated according to their EXIF orientation. Following the Flickr example, this only affects thumbnails, with the source unrotated.
* Introduced BitmapHandler::canRotate() and BitmapHandler::getRotation() to check if rotation is supported and what the amount of rotation is
* Factored out scaler determination into BitmapHandler::getScalerType()
* ImageMagick uses the -auto-orientation option
* GD uses imagerotate()
* Unconditionally show the thumb size on the image page, don't know why this wasn't shown for SVGs etc.
Rob Lanphier [Sat, 8 Jan 2011 03:11:06 +0000 (03:11 +0000)]
Bug 26563: Add bytes changed per revision for stub and full article dumps
Brion Vibber [Sat, 8 Jan 2011 01:10:42 +0000 (01:10 +0000)]
Fix & additions for strtr vs str_replace benchmarks (for bug 26605 discussion)
The strtr function in the benchmark was slightly artificially accelerated by replacing '_' with '' (empty) instead of ' ' (space), making the output string shorter and thus processing faster. This is now fixed, which makes the results slightly closer.
I also added 'indirect' functions to the benchmark, which instead of calling strtr/str_replace directly, call a global function which then calls them (equivalent to what we'd do if we turned the replaces into wf* global functions)
strtr() does appear to be slightly faster than str_replace() for this workload, but it's fairly modest and approximately the same as the overhead of a function call.
Results on my test box (MacBook Pro, 2.4GHz Core 2 Duo, Mac OS X 10.6.6, 64-bit PHP 5.3.4 built via MacPorts) with 10,000 reps:
$ php bench_strtr_str_replace.php --count=10000
10000 times: function bench_strtr_str_replace->benchstrtr() :
19.67ms ( 0.00ms each)
10000 times: function bench_strtr_str_replace->benchstr_replace() :
22.05ms ( 0.00ms each)
10000 times: function bench_strtr_str_replace->benchstrtr_indirect() :
22.53ms ( 0.00ms each)
10000 times: function bench_strtr_str_replace->benchstr_replace_indirect() :
26.29ms ( 0.00ms each)
Platonides [Sat, 8 Jan 2011 00:46:45 +0000 (00:46 +0000)]
Follow up r79848. Fix the syntax error.
Brion Vibber [Fri, 7 Jan 2011 23:52:19 +0000 (23:52 +0000)]
* (bug 26625) fix regression in Special:PrefixIndex from r75314; pages weren't listed if namespace was set but no prefix given
Chad Horohoe [Fri, 7 Jan 2011 22:41:24 +0000 (22:41 +0000)]
Rm code that has been commented out for almost 6 years
Chad Horohoe [Fri, 7 Jan 2011 22:32:52 +0000 (22:32 +0000)]
Add DatabaseBase::classFromType() to reduce the 'Database' . $type duplication
Bryan Tong Minh [Fri, 7 Jan 2011 22:13:14 +0000 (22:13 +0000)]
Follow-up r79713: add authors to README as well
Bryan Tong Minh [Fri, 7 Jan 2011 22:12:05 +0000 (22:12 +0000)]
$wgMaxUploadSize may now be set to an array to specify the upload size limit per upload type.
Backwards compatible, if not set to an array, applies to all uploads. If set to an array, per upload type maximums can be set, using the file and url keys. If the * key is set this value will be used as maximum for non-specified types.
Raimond Spekking [Fri, 7 Jan 2011 21:37:38 +0000 (21:37 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-01-07 20:49:00 UTC)
Chad Horohoe [Fri, 7 Jan 2011 20:49:11 +0000 (20:49 +0000)]
Use __construct()
Chad Horohoe [Fri, 7 Jan 2011 20:25:52 +0000 (20:25 +0000)]
Remove ancient and deprecated newFromParams() constructor wrappers from various DatabaseBase implementations. Only callers are AskSql and WikiTrust. Both are calling the (very old) Database class anyway, so are obviously expecting a MySQL connection and can use the fallback (which yells wfDeprecated) in DatabaseBase
Roan Kattouw [Fri, 7 Jan 2011 20:22:50 +0000 (20:22 +0000)]
(bug 26497) printable=yes and handheld=yes request parameters were broken. Fixed this in a bit of an ugly way, by propagating these parameters to load.php and running OutputPage::transformCssMedia() on it there. This revision also fixes the fact that ResourceLoader ignored $wgHandheldForIPhone, and no longer wraps styles in @media all { } because it's useless and breaks @import (which can't be used inside @media ; this is bug 26478)
Sam Reed [Fri, 7 Jan 2011 19:51:58 +0000 (19:51 +0000)]
Followup r66267, usage of $revisionInfo is undefined, but isset is on $uploadInfo, guessing the usages wanted to be $uploadInfo
Raimond Spekking [Fri, 7 Jan 2011 19:51:27 +0000 (19:51 +0000)]
Follow-up r79828: Add dot
Bryan Tong Minh [Fri, 7 Jan 2011 19:41:38 +0000 (19:41 +0000)]
Document how the mime<->extension map is supposed to work, to my best understanding from reading the code. Fixed the built-in mini-mime.types according to this specification. Should fix bug 26367.
Chad Horohoe [Fri, 7 Jan 2011 19:41:08 +0000 (19:41 +0000)]
Rm stray html tag
Chad Horohoe [Fri, 7 Jan 2011 18:41:55 +0000 (18:41 +0000)]
Forgot param 1, make URL param 2 per Nikerabbit
Chad Horohoe [Fri, 7 Jan 2011 18:24:56 +0000 (18:24 +0000)]
Move over some initial_setup() for Postgres (THIS IS BROKEN, NEEDS REVIEW/WORK FROM POSTGRES GUYS!!)
* Ported canCreateAccounts() check
* Moved creation of new user to setupUser()
* Moved DB creation (still needs schema stuff) to setupDatabase() where it belongs
* Added ts2 setup
TODO:
* UI for non-admin account (like MysqlInstaller::getSettingsForm) and maybe move ts2 and other "optional" settings there
* Schema creation/setup
Sam Reed [Fri, 7 Jan 2011 18:08:35 +0000 (18:08 +0000)]
Revert r79807
Roan Kattouw [Fri, 7 Jan 2011 12:59:25 +0000 (12:59 +0000)]
Fix indentation in r79746
Sam Reed [Fri, 7 Jan 2011 05:43:51 +0000 (05:43 +0000)]
Allow CLI installer to set $whShowExceptionDetails
Brian Wolff [Fri, 7 Jan 2011 03:13:16 +0000 (03:13 +0000)]
[[user:Microchip08]] suggested that it'd be cool if special:contribs redirected
to special:contributions. I also think it'd be cool, so tada.
I'm unusre if creating new special page aliases that aren't strictly neccesary
is discouraged. If it is, please mark this fixme or revert it or find me and yell at me ;)