Chad Horohoe [Fri, 21 Nov 2008 17:45:57 +0000 (17:45 +0000)]
Revert r43788 and r43788 (adding findBySha1 functionality). Something is breaking here and I don't know what...
Roan Kattouw [Fri, 21 Nov 2008 13:55:27 +0000 (13:55 +0000)]
API: (bug 16408) Added DOM tree generation (rvgeneratexml) to prop=revisions. Looks kind of ugly in XML, but bots don't care about that, and people should use less crappy-looking formats anyway.
Aryeh Gregor [Fri, 21 Nov 2008 13:20:27 +0000 (13:20 +0000)]
Add comment per wikitech-l thread
Ilmari Karonen [Fri, 21 Nov 2008 12:52:36 +0000 (12:52 +0000)]
Turn wfMkdirParents() into just a thin wrapper around mkdir( $dir, $mode, true ); this won't work in PHP4, but we don't support that, do we?
NOTE: the old code used to ignore the umask by explicitly forcing the permissions with chmod(). If this is desired behavior, it can be achieved by temporarily setting the umask to 0, as in:
$oldmask = umask( 0 );
$rv = mkdir( $dir, $mode, true );
umask( $oldmask );
return $rv;
However, I can't see why we'd want to do this. In the worst case, users with excessively tight umasks can find themselves with unusable directories, but the proper solution to that is to fix the umask rather than to
ignore it. In the best case, we've just plugged a security hole the user didn't realize they had (because they assumed their umask would Just Work).
Chad Horohoe [Fri, 21 Nov 2008 11:34:09 +0000 (11:34 +0000)]
Replace mkdir() in favor of wfMkdirParents():
* It handles directory modes for us (rather than hardcode 0777)
* It handles recursion for us
Aaron Schulz [Fri, 21 Nov 2008 09:55:13 +0000 (09:55 +0000)]
Revert r43804 'This should probably be in Response, not Request, as we're setting data, not getting it. Nothing's using it yet (fairly new), so nothing to update.'
Session id is used by client request to specify its login data from cookie, so the session data, by extensions, is like a sort of request parameter. Also, WebResponse.php seems to be used for data actually sent to the client, like requested cookies.
Chad Horohoe [Fri, 21 Nov 2008 09:24:57 +0000 (09:24 +0000)]
Revert r43785 (switching hardcoded Image: to loading the canonical name). This causes an interesting regression...trunk cannot use this with an API below r43639 (when Image was renamed to File), as File:Someimage.ext doesn't make sense to these wikis. Keeping it hardcoded might be best, if Image is in fact remaining an alias to File.
Chad Horohoe [Fri, 21 Nov 2008 09:01:26 +0000 (09:01 +0000)]
This should probably be in Response, not Request, as we're setting data, not getting it. Nothing's using it yet (fairly new), so nothing to update.
Chad Horohoe [Fri, 21 Nov 2008 06:46:31 +0000 (06:46 +0000)]
(bug 8702) Refactor stats updating in nukePage. Now updates edit count and good article count, not just total page count.
Ilmari Karonen [Fri, 21 Nov 2008 06:08:31 +0000 (06:08 +0000)]
also fix image names with magic tildes in them, got a few on enwiki
Ilmari Karonen [Fri, 21 Nov 2008 04:54:47 +0000 (04:54 +0000)]
Clean up image titles with HTML entities (made invalid in r28968). Also misc. improvements: fail gracefully if buildSafeTitle() fails, move description page and old image revisions too.
Aaron Schulz [Fri, 21 Nov 2008 00:45:43 +0000 (00:45 +0000)]
Remove duplicate group rights
Siebrand Mazeland [Fri, 21 Nov 2008 00:36:12 +0000 (00:36 +0000)]
Localisation updates for core messages from Betawiki (2008-11-21 01:16 CET)
Aaron Schulz [Fri, 21 Nov 2008 00:31:56 +0000 (00:31 +0000)]
(bug 16388) 'HTMLFileCache's $mFileCache is initialized too late'
Chad Horohoe [Fri, 21 Nov 2008 00:22:44 +0000 (00:22 +0000)]
Typo (and incidentally, it works 100% now :)
Chad Horohoe [Fri, 21 Nov 2008 00:18:47 +0000 (00:18 +0000)]
Add experimental findBySha1 functionality for ForeignAPIRepo.
Siebrand Mazeland [Fri, 21 Nov 2008 00:05:24 +0000 (00:05 +0000)]
Remove fixed characters (spaces and comma) from listToText().
* Updated message 'and' for all languages to keep behaviour the same, no change for 'ksh' (wanted behaviour), changed 'en' (trailing comma).
* Added message 'word-separator' as optional message. Just a space for all languages at the moment.
Steve Sanbeg [Thu, 20 Nov 2008 23:55:38 +0000 (23:55 +0000)]
undo 43772; there seems to be various special behavior hacked onto <div>, some of which may be intentional
Chad Horohoe [Thu, 20 Nov 2008 23:43:32 +0000 (23:43 +0000)]
Get the real canonical name for NS_IMAGE, don't assume it will be Image: forever.
Charles Melbye [Thu, 20 Nov 2008 23:30:08 +0000 (23:30 +0000)]
Added a new configuration option ($wgUsePrivateIPs) to force MediaWiki to use forwarded Private IPs from a Proxy server
Huji [Thu, 20 Nov 2008 21:10:27 +0000 (21:10 +0000)]
Localisation updates: Adding/updating Persian translations
Steve Sanbeg [Thu, 20 Nov 2008 20:50:12 +0000 (20:50 +0000)]
this should prevent the parser from inserting <p> tags around the second line of divs
Rotem Liss [Thu, 20 Nov 2008 15:17:14 +0000 (15:17 +0000)]
Localization update for he.
Roan Kattouw [Thu, 20 Nov 2008 15:15:00 +0000 (15:15 +0000)]
Fix up r43673: reindex the rights array after removing duplicates
Roan Kattouw [Thu, 20 Nov 2008 14:46:10 +0000 (14:46 +0000)]
API: (bug 16398) meta=userinfo&uiprop=rights lists a right twice if it's granted to two groups the user is in
Siebrand Mazeland [Thu, 20 Nov 2008 12:10:08 +0000 (12:10 +0000)]
Localisation updates for core messages from Betawiki (2008-11-20 12:57 CET)
Siebrand Mazeland [Thu, 20 Nov 2008 11:23:05 +0000 (11:23 +0000)]
Remove accidentally added BOM
Siebrand Mazeland [Thu, 20 Nov 2008 11:09:36 +0000 (11:09 +0000)]
Fix incorrect setting for namespace alias for NS_IMAGE_TALK from r43687
Siebrand Mazeland [Thu, 20 Nov 2008 11:02:42 +0000 (11:02 +0000)]
Update 'undelete-show-file-confirm' to allow time and date to be used separately.
Siebrand Mazeland [Wed, 19 Nov 2008 21:12:41 +0000 (21:12 +0000)]
Localisation updates for core from Betawiki
Siebrand Mazeland [Wed, 19 Nov 2008 21:01:39 +0000 (21:01 +0000)]
Localisation updates for core messages from Betawiki (2008-11-19 21:50 CET)
Rotem Liss [Wed, 19 Nov 2008 18:15:05 +0000 (18:15 +0000)]
Localization update.
Siebrand Mazeland [Wed, 19 Nov 2008 17:01:06 +0000 (17:01 +0000)]
'pages' -> 'content pages' where applicable in search page
Andrew Garrett [Wed, 19 Nov 2008 12:05:33 +0000 (12:05 +0000)]
Revert "Starter for a re-jig of hit counting (in a per-day table)."
That was supposed to be in a branch.
Andrew Garrett [Wed, 19 Nov 2008 12:01:43 +0000 (12:01 +0000)]
Starter for a re-jig of hit counting (in a per-day table).
Needs configurability, purty graphs, and some cleanup in the back-end.
Siebrand Mazeland [Wed, 19 Nov 2008 11:55:50 +0000 (11:55 +0000)]
Update magic words for Ukranian
Siebrand Mazeland [Wed, 19 Nov 2008 11:47:16 +0000 (11:47 +0000)]
Revert magic word localisation updates from r43441 for now. Somehow Russian aliases ended up in there too. Working on fixing this with Ahonc.
Aaron Schulz [Wed, 19 Nov 2008 09:08:49 +0000 (09:08 +0000)]
More fixes and consistency tweaks
Siebrand Mazeland [Wed, 19 Nov 2008 09:02:48 +0000 (09:02 +0000)]
Localisation updates for core messages from Betawiki (2008-11-19 09:50 CET)
Aaron Schulz [Wed, 19 Nov 2008 08:35:04 +0000 (08:35 +0000)]
* Checkbox fix
* Remove unused var
* Add $this->sk field
* Tweak code style
* Adding missing wfProfileOut( __METHOD__ );
Aaron Schulz [Wed, 19 Nov 2008 01:45:32 +0000 (01:45 +0000)]
* Make for loop faster
* Don't show incomplete prefix links
* Show the 'project' namespaces
* Tweak table margins
Aaron Schulz [Wed, 19 Nov 2008 00:19:25 +0000 (00:19 +0000)]
* Remove <hr/>
* Use count variables since they are already there
Aaron Schulz [Wed, 19 Nov 2008 00:11:14 +0000 (00:11 +0000)]
Add FeedItem::stripComment() and remove duplication
Aaron Schulz [Wed, 19 Nov 2008 00:02:23 +0000 (00:02 +0000)]
* Remove incomplete isFileCacheable(), the parent one is fine
* Break long line
Chad Horohoe [Tue, 18 Nov 2008 22:48:03 +0000 (22:48 +0000)]
* Move user-agent construction to its own method, so we're not writing the same string in two places (and provides a reliable way for getting MW's standard user-agent)
* Mark visibility, they're all public anyway
Siebrand Mazeland [Tue, 18 Nov 2008 22:22:31 +0000 (22:22 +0000)]
Fix syntax error in MessagesTe.php in r43687
Siebrand Mazeland [Tue, 18 Nov 2008 22:21:35 +0000 (22:21 +0000)]
Localisation updates for core from Betawiki
* Namespace updates
Siebrand Mazeland [Tue, 18 Nov 2008 22:18:31 +0000 (22:18 +0000)]
Localisation updates for core from Betawiki
* Namespace updates
Chad Horohoe [Tue, 18 Nov 2008 21:37:11 +0000 (21:37 +0000)]
Bunch of globals laying around and nobody using them.
Rotem Liss [Tue, 18 Nov 2008 20:27:47 +0000 (20:27 +0000)]
Localization update.
Chad Horohoe [Tue, 18 Nov 2008 19:57:03 +0000 (19:57 +0000)]
(bug 2077) Info on how to use external editor is vague. Minor tweak to the UI should make it a little more clear.
Rotem Liss [Tue, 18 Nov 2008 18:55:38 +0000 (18:55 +0000)]
Localization:
* Update for he.
* Rebuilding MessagesEn.php.
* Marking 'coll-template_blacklist_title' as an ignored message.
Roan Kattouw [Tue, 18 Nov 2008 16:05:24 +0000 (16:05 +0000)]
API: (bug 12760) meta=userinfo&uiprop=ratelimits doesn't list group-specific rate limits
Roan Kattouw [Tue, 18 Nov 2008 15:21:04 +0000 (15:21 +0000)]
API: Make reblocking (introduced in r42843) possible through the API
* Add reblock parameter to action=block
* Tweak the description for allowusertalk for consistency
Roan Kattouw [Tue, 18 Nov 2008 15:11:11 +0000 (15:11 +0000)]
API: (bug 16367) Add allowusertalk attribute to list=blocks output
Raimond Spekking [Tue, 18 Nov 2008 12:54:53 +0000 (12:54 +0000)]
* (bug 11728) Unify layout of enhanced watchlist/recent changes:
Changed from:
Time Page (4 changes) . . (+bytes) . . (hist) [list of editors]
To:
Time Page (4 changes; hist) . . (+bytes) . . [list of editors]
Use consistent message for the history link
Patch by Mormegil
Chad Horohoe [Tue, 18 Nov 2008 12:11:03 +0000 (12:11 +0000)]
Cleanup to r43657, don't really need strlen() here.
Raimond Spekking [Tue, 18 Nov 2008 09:36:19 +0000 (09:36 +0000)]
Add hints for maximum values of some user preferences.
Raimond Spekking [Tue, 18 Nov 2008 08:11:58 +0000 (08:11 +0000)]
Update per r43658 and r43661
Tim Starling [Tue, 18 Nov 2008 05:58:24 +0000 (05:58 +0000)]
Mark the functions I just accessed from outside the class as explicitly "public"
Tim Starling [Tue, 18 Nov 2008 05:57:08 +0000 (05:57 +0000)]
Protect users from attacks against their browsers via malicious script-containing uploads, by:
1) Requiring a session token before streaming files out via Special:Undelete
2) Restricting img_auth.php to private wikis only (its intended use case)
Tim Starling [Tue, 18 Nov 2008 05:07:54 +0000 (05:07 +0000)]
Improved the security of wfStreamFile():
* Use the file extension to determine Content-Type, don't look for magic numbers. This makes the attack surface similar to ordinary web server downloads, and avoids problems when MIME type is not checked on upload.
* Use the same restrictions for Content-Type when streaming as for uploading. This closes any vulnerabilities caused by a change to a more secure configuration, post-upload.
* Don't stream out the file after headers are unexpectedly sent (e.g. due to display_errors). The Content-Type will typically be fixed to text/html in this case and so we need to be careful what we send.
Andrew Garrett [Tue, 18 Nov 2008 02:53:29 +0000 (02:53 +0000)]
Remove some debugging code...
Andrew Garrett [Tue, 18 Nov 2008 02:20:55 +0000 (02:20 +0000)]
Warn when re-uploading a file with the same SHA1/extension pair as a file which has been deleted.
Chad Horohoe [Tue, 18 Nov 2008 02:03:44 +0000 (02:03 +0000)]
Bit of path cleanup per comments on code review (r43316). Construct proper hash paths and use the image name as a child directory of that.
Aaron Schulz [Tue, 18 Nov 2008 01:24:56 +0000 (01:24 +0000)]
Rename function to 'rasterize'
Aaron Schulz [Tue, 18 Nov 2008 01:18:12 +0000 (01:18 +0000)]
Refactor SvgHandler to have transformSvgToPng() function, which can be used for non-thumbnail purposes
Brion Vibber [Mon, 17 Nov 2008 22:09:29 +0000 (22:09 +0000)]
Reverting r43642 "Added $wgLoginAutocomplete to let wiki owner disable password autocompletion in Special:Userlogin by setting it to false. Defaults to true."
There's not a compelling reason to make it hard for users to manage their own password affairs here.
Roan Kattouw [Mon, 17 Nov 2008 21:55:36 +0000 (21:55 +0000)]
Fix up r43617: put RELEASE-NOTES entry in the API section
Marco Schuster [Mon, 17 Nov 2008 21:49:29 +0000 (21:49 +0000)]
Added $wgLoginAutocomplete to let wiki owner disable password autocompletion in Special:Userlogin by setting it to false. Defaults to true.
Marco Schuster [Mon, 17 Nov 2008 21:28:42 +0000 (21:28 +0000)]
Disabled auto-completion for password in Special:Preferences. Should resolve the behaviour described at lists.wikimedia.org/pipermail/wikitech-l/2008-November/040067.html
Siebrand Mazeland [Mon, 17 Nov 2008 21:27:00 +0000 (21:27 +0000)]
(bug 44) Rename Image namespace to File. Based on a patch by brion.
* Parser tests updated. 14 failing parser tests before the change, added one, and the same 14 failing parser tests are remaining
* added namespace aliases for Image and Image_talk for backward compatibility purposes
Marco Schuster [Mon, 17 Nov 2008 21:18:37 +0000 (21:18 +0000)]
little bit of cleanup in the generator for the "remember login" toggle
Siebrand Mazeland [Mon, 17 Nov 2008 20:21:17 +0000 (20:21 +0000)]
Localisation updates for core messages from Betawiki (2008-11-17 21:14 CET)
Brion Vibber [Mon, 17 Nov 2008 20:04:50 +0000 (20:04 +0000)]
Revert r43592 "Pass the user object in MakeGlobalVariablesScript in case some variables are user-dependent."
As a UI thingy, $wgUser will be the only relevant user object here; there's no circumstance in which we might pass some other user object. No reason to pass it to hooks just on the off chance that they might use it, then...
Brion Vibber [Mon, 17 Nov 2008 19:57:00 +0000 (19:57 +0000)]
Part of r43581 bits, reverting.
Brion Vibber [Mon, 17 Nov 2008 19:51:53 +0000 (19:51 +0000)]
Reverting r43581 "Added a new user right called "alwaysuseskin" that allows the user to use and set their configured skin even if the wiki administrator has
chosen to disable user skins for the rest of the wiki. Req. by Alexfusco5."
Seems a little weird to me; I'm not quite sure the use case. :)
Comments on the revision note that it needs documentation as well, and the name is a bit weird. If it is needed/desireable it might be better to just replace $wgAllowUserSkin with a right 'useskin' or something.
Rotem Liss [Mon, 17 Nov 2008 19:15:53 +0000 (19:15 +0000)]
Localization update.
Brion Vibber [Mon, 17 Nov 2008 19:03:37 +0000 (19:03 +0000)]
* Improved scripting safety heuristics for IE 5/6 content-type detection.
* Improved scripting safety heuristics on SVG uploads.
Siebrand Mazeland [Mon, 17 Nov 2008 19:01:32 +0000 (19:01 +0000)]
Update messages.inc per r43624
Brion Vibber [Mon, 17 Nov 2008 19:01:07 +0000 (19:01 +0000)]
* Add a .htaccess to deleted images directory for additional protection
against exposure of deleted files with known SHA-1 hashes on default
installations.
Applying Tim's fixes
Brion Vibber [Mon, 17 Nov 2008 18:58:57 +0000 (18:58 +0000)]
* Improved input validation on Special:Import form
Applying Tim's fixes
Brion Vibber [Mon, 17 Nov 2008 18:54:55 +0000 (18:54 +0000)]
* Blacklist redirects via Special:Filepath, hard to use.
Committing Tim's fixes...
Brion Vibber [Mon, 17 Nov 2008 18:53:35 +0000 (18:53 +0000)]
* Less verbose errors from profileinfo.php when not configured
Brion Vibber [Mon, 17 Nov 2008 18:51:21 +0000 (18:51 +0000)]
* Safer handling of non-MediaWiki exceptions -- now obeys our settings for formatting and path exposure.
Applying Tim's fixes...
Brion Vibber [Mon, 17 Nov 2008 18:13:11 +0000 (18:13 +0000)]
* API siteinfo query no longer throws an exception for empty sifilter parameter.
The parameter is defined as being one of two values ('local' or '!local'), but comes back as array() if it was specified but empty... which then got overly-strictly checked against 'false', which was used internally for the case where it's unspecified, and an exception thrown internally.
Now the filter parameter is nicely ignored whether it's unspecified or specified as empty, which is good clear behavior.
As before, other values return a standard API error about invalid values being passed.
Rotem Liss [Mon, 17 Nov 2008 17:52:41 +0000 (17:52 +0000)]
Localization update for he.
Raimond Spekking [Mon, 17 Nov 2008 17:38:30 +0000 (17:38 +0000)]
Add a class when a usergroup contains no members to allow hiding these rows per Commons.css or user specific CSS. Per suggestion of Purodha.
Siebrand Mazeland [Mon, 17 Nov 2008 10:07:19 +0000 (10:07 +0000)]
Localisation updates for core messages from Betawiki
* re-export new search UI messages
* copy contents of 'helppage' to 'searchhelp-url'
Aaron Schulz [Mon, 17 Nov 2008 04:56:14 +0000 (04:56 +0000)]
* Re-commit new search UI code, disabled by default. Old form messages still used and thus kept.
* Update old-fashioned profile calls
Brion Vibber [Mon, 17 Nov 2008 04:30:31 +0000 (04:30 +0000)]
Rename file to lowercase per its use. (Some folks use case-sensitive filesystems on their servers, like.... oh.... every Unix/Linux that's not Mac OS X)
Chad Horohoe [Mon, 17 Nov 2008 02:33:29 +0000 (02:33 +0000)]
Pass the user object in MakeGlobalVariablesScript in case some variables are user-dependent.
Siebrand Mazeland [Mon, 17 Nov 2008 00:13:16 +0000 (00:13 +0000)]
Localisation updates for core messages from Betawiki (2008-11-17 01:10 CET)
Aaron Schulz [Sun, 16 Nov 2008 23:18:43 +0000 (23:18 +0000)]
Refactor getCharacterDifference()
Charles Melbye [Sun, 16 Nov 2008 21:09:32 +0000 (21:09 +0000)]
Forgot to update one part, and also got rid of some historial stuff (hiding
preview links if they can't choose a skin).
Charles Melbye [Sun, 16 Nov 2008 20:57:21 +0000 (20:57 +0000)]
Added a new user right called "alwaysuseskin" that allows the user to
use and set their configured skin even if the wiki administrator has
chosen to disable user skins for the rest of the wiki. Req. by Alexfusco5.
Rotem Liss [Sun, 16 Nov 2008 19:20:44 +0000 (19:20 +0000)]
Localization update for he.
Siebrand Mazeland [Sun, 16 Nov 2008 18:46:57 +0000 (18:46 +0000)]
Change default special page names for special page names containing "image". Leave old names in for backward compatibility.
Siebrand Mazeland [Sun, 16 Nov 2008 15:43:38 +0000 (15:43 +0000)]
Localisation updates for core messages from Betawiki (2008-11-16 16:25 CET)
Raimond Spekking [Sun, 16 Nov 2008 14:55:48 +0000 (14:55 +0000)]
Add 'statistics-summary' as default existing but empty message (to be ignored for i18n)