Antoine Musso [Mon, 16 Jan 2012 10:36:55 +0000 (10:36 +0000)]
typo in r103711: right -> rights
Antoine Musso [Mon, 16 Jan 2012 10:33:24 +0000 (10:33 +0000)]
Skip BrokenRedirectsPage query test under MySQL
The MySQL backend, when using temporary tables, does not support referencing
a table which was already open.
http://bugs.mysql.com/bug.php?id=10327
This patch skip BrokenRedirectsPage on MySQL as reported on r102411.
Santhosh Thottingal [Mon, 16 Jan 2012 10:05:48 +0000 (10:05 +0000)]
reintroduce the shortcut evaluation removed in r108403 and r108405
Amir E. Aharoni [Mon, 16 Jan 2012 09:46:56 +0000 (09:46 +0000)]
Improved the comment about the two-forms plural shortcut.
Antoine Musso [Mon, 16 Jan 2012 08:59:17 +0000 (08:59 +0000)]
reverts wgDeprecationWhitelist
Per wikitech-l
Reverts r106883 and r106946
Aaron Schulz [Sun, 15 Jan 2012 22:45:14 +0000 (22:45 +0000)]
In FileOp/FileBackend:
* Added SHA-1 to FileOp::attemptBatch $predicates (since concatenate was removed from FileOp). This lets us get rid of temp file backups, as the remaining failure case is just the backend medium going down (the ops would break in that case anyway). Doing so reduces RTTs and backup file I/O overhead. This also simplifies expiry object support by avoiding having to stash the expiry values of temp backup objects somewhere.
* Improved precheck() and attempt() status logic in FileOp::attemptBatch() a bit. Use separate $subStatus var to check if each op is OK.
* A few minor code cleanups and comment tweaks.
* Fixed MoveFileOp bug found in unit tests when the source/dest are the same and an overwriteDest/overwriteSame param is given (the file would just get deleted). Improved CopyFileOp in this case too.
Other:
* Added more unit tests.
Aaron Schulz [Sun, 15 Jan 2012 22:21:51 +0000 (22:21 +0000)]
* Killed an RTT in SwiftFileBackend::doStreamFile(). We already check existence in FileBackend::streamFile()
* A few minor code cleanups and comment tweaks.
Alexandre Emsenhuber [Sun, 15 Jan 2012 22:00:04 +0000 (22:00 +0000)]
Use the context's WikiPage object if the title of the new revision is the same as context's title; avoids a duplicated database query to load the WikiPage
Raimond Spekking [Sun, 15 Jan 2012 20:22:43 +0000 (20:22 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Jeroen De Dauw [Sun, 15 Jan 2012 16:13:16 +0000 (16:13 +0000)]
added some docs
Krinkle [Sun, 15 Jan 2012 13:56:55 +0000 (13:56 +0000)]
[mediawiki.action.history.diff.css] remove redundant css rule
* Background color reset for tables is no longer needed per r80495
* See r80495 commitmsg for rationale for removal of the `table { backgroundL: white }` rule
* Also touched in r105280
Alexandre Emsenhuber [Sun, 15 Jan 2012 12:30:14 +0000 (12:30 +0000)]
* Use WikiPage instead of Article to call doEdit()
* Pass the User object to WikiPage::doEdit()
Alexandre Emsenhuber [Sun, 15 Jan 2012 11:42:36 +0000 (11:42 +0000)]
* Fix Profiler::getUserTime() to return a float and not string with space separated values since, was breaking difference calculation since PHP doesn't know how to make the difference of two strings :P
* Same when adding fake items in the stack after a profiling error
* Removed useless ProfilerSimple::getTime()
Antoine Musso [Sun, 15 Jan 2012 11:05:51 +0000 (11:05 +0000)]
Release note for ug 17959
Bug 17959 - Inline rendering/thumbnailing for Gimp XCF images
Forgotten in r107351
John Du Hart [Sun, 15 Jan 2012 06:07:24 +0000 (06:07 +0000)]
Adding jquery.arrowSteps to core, from UploadWizard
Sam Reed [Sat, 14 Jan 2012 23:45:21 +0000 (23:45 +0000)]
* (bug 33733) API: Unknown error: mustbeloggedin
Add message to messagemap
Aaron Schulz [Sat, 14 Jan 2012 23:15:32 +0000 (23:15 +0000)]
r108944: fixed bogus field...php-cloudfiles documentation misspelled this, it's 'object_count' not 'count'
Aaron Schulz [Sat, 14 Jan 2012 23:11:21 +0000 (23:11 +0000)]
In SwiftFileBackend:
* Added getContainer(), createContainer(), and deleteContainer() helper functions, which cache container objects to avoid RTTs
* Made doCleanInternal() delete empty containers
* Bumped authentication TTL to 120 seconds
* Some comment tweaks
Amir E. Aharoni [Sat, 14 Jan 2012 22:32:18 +0000 (22:32 +0000)]
A bit of documentation.
Chad Horohoe [Sat, 14 Jan 2012 22:21:30 +0000 (22:21 +0000)]
Revert r108777 (making eval subclass maintenance). eval's supposed to be in the global context. See r54839
Niklas Laxström [Sat, 14 Jan 2012 22:00:27 +0000 (22:00 +0000)]
Typo
Amir E. Aharoni [Sat, 14 Jan 2012 20:26:54 +0000 (20:26 +0000)]
Follow up to r108927. Replaced die() with throw new MWException(), according to ^demon's suggestion.
Aaron Schulz [Sat, 14 Jan 2012 19:17:17 +0000 (19:17 +0000)]
r105512: Handle REDIRECT_URL discrepancies and always work with URI paths for thumb 404 handling
Sam Reed [Sat, 14 Jan 2012 18:32:04 +0000 (18:32 +0000)]
RELEASE-NOTES-1.19 for r108876
Raimond Spekking [Sat, 14 Jan 2012 17:55:26 +0000 (17:55 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Amir E. Aharoni [Sat, 14 Jan 2012 17:51:14 +0000 (17:51 +0000)]
Changing the failure message to something more meaningful.
Sam Reed [Sat, 14 Jan 2012 15:27:30 +0000 (15:27 +0000)]
Documentation
Wrapping up some long lines
Alexandre Emsenhuber [Sat, 14 Jan 2012 14:53:32 +0000 (14:53 +0000)]
No need to do the safe_mode check on every request in $wgAdditionalMailParams is set; that variable will not be passed to mail() if safe_mode is enabled since r99411
Alexandre Emsenhuber [Sat, 14 Jan 2012 14:27:46 +0000 (14:27 +0000)]
Per Aaron, fix for r108274: added canUseWikiPage() to context objects to know whether getWikiPage() can be safely called
Alexandre Emsenhuber [Sat, 14 Jan 2012 14:18:56 +0000 (14:18 +0000)]
Fix for r107939: PHP Notice: Undefined variable: exportall in includes/specials/SpecialExport.php on line 173 when the "export all" checkbox is not checked
Alexandre Emsenhuber [Sat, 14 Jan 2012 14:11:08 +0000 (14:11 +0000)]
* Use WikiPage instead of Article to call commitRollback()
* Pass the User object from WikiPage::commitRollback() to WikiPage::doEdit()
* Do the edits with 'Maintenance script' user as other maintenance scripts instead of 127.0.0.1
Alexandre Emsenhuber [Sat, 14 Jan 2012 13:15:19 +0000 (13:15 +0000)]
Fix comment, this doesn't use $wgTitle anymore
Aaron Schulz [Sat, 14 Jan 2012 03:16:18 +0000 (03:16 +0000)]
* Fixed bogus var in LSLockManager.
* Made DBLockManager constructor a bit more convenient to use with just 'localDBMaster' in the db buckets.
* Documentation tweaks.
Aaron Schulz [Sat, 14 Jan 2012 01:52:19 +0000 (01:52 +0000)]
* Renamed ContainerShardListIterator -> FileBackendShardListIterator
* Renamed FSFileIterator -> FSFileBackendFileList
* Renamed SwiftFileIterator -> SwiftFileBackendFileList and added it to autoloader
* A few minor doc fixes
Aaron Schulz [Sat, 14 Jan 2012 00:50:18 +0000 (00:50 +0000)]
Fixed annoying bug in FileRepo::deleteBatch() when a file is deleted that has multiple identical versions. The operation would fail due to the file already existing.
Krinkle [Sat, 14 Jan 2012 00:40:48 +0000 (00:40 +0000)]
[Core JS] Fix code from r107327 which was broken by r108222
-- Of course one most not assume the DOM is finished enough for #p-logo to be parsed, simply bind to document ready
Sam Reed [Sat, 14 Jan 2012 00:25:26 +0000 (00:25 +0000)]
Revert out r108882
Sam Reed [Sat, 14 Jan 2012 00:09:58 +0000 (00:09 +0000)]
Recommitting r108367 to break unit tests as phpunit on ubuntu seems FUBAR'd again
Will revert after
Aaron Schulz [Fri, 13 Jan 2012 23:39:48 +0000 (23:39 +0000)]
Removed call to ParserTest::setUp() which was unnecessary. Also, the called function leaks globals anyway atm.
Aaron Schulz [Fri, 13 Jan 2012 23:30:46 +0000 (23:30 +0000)]
In FileBackend:
* Made secure() call doPrepare() for caller dummy proofing (especially those that don't check the status).
In FSFileBackend:
* Removed redundant wfMkdirParents() calls in FSFileBackend, we already have prepare() for this purpose. This also keeps it's behavior more consistent with the other backends.
* Made use of 'backend-fail-store' message in doStoreInternal().
Other:
* Updated unit tests and renamed $src => $source in some functions for consistency.
* Added some documentation comments and @since tags.
Antoine Musso [Fri, 13 Jan 2012 23:26:26 +0000 (23:26 +0000)]
Disable MWDebug tests for now
PHPUnit is too old on gallium so assertCount() is not recognized
The other two tests are broken for an unknown reason.
Sam Reed [Fri, 13 Jan 2012 23:14:28 +0000 (23:14 +0000)]
Rather than using an error code of unknownerror, use the error code returned by EditPage if it's a string, and it has length, else just return the usual "unknownerror"
Antoine Musso [Fri, 13 Jan 2012 23:10:21 +0000 (23:10 +0000)]
MWDebug: avoid double count()
Follow r107954
Antoine Musso [Fri, 13 Jan 2012 23:07:52 +0000 (23:07 +0000)]
some tests for MWDebug
Really incomplete. We need better testing.
Added two new public methods so we can get or clear the internal logs.
Benny Situ [Fri, 13 Jan 2012 22:58:32 +0000 (22:58 +0000)]
followup to -r107187 - adding bug24430 patch to 1.19 release note
Benny Situ [Fri, 13 Jan 2012 22:48:21 +0000 (22:48 +0000)]
Add bug33703 fix to 1.19 release note
Benny Situ [Fri, 13 Jan 2012 22:27:16 +0000 (22:27 +0000)]
patch from fomafix - bug33703 - remove black border-bottom-color for abbr
mrbluesky [Fri, 13 Jan 2012 22:19:01 +0000 (22:19 +0000)]
Fixing comments
Using shell style comments here stops Doxygen from processing the rest of the comments.
See http://svn.wikimedia.org/doc/classHTMLForm.html
Antoine Musso [Fri, 13 Jan 2012 22:09:11 +0000 (22:09 +0000)]
XCF: force rendering
Browsers do not support GIMP native format (yet?!). So we really need
to force rendering.
Noticed by Mark while testing the feature on labs.
Follow r107351
Rob Moen [Fri, 13 Jan 2012 21:57:52 +0000 (21:57 +0000)]
reverted r108850 as patch should be introduced after code freeze
Niklas Laxström [Fri, 13 Jan 2012 21:50:13 +0000 (21:50 +0000)]
@since, ping r101030
Sam Reed [Fri, 13 Jan 2012 21:42:31 +0000 (21:42 +0000)]
() are valid in URLs, not sure why we're using them as a finishing point in ApiFormatBase
Fixes fixme on r95572 as urls are now complete with () in them
Siebrand Mazeland [Fri, 13 Jan 2012 21:28:59 +0000 (21:28 +0000)]
Add 'api-error-unknownerror' and update punctuation and quotes for api-error-* where needed.
Rob Moen [Fri, 13 Jan 2012 21:24:38 +0000 (21:24 +0000)]
patch from MrBlueSky, resloves bug 25909. Add dropdown list for tags in recent changes and new pages
Niklas Laxström [Fri, 13 Jan 2012 21:19:44 +0000 (21:19 +0000)]
Ping r108847, missed one half quote
Siebrand Mazeland [Fri, 13 Jan 2012 21:11:27 +0000 (21:11 +0000)]
Change usage of quotes in API messages from ``x'' to "x".
Raimond Spekking [Fri, 13 Jan 2012 20:57:43 +0000 (20:57 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Niklas Laxström [Fri, 13 Jan 2012 16:56:48 +0000 (16:56 +0000)]
Fixing plural. Would "file, which" be clearer?
Siebrand Mazeland [Fri, 13 Jan 2012 14:47:27 +0000 (14:47 +0000)]
Add 'api-error-emptypage'.
Alexandre Emsenhuber [Fri, 13 Jan 2012 13:30:58 +0000 (13:30 +0000)]
Fix for r108376: the whole string is already espcaed on output, no need to escape it twice
Alexandre Emsenhuber [Fri, 13 Jan 2012 13:28:58 +0000 (13:28 +0000)]
Per Aaron, fix for r107776: correct count() check
Aaron Schulz [Fri, 13 Jan 2012 09:14:56 +0000 (09:14 +0000)]
r88633: lazy-load 'customFilters' field in SpecialRecentChanges. Almost every function is public here so there no control of the order stuff happens.
Niklas Laxström [Fri, 13 Jan 2012 08:41:33 +0000 (08:41 +0000)]
Fix broken indentation
Aaron Schulz [Fri, 13 Jan 2012 04:32:28 +0000 (04:32 +0000)]
* Distinguish "does not exist" from failure in FSFileBackend::doGetFileStat().
* Added clearstatcache() to doConcatenate() to make it safe for callers to stat the file.
* A few minor comment tweaks.
Sam Reed [Fri, 13 Jan 2012 02:40:09 +0000 (02:40 +0000)]
Partial revert ContextSource changes from r108785, r108786
Sam Reed [Fri, 13 Jan 2012 02:37:04 +0000 (02:37 +0000)]
Push msg from ContextSource/RequestContext into IContextSource
Sam Reed [Fri, 13 Jan 2012 02:30:51 +0000 (02:30 +0000)]
A couple more for r108785
More doucmentations
Sam Reed [Fri, 13 Jan 2012 02:27:44 +0000 (02:27 +0000)]
Documentation
As we're using stuff from ContextSource everwhere, limiting stuff to a type hint of IContextSource isn't much use
OverlordQ [Thu, 12 Jan 2012 23:22:09 +0000 (23:22 +0000)]
Followup to r108744
Sam Reed [Thu, 12 Jan 2012 23:10:22 +0000 (23:10 +0000)]
Maintenance class-ify eval.php
Sam Reed [Thu, 12 Jan 2012 22:57:51 +0000 (22:57 +0000)]
Give sql.php eval.php type scrollback
Sam Reed [Thu, 12 Jan 2012 22:35:48 +0000 (22:35 +0000)]
Followup r108768, callign the right callback helps too
Brion Vibber [Thu, 12 Jan 2012 22:17:54 +0000 (22:17 +0000)]
Revert r108764: doesn't appear to do what it says in the description, and no explanation why it's being done (presumably would just break searches again?)
Sam Reed [Thu, 12 Jan 2012 22:14:56 +0000 (22:14 +0000)]
Fix typo in SpecialVersion
Change require to require_once in commandLine.inc
Make eval.php require an absolute path rather than just one in itself
Simplify if statement
OverlordQ [Thu, 12 Jan 2012 22:11:12 +0000 (22:11 +0000)]
Followup to r107866, add in new job_timestamp field which was likely completely breaking anything related to the job queue, should fix failing TemplateCategoriesTest.testTemplateCategories on PG
Sam Reed [Thu, 12 Jan 2012 22:10:24 +0000 (22:10 +0000)]
Add $inputCsllback to sourceStream(), to return full lines back to the calling function
Will be used soooon
Aaron Schulz [Thu, 12 Jan 2012 22:01:02 +0000 (22:01 +0000)]
* Collapse multiple directory separators in FileBackend::normalizeStoragePath(). Also renamed the function to normalizeContainerPath() to be less confusing.
* Made SwiftFileBackend respect the 'latest' parameter of various functions via "X-Newest: true" header. Added to TODO in the doGetFileStat() function, as cloudfiles needs upstream changes for that.
* Fixed SwiftFileIterator to return paths relative to the given directory.
* Clean up for FSFileBackend trailing slash handling.
Diederik van Liere [Thu, 12 Jan 2012 21:34:55 +0000 (21:34 +0000)]
This commit restores getPrefixedText() to the Title in the XML. This means it does not break anything, the only change is that there is a new separate element that contains the namespace.
This commit is a follow up to:
r102575: Commit to fix bug 30513.
Raimond Spekking [Thu, 12 Jan 2012 21:22:22 +0000 (21:22 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Thu, 12 Jan 2012 20:50:14 +0000 (20:50 +0000)]
FU r106752: updated populateImageSha1.php script as needed
Aaron Schulz [Thu, 12 Jan 2012 20:05:25 +0000 (20:05 +0000)]
* Added backend name to 'backend-fail-internal' message
* Removed TODO comment in SwiftFileBackend
Aaron Schulz [Thu, 12 Jan 2012 20:01:54 +0000 (20:01 +0000)]
* Merged (added) SwiftFileBackend class from branch.
* Added i18n messages used by the new class.
Aaron Schulz [Thu, 12 Jan 2012 19:41:18 +0000 (19:41 +0000)]
Reverted r108743 per CR comment. This should at least be discussed first.
Aaron Schulz [Thu, 12 Jan 2012 19:20:58 +0000 (19:20 +0000)]
* Fixed a bit of bogus code left in r108740
* Added some class comments
Sam Reed [Thu, 12 Jan 2012 19:12:24 +0000 (19:12 +0000)]
Kill "* @return void"
Sam Reed [Thu, 12 Jan 2012 19:04:06 +0000 (19:04 +0000)]
Unindent code to use elseif
Sam Reed [Thu, 12 Jan 2012 19:03:32 +0000 (19:03 +0000)]
Documentation
Wrap some long lines
Aaron Schulz [Thu, 12 Jan 2012 18:44:00 +0000 (18:44 +0000)]
* Added 'basePath' config param to FSFileBackend and tweaked it to behave more similarly to the backends with real containers (e.g. everything else). Resolution to absolute paths is now deferred after resolveStoragePath(), using resolveToFSPath().
* Fixed whitespace in FSFileIterator.
Max Semenik [Thu, 12 Jan 2012 17:36:06 +0000 (17:36 +0000)]
Consistency: made all API examples a verbs
OverlordQ [Thu, 12 Jan 2012 17:10:48 +0000 (17:10 +0000)]
Followup to whatever revision added us_chunk_inx
Antoine Musso [Thu, 12 Jan 2012 16:42:33 +0000 (16:42 +0000)]
swap assertEquals parameters in TemplateCategoriesTest
First parameter is expected, second is the result
Antoine Musso [Thu, 12 Jan 2012 10:59:13 +0000 (10:59 +0000)]
(bug 32508) Fix updater output
site_stats updated is still a database action.
Purge cache is now the very last one.
Output:
<snip>
...site_stats is populated...done.
Purging caches...done.
Done.
Antoine Musso [Thu, 12 Jan 2012 09:03:38 +0000 (09:03 +0000)]
bug 33583 search ns user pref ignored!
r106780 to fix bug 33270 introduced a new bug that prevented selected
namespaces for search to be applied. This patch fix the issue.
Credits to Brad Jorsch
Sam Reed [Wed, 11 Jan 2012 21:52:44 +0000 (21:52 +0000)]
* (bug 33117) prop=revisions allows deleted text to be exposed through cache pollution
Max Semenik [Wed, 11 Jan 2012 20:19:55 +0000 (20:19 +0000)]
Revert r108603, which was itself a revert of r107376, r107994. Before considering something unneeded, please ask first ;)
Raimond Spekking [Wed, 11 Jan 2012 20:17:10 +0000 (20:17 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Niklas Laxström [Wed, 11 Jan 2012 19:47:21 +0000 (19:47 +0000)]
Apparently we can commit code that doesn't compile but I am not allowed to have commit summary as "){} -> ) {}"
Alexandre Emsenhuber [Wed, 11 Jan 2012 19:23:57 +0000 (19:23 +0000)]
Whitespaces fixes only, no functional changes.
Rob Moen [Wed, 11 Jan 2012 18:00:49 +0000 (18:00 +0000)]
remove concurrency resource per revert. follow up r108600
Sam Reed [Wed, 11 Jan 2012 15:51:07 +0000 (15:51 +0000)]
Add @since to getPerformedAction, added in r108342
Caused site errors as not in 1.18 when trying to merge r108345 as a followup to r94131