Bryan Tong Minh [Sat, 26 Feb 2011 14:30:52 +0000 (14:30 +0000)]
Add TEMPORARY TABLE support to Sqlite
Bryan Tong Minh [Sat, 26 Feb 2011 13:51:46 +0000 (13:51 +0000)]
(bug 27700) The upload protection can now also be set for files that do not exist.
Sort of follow-up to r79655, adds create to $wgRestrictionTypes in DefaultSettings.php as well and removes it when not applicable.
Chad Horohoe [Sat, 26 Feb 2011 13:51:03 +0000 (13:51 +0000)]
Turn hidden help into always-visible info box for user rights info
Alexandre Emsenhuber [Sat, 26 Feb 2011 13:28:02 +0000 (13:28 +0000)]
Don't even try to get user's IP address if he has 'ipblock-exempt' right
Max Semenik [Sat, 26 Feb 2011 13:07:37 +0000 (13:07 +0000)]
More prominent mention of r82845
Chad Horohoe [Sat, 26 Feb 2011 12:56:32 +0000 (12:56 +0000)]
Tweak comment, we don't create LS in the conf dir anymore, you have to upload it
Max Semenik [Sat, 26 Feb 2011 12:51:35 +0000 (12:51 +0000)]
Follow-up r82845: fix $wgScriptPath detection.
Max Semenik [Sat, 26 Feb 2011 12:35:23 +0000 (12:35 +0000)]
(bug 1379) Installer directory conflicts with some hosts' configuration panel.
Renamed config/ to mw-config/, however left aliases for b/c.
Bryan Tong Minh [Sat, 26 Feb 2011 12:19:55 +0000 (12:19 +0000)]
Remove double parser test from r82843
Bryan Tong Minh [Sat, 26 Feb 2011 12:08:59 +0000 (12:08 +0000)]
(bug 27679) Broken embedded files with special characters are no longer double HTML escaped
Was a double escape in Linker::makeBrokenImageLinkObj. I checked the callers and other usages in the function and $prefix and $inside appear to be assumed HTML fragments
Added parser tests: Passed 622 of 624 tests (99.68%)... 2 tests failed! Those two tests already failed for me before this patch
Chad Horohoe [Sat, 26 Feb 2011 10:55:44 +0000 (10:55 +0000)]
Null -> null, reorder docs to match signature
Niklas Laxström [Sat, 26 Feb 2011 08:19:21 +0000 (08:19 +0000)]
Fix bug that caused "Non-string key given" exception.
Broken since introducsed in r10810 almost six years ago.
This proves that the exception in message caches is valid and covers errors.
Tested that exception is no longer thrown.
Sam Reed [Fri, 25 Feb 2011 21:41:19 +0000 (21:41 +0000)]
Followup r82810, r82813, r82814
Only display hidden stuff if any vaguely related property is set
Raimond Spekking [Fri, 25 Feb 2011 21:28:08 +0000 (21:28 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-25 20:05:00 UTC)
Sam Reed [Fri, 25 Feb 2011 20:24:08 +0000 (20:24 +0000)]
Fix double indenting
Sam Reed [Fri, 25 Feb 2011 20:22:54 +0000 (20:22 +0000)]
One minor followup to r82810
return $vals; early, rather than indenting all of the code another level
Brian Wolff [Fri, 25 Feb 2011 20:16:19 +0000 (20:16 +0000)]
(follow-up r82810) Address Reedy's comments on irc.
Brian Wolff [Fri, 25 Feb 2011 19:51:37 +0000 (19:51 +0000)]
(bug 27715) Make imageinfo api module respect revDelete.
This treats metadata and similar properties to be deleted if the file is deleted, since they
are derived from the file, and i know examples of where the file was deleted to hide sensitive
data in exif. Does still show the file size if file is deleted, because that is what is done
in interface. Follows what ApiQueryLogEvents does and outputs userhidden="" if the user cannot
be displayed due to being hidden.
Due to this bug, all the secret oversight cabal info could be visible for images, so probably
should be merged into wmf stuff soon as possible.
Sam Reed [Fri, 25 Feb 2011 19:09:39 +0000 (19:09 +0000)]
Implement getRequireOnlyOneParameterErrorMessages, to make the error messages requireOnlyOneParameter can throw.
Use in 4 modules for more dynamicness
Sam Reed [Fri, 25 Feb 2011 17:21:34 +0000 (17:21 +0000)]
Display userid, and actually put username in user (like usual)
Fix up a bad description
Sam Reed [Fri, 25 Feb 2011 16:53:33 +0000 (16:53 +0000)]
Commit stuff from my w/c
Remove white line
Make second if else if (they're opposites)
Sam Reed [Fri, 25 Feb 2011 16:19:44 +0000 (16:19 +0000)]
* (bug 27708) list=users does not have a property to return user id
Add userid to ApiQueryUsers
Move userid in ApiQueryAllUsers before name
Alexandre Emsenhuber [Fri, 25 Feb 2011 11:48:14 +0000 (11:48 +0000)]
* (bug 27680) Fix for r82273: wgCanonicalSpecialPageName no longer false when requesting a special page with subpage parameter
The problem is that in this case $wgOut's Title object is not exactely the same $wgTitle because of line 600 of SpecialPage:
$wgTitle = $page->getTitle();
which strips the subpage parameter. Now using SpecialPage::resolveAliasWithSubpage() so that it works in all cases.
Also PHP strikes again for not allowing SpecialPage::resolveAliasWithSubpage( $title->getDBkey() )[0] syntax. YAY :)
Tim Starling [Fri, 25 Feb 2011 04:51:17 +0000 (04:51 +0000)]
* (bug 24230) Added JAR detection. ZIP archives containing a .class file will be rejected by default. Malformed ZIP archives will be rejected due to the danger of ambiguous parsing on the client side.
* Removed the ZIP subtypes from $wgMimeTypeBlacklist, they no longer need to be there.
* Added ZipDirectoryReader. Added some small ZIP files which are used to test its various error cases. Most were constructed with a hex editor.
* Fixed getStatusArray() to return a consistent type regardless of whether the error message has parameters. This allows error messages with no parameters to work with the Status object conversion code in UploadBase::verifyFile().
Krinkle [Thu, 24 Feb 2011 23:10:04 +0000 (23:10 +0000)]
changing implied if-statement into a real if-statment; Passes strict settings of JSHint now as well
Sam Reed [Thu, 24 Feb 2011 23:03:55 +0000 (23:03 +0000)]
Refactor code a little bit, save doing redundant checks if known not necessary.
Improves flow a little
Sam Reed [Thu, 24 Feb 2011 23:03:00 +0000 (23:03 +0000)]
Bit of documentation, explicitness, variable definition
Krinkle [Thu, 24 Feb 2011 23:02:56 +0000 (23:02 +0000)]
caching selector instead of re-creating the jQuery object for 'this' two or three times
Krinkle [Thu, 24 Feb 2011 21:16:41 +0000 (21:16 +0000)]
Removed white-background from ul.gallery; Updated commonPrint gallery styles
Since a while now proper margins and overflow prevent underlines and stuff from shining through other elements (such as tables, thumbs and galleries). Therefore there's no longer a need to force a white-background which caused ugly galleries on (parts of) pages with a non-white background (ie. a table.wikitable, or div.toccolours or Commons' {{Information}} template)
The printstyles were outdated (stil targeted <table> instead of the new fluid galleries' <ul>). Updated now and white background removed there as well
* This commit fixes (bug 27458) Remove white background-color from ul.gallery
* r65923 introduced print-style for galleries (to make them look like galleries instead of tables)
* r77411 made galleries fluid and therewith changed the element from <table> to <ul>
Raimond Spekking [Thu, 24 Feb 2011 20:48:38 +0000 (20:48 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-24 20:21:00 UTC)
Sam Reed [Thu, 24 Feb 2011 20:46:45 +0000 (20:46 +0000)]
Fixup one missed alias rename from r82739
Mark A. Hershberger [Thu, 24 Feb 2011 20:23:49 +0000 (20:23 +0000)]
* EOL w/s cleanup
* Normalize function names to eliminate two references to “HalfParsedDATA”
Sam Reed [Thu, 24 Feb 2011 18:46:12 +0000 (18:46 +0000)]
Followup to r82739 (bug 27688)
Remove u1 table aliases
Sam Reed [Thu, 24 Feb 2011 18:43:44 +0000 (18:43 +0000)]
* (bug 27688) Simplify queries to list user block information
Also expose block expiry information, listed on Users, but not all users
Some minor simplifications to come
OverlordQ [Thu, 24 Feb 2011 17:16:31 +0000 (17:16 +0000)]
Fix core parserTests for recent <gallery> changes
Sam Reed [Thu, 24 Feb 2011 17:04:49 +0000 (17:04 +0000)]
More member variable documentation
Alexandre Emsenhuber [Thu, 24 Feb 2011 16:19:42 +0000 (16:19 +0000)]
Fix variable name in comment
Sam Reed [Thu, 24 Feb 2011 16:00:06 +0000 (16:00 +0000)]
Followup r82727, improve comments, cast return value to bool
Sam Reed [Thu, 24 Feb 2011 15:51:51 +0000 (15:51 +0000)]
Seems the api edit watch/unwatch wasn't too well tested (after it got poked a lot)
EditPage::commitWatch() unconditionally does a watch/unwatch...
And multiple watches of a watched page end up with an INSERT IGNORE, so not a big deal
Sam Reed [Thu, 24 Feb 2011 13:59:58 +0000 (13:59 +0000)]
* (bug 27681) Set $namespaceGenderAliases for Portuguese (pt and pt-br)
Add release notes for 2 other language bugs too
Sam Reed [Thu, 24 Feb 2011 11:59:51 +0000 (11:59 +0000)]
Add a couple of type hints noticed when poking bug 27673
Siebrand Mazeland [Thu, 24 Feb 2011 09:39:28 +0000 (09:39 +0000)]
(bug 27426) Add namespace gender aliases for Arabic.
Siebrand Mazeland [Thu, 24 Feb 2011 08:48:01 +0000 (08:48 +0000)]
Update punctuation.
Sam Reed [Thu, 24 Feb 2011 00:52:09 +0000 (00:52 +0000)]
Normalising API documentation
2 modules list older, newer
7 list newer, older
So changing 2 different to match the 7
Tim Starling [Wed, 23 Feb 2011 23:42:04 +0000 (23:42 +0000)]
Fixes for r82645:
* Fixed several obvious bugs in the $wgCiteCacheReferences helper functions, missed due to inadequate testing.
* Don't save complete Title objects to memcached, they contain cached data with a short lifetime.
* Fixed a doc comment.
Mark A. Hershberger [Wed, 23 Feb 2011 20:32:57 +0000 (20:32 +0000)]
(Bug #27634) TOC title appears in wrong language
Patch from P.Copp
Raimond Spekking [Wed, 23 Feb 2011 20:29:27 +0000 (20:29 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-23 20:13:00 UTC)
Alexandre Emsenhuber [Wed, 23 Feb 2011 20:23:35 +0000 (20:23 +0000)]
Factorise common code:
* Made appendQuery() use appendQueryArray() by using wfCgiToArray()
* Introduced getQueryValues() to get values passed in the query string; FauxRequest will return an empty array when faking a POST request
Antoine Musso [Wed, 23 Feb 2011 19:56:33 +0000 (19:56 +0000)]
Minor typos
(Trow -> Throw, Sens->sense), follow up CR on r82577
Chad Horohoe [Wed, 23 Feb 2011 17:54:45 +0000 (17:54 +0000)]
(bug 25855) Installer does not validate Memcached server settings
Alexandre Emsenhuber [Wed, 23 Feb 2011 17:54:02 +0000 (17:54 +0000)]
Use $wgRequest to get and set session items instead of $_SESSION (as for cookies)
Chad Horohoe [Wed, 23 Feb 2011 17:22:09 +0000 (17:22 +0000)]
Move doclink pages to the left sidebar, rather than the right.
The right should be steps :)
Chad Horohoe [Wed, 23 Feb 2011 16:48:11 +0000 (16:48 +0000)]
Partial revert r81779, $wgHooks is needed. Also add $wgAutoloadClasses
Chad Horohoe [Wed, 23 Feb 2011 16:42:42 +0000 (16:42 +0000)]
Followup r81534, use addQuotes() instead
Max Semenik [Wed, 23 Feb 2011 16:27:50 +0000 (16:27 +0000)]
Tweak message from r82676
Chad Horohoe [Wed, 23 Feb 2011 16:18:51 +0000 (16:18 +0000)]
Don't allow the user to create DB users with no passwords, it's not good practice.
We can't stop them from using users that already have empty passwords, but we can refuse to create it ;-)
Chad Horohoe [Wed, 23 Feb 2011 16:01:22 +0000 (16:01 +0000)]
Various Postgres fixes (bug 26612 stuff)
* Remove last of $wgDBuser-specific settings like timezone, datestyle and search_path. This is all handled by open() :D
* Only set search_path if the schema exists (rather than just set to some random string), fall back to 'public' otherwise
* Only call setupUser() if we need to _CreateDBAccount, otherwise it returns immediately and confuses you (no functional change)
* Implement selectDB() for Postgres, basically call open() with a new DB name
* Try to fix setupDatabase() for this "user must be owner of relation" error I'm getting when the $wgDBuser exists (have tried with roles granted && no roles granted). I get no errors at all when
Roan Kattouw [Wed, 23 Feb 2011 15:54:19 +0000 (15:54 +0000)]
Followup r82550: define variables passed by reference to preg_match() beforehand, to prevent E_NOTICEs
Chad Horohoe [Wed, 23 Feb 2011 14:26:45 +0000 (14:26 +0000)]
Fix backwards canCreateAccounts() check, remove setting search_path for $wgDBuser, since this is set per-session on open()
Chad Horohoe [Wed, 23 Feb 2011 13:53:47 +0000 (13:53 +0000)]
Rm unused member variable
Chad Horohoe [Wed, 23 Feb 2011 13:51:00 +0000 (13:51 +0000)]
Per bug 26612, set datestyle and timezone in open() rather than relying on $wgDBuser having specific settings.
Sam Reed [Wed, 23 Feb 2011 12:56:46 +0000 (12:56 +0000)]
Followup r82659
Comment out the USE INDEX, it creates a query error as the query is built wrongly.
Will report as a bug.
Will revert to previous behaviour of not forcing any index
Sam Reed [Wed, 23 Feb 2011 12:35:41 +0000 (12:35 +0000)]
Ununsed variables
Documentation and explicit definitions
Max Semenik [Wed, 23 Feb 2011 12:35:11 +0000 (12:35 +0000)]
(bug 20244) Installer does not validate SQLite database directory for stable path.
This is a must for 1.17 so adding a note to HISTORY instead of RELEASE-NOTES
Sam Reed [Wed, 23 Feb 2011 12:27:06 +0000 (12:27 +0000)]
Fixup SpecialListusers, $useIndex wasn't being used in the query, so make it be
Max Semenik [Wed, 23 Feb 2011 08:06:11 +0000 (08:06 +0000)]
Very basic JavaScriiptDistiller tests, needs serious expansion
Max Semenik [Wed, 23 Feb 2011 07:28:15 +0000 (07:28 +0000)]
Revert coloring from r79117: doesn't work on Windows
Tim Starling [Wed, 23 Feb 2011 06:58:15 +0000 (06:58 +0000)]
* Rewrote StripState to not use ReplacementArray. The memory usage of FSS was excessive when there were many (>10k) strip items. I used preg_replace_callback(), which is slower than strtr() in the simplest case, but much faster than it when the markers have different lengths, which they usually do.
* It was not necessary to preserve the $stripState->general->setPair() interface since it wasn't used by any extensions.
* Moved StripState to its own file.
* Refactored serialiseHalfParsedText() and unserialiseHalfParsedText() so that the bulk of the functionality is in the relevant modules, instead of using scary direct access to object member variables. Made it support the new StripState. It seemed like a lot of work to go to to support an "emergency optimisation" feature in Cite. Cite updates will be in a subsequent commit.
* Fixed spelling of serialiseHalfParsedText() and unserialiseHalfParsedText(), there is unavoidable interface breakage anyway, due to cache object versioning.
* Moved transparent tags to their own function, as requested in a fixme comment.
* Added documentation for markerSkipCallback().
* Removed OnlyIncludeReplacer, unused since MW 1.12.
Sam Reed [Tue, 22 Feb 2011 23:40:48 +0000 (23:40 +0000)]
Followup r82641, set default for 2nd param
Fix caller in SpecialLinkSearch.php
Sam Reed [Tue, 22 Feb 2011 23:26:53 +0000 (23:26 +0000)]
Remove now redundant comment after r82641
Sam Reed [Tue, 22 Feb 2011 23:22:09 +0000 (23:22 +0000)]
Followup r78786, per complaints on r82636, revert parameter ordering
Mark doQuery as deprecated/not the suggested run point
Add a couple of braces
Raimond Spekking [Tue, 22 Feb 2011 21:52:34 +0000 (21:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-22 21:13:00 UTC)
Max Semenik [Tue, 22 Feb 2011 17:15:48 +0000 (17:15 +0000)]
Follow-up r82504: use JS redirection only for IE, I don't like how it looks at least in Opera (sometimes images are not loaded)
Ryan Schmidt [Tue, 22 Feb 2011 16:39:17 +0000 (16:39 +0000)]
* random redirect-related fixes:
** automatically add redirect=no to all links on the redirect page in Article::viewRedirect.
** properly check if redirects are enabled if $wgMaxRedirects < 1 (moved check from Title::newFromRedirectArray to Title::newFromRedirectInternal).
Sam Reed [Tue, 22 Feb 2011 15:33:02 +0000 (15:33 +0000)]
* (bug 27633) Add characters to linkTrail for Potuguese (pt and pt-br)
Add RELEASE-NOTES for r82547
Platonides [Tue, 22 Feb 2011 15:09:41 +0000 (15:09 +0000)]
Remove trailing ?>
Platonides [Tue, 22 Feb 2011 15:05:08 +0000 (15:05 +0000)]
Rename startExternalParse() when used for internal usage, per r80818 CR.
Platonides [Tue, 22 Feb 2011 10:26:00 +0000 (10:26 +0000)]
Merge r67177 from 1.16wmf4
Platonides [Mon, 21 Feb 2011 23:19:26 +0000 (23:19 +0000)]
maintenance/commandLine.inc loads DefaultSettings, LocalSettings and then runs Setup.php
As Setup.php assigns variables based on the cache config, bootstrap.php was late on reseting them, as some objects were already created.
So we could end up with a SqlBagOStuff created there, which when later accessed (such as trying to invalidate the cache for a user) would
-as any non-sqlite SqlBagOStuff- open a new db connection. Which is precisely what we shall not be done when dealing with temporary tables
(and would indeed fail miserably due to not finding unittest_objectcache table).
In summary, reenabling temporary tables disabled in r79411.
Antoine Musso [Mon, 21 Feb 2011 22:56:16 +0000 (22:56 +0000)]
remove hardcoded local path
Platonides [Mon, 21 Feb 2011 22:36:35 +0000 (22:36 +0000)]
Follow up r80205 magic, so that you can also use require.
Antoine Musso [Mon, 21 Feb 2011 22:17:06 +0000 (22:17 +0000)]
improve namespace related methods
MWNamespace::getTalk() could give erroneus results when using it on specials
namespaces (NS_MEDIA, NS_SPECIAL). It now use MWNamespace::isMethodValidFor()
which will throw an exception if a special namespace was given.
MWNamespace::getSubject() is now returning identity for specials namespaces.
New MWNamespace::getAssociated() used to find out the subject page of a talk
page and vice versa. Special namespaces will results in an exception.
TESTS:
Added tests for almost complete code coverage. Functions relying on global
$wgCanonicalNamespaces are still incomplete though.
MWNamespace::isMovable() needs more assertions.
Tests results (ignoring incomplete tests output):
$ php phpunit.php --filter MWNamespace
PHPUnit 3.5.10 by Sebastian Bergmann.
.........IIIII..........
Time: 1 second, Memory: 31.75Mb
OK, but incomplete or skipped tests!
Tests: 24, Assertions: 99, Incomplete: 5.
Krinkle [Mon, 21 Feb 2011 21:24:09 +0000 (21:24 +0000)]
Add missing to mw.config
Raimond Spekking [Mon, 21 Feb 2011 20:36:18 +0000 (20:36 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-21 20:13:00 UTC)
Krinkle [Mon, 21 Feb 2011 20:36:07 +0000 (20:36 +0000)]
Follow-up r73270. Moving the attribute check down to the point where it's for sure not a string or undefined. (caused 'cant call getAttribute member function on non-object el [undefined]'. Also add a check to verify that el is a dom element and not just not indefined
Sam Reed [Mon, 21 Feb 2011 19:48:15 +0000 (19:48 +0000)]
* (bug 27616) Add userid of blocked user and blocker to list=blocks
Also tweak comment about "blocking admin". Non admins can block if they have the right... Sooo, "user" is more appropriate
Sam Reed [Mon, 21 Feb 2011 19:34:57 +0000 (19:34 +0000)]
* (bug 27611) list=blocks: Use ipb_by_text instead of join with user table
Save a table join when looking up blocks (yay!)
Minor issue, for blocks where users have been renamed, we get their old name (Not a big deal IMHO)
Sam Reed [Mon, 21 Feb 2011 19:12:13 +0000 (19:12 +0000)]
De-escaping $ at end of linkTrail regexes dating back from r15823 and beyond
Sam Reed [Mon, 21 Feb 2011 19:02:55 +0000 (19:02 +0000)]
Per Hashar on r82547, u modifier needed on regexes
Sam Reed [Mon, 21 Feb 2011 17:12:33 +0000 (17:12 +0000)]
Fixup and add another return type
Sam Reed [Mon, 21 Feb 2011 17:03:18 +0000 (17:03 +0000)]
Some more member variable type hints
Tim Starling [Mon, 21 Feb 2011 14:17:50 +0000 (14:17 +0000)]
Rewrote LanguageConverter::autoConvert() to make it use preg_match() with an offset instead of preg_split(). Reduces memory usage for my test case ([[台灣演員列表]]) to a negligible amount. This should eliminate the most common cause of OOMs on Wikimedia. Produces the exact same output for that test case for the zh -> zh-tw, parser tests pass, seems to work.
Sam Reed [Mon, 21 Feb 2011 13:33:10 +0000 (13:33 +0000)]
Add basic linktrail to SH and SL
Derk-Jan Hartman [Sun, 20 Feb 2011 21:31:15 +0000 (21:31 +0000)]
Gallery's perrow was overwriting the original style= attribute.
Raimond Spekking [Sun, 20 Feb 2011 20:52:59 +0000 (20:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-02-20 20:02:00 UTC)
Roan Kattouw [Sun, 20 Feb 2011 19:27:03 +0000 (19:27 +0000)]
(bug 27355) Guard against context being null, this happens when wikiEditor disables itself in unsupported browsers and was causing a JS error
Jack Phoenix [Sun, 20 Feb 2011 19:04:58 +0000 (19:04 +0000)]
spaces, added some braces to DairikiDiff.php
Platonides [Sun, 20 Feb 2011 17:52:09 +0000 (17:52 +0000)]
Spaces to tabs
Antoine Musso [Sun, 20 Feb 2011 17:44:37 +0000 (17:44 +0000)]
Force wgDebugTimestamps false
Test GlobalTest::testDebugFunctionTest() does not take into account the setting
$wgDebugTimestamps = true. Setting it false makes sure the tests pass though
not testing the settings :(
Roan Kattouw [Sun, 20 Feb 2011 17:24:42 +0000 (17:24 +0000)]
(bug 27468) Move private styles out to their own section, so they override everything except user styles. Moved from one makeResourceLoaderLink() call with array_merge() to multiple calls, because makeResourceLoaderLink() orders the modules, then groups them, so the input order is not preserved. Also fixed an issue in makeResourceLoaderLink() where the $uery variable was reused in each iteration but not cleared, allowing pollution to occur in theory (doesn't seem to have happened in practice, though).