Jack Phoenix [Mon, 1 Feb 2010 13:52:55 +0000 (13:52 +0000)]
Skin class: documentation and spacing tweaks, shortened some long lines, added braces
Aaron Schulz [Mon, 1 Feb 2010 11:01:14 +0000 (11:01 +0000)]
Add period after space of undo title
Mark A. Hershberger [Mon, 1 Feb 2010 07:05:23 +0000 (07:05 +0000)]
follow up r61355, initial, incomplete dealing with TimStarlings CR
Tim Starling [Mon, 1 Feb 2010 06:06:31 +0000 (06:06 +0000)]
For r61355:
* Removed style note, nobody cares
* Fixed indenting and braces
Mark A. Hershberger [Mon, 1 Feb 2010 04:59:59 +0000 (04:59 +0000)]
follow up r61775 (reapply): Fix parsertests so that they work even when server-side thumbnailing isn't configured.
Mark A. Hershberger [Mon, 1 Feb 2010 04:57:42 +0000 (04:57 +0000)]
follow up 61775 -- REVERT REVERT
Mark A. Hershberger [Mon, 1 Feb 2010 04:55:15 +0000 (04:55 +0000)]
Fix parsertests so that they work even when server-side thumbnailing isn't configured.
Mark A. Hershberger [Mon, 1 Feb 2010 02:45:23 +0000 (02:45 +0000)]
fixes problem on PHP 5.1 where titles are displayed as "Object":
TimStarling sez: "presumably some clever person has been using __toString()"
Why did it have to be in code *I* wrote?
Aryeh Gregor [Mon, 1 Feb 2010 01:43:07 +0000 (01:43 +0000)]
Require $wgHtml5 for $wgExperimentalHtmlIds
This way, if you want to disable HTML5 you don't have to turn off an
extra setting to maintain validity.
Sam Reed [Sun, 31 Jan 2010 23:28:33 +0000 (23:28 +0000)]
Add myself to Api Credits
Sam Reed [Sun, 31 Jan 2010 23:12:17 +0000 (23:12 +0000)]
Last fail change from r61761
Sam Reed [Sun, 31 Jan 2010 23:10:57 +0000 (23:10 +0000)]
Rem extra brace from r61761
Sam Reed [Sun, 31 Jan 2010 23:09:03 +0000 (23:09 +0000)]
Fix r61760/r61762
Sam Reed [Sun, 31 Jan 2010 23:08:15 +0000 (23:08 +0000)]
Fix r61760
Sam Reed [Sun, 31 Jan 2010 23:06:35 +0000 (23:06 +0000)]
Finish (bug 18427) Comment (edit summary) parser option for API
Followup to r61747 r61754 (RELEASE-NOTES to cover whole bug)
Sam Reed [Sun, 31 Jan 2010 22:28:27 +0000 (22:28 +0000)]
in_array to isset on ApiQueryLogEvents as per (most?) rest of the API
Sam Reed [Sun, 31 Jan 2010 22:06:02 +0000 (22:06 +0000)]
* (bug 20809) Expose EditFormPreloadText via the API
If page exists, don't run hook and just display ''
Comment for readable and url
Roan Kattouw [Sun, 31 Jan 2010 21:54:29 +0000 (21:54 +0000)]
Revert changes to Spyc in r61756: changes tabs to spaces, so it actually makes it worse. Also, I believe that we don't stylize libraries from external sources as a general rule
Sam Reed [Sun, 31 Jan 2010 21:21:46 +0000 (21:21 +0000)]
Stylize.php on API
Sam Reed [Sun, 31 Jan 2010 21:12:15 +0000 (21:12 +0000)]
Whitespace/brace cleanup to ApiQueryDeletedrevs
Sam Reed [Sun, 31 Jan 2010 20:59:50 +0000 (20:59 +0000)]
bug 18427 - Parsed comment on prop=revision
Raimond Spekking [Sun, 31 Jan 2010 20:01:53 +0000 (20:01 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-01-31 19:30 UTC)
Sam Reed [Sun, 31 Jan 2010 19:46:23 +0000 (19:46 +0000)]
ParamDescriptions for ApiQueryRevisions were inconsistently starting with upper and lower case.
Normalise to Upper case (as per rest of API)
Max Semenik [Sun, 31 Jan 2010 18:26:37 +0000 (18:26 +0000)]
(bug 16039) Text disappearing after a bad image
Max Semenik [Sun, 31 Jan 2010 18:16:05 +0000 (18:16 +0000)]
Rv extra precautions from r61465. I think I was confused by bug 16039 into adding it
Sam Reed [Sun, 31 Jan 2010 17:45:51 +0000 (17:45 +0000)]
Part 1 of bug 18427 - "add comment= parameter to action=parse, spitting out <parsedcomment> with
the HTML"
Done outputting "parsedsummary", though, summary may suffice?
Rotem Liss [Sun, 31 Jan 2010 17:22:56 +0000 (17:22 +0000)]
Localization update for he.
Siebrand Mazeland [Sun, 31 Jan 2010 10:56:41 +0000 (10:56 +0000)]
(bug 22324) Remove no longer used message 'uploadcorrupt'. Pointed out by Karun Dambietz
Victor Vasiliev [Sun, 31 Jan 2010 01:16:55 +0000 (01:16 +0000)]
Modify IPBlockForm::(un)suppressUserName so it can be used on a different database.
Siebrand Mazeland [Sat, 30 Jan 2010 23:34:31 +0000 (23:34 +0000)]
Localisation updates for core messages from translatewiki.net
* update namespace names and special page aliases for Upper Franconian
* remove trailing whitespace
Siebrand Mazeland [Sat, 30 Jan 2010 23:31:22 +0000 (23:31 +0000)]
Localisation updates for core messages from translatewiki.net
* add Upper Franconian
* cleanup renamed users
* misc. updates
Sam Reed [Sat, 30 Jan 2010 22:57:18 +0000 (22:57 +0000)]
RELEASE-NOTES for r61730 after https://bugzilla.wikimedia.org/show_bug.cgi?id=18758#c4
* (bug 18758) API read of watchlist's wl_notificationtimestamp
Sam Reed [Sat, 30 Jan 2010 22:48:54 +0000 (22:48 +0000)]
Start of implementation of bug 18758 - Get value of wl_notificationtimestamp
Tobias [Sat, 30 Jan 2010 22:00:34 +0000 (22:00 +0000)]
fixing r61124: typos
Jack Phoenix [Sat, 30 Jan 2010 20:26:38 +0000 (20:26 +0000)]
MonoBook: remove three unused globals which were added in r56770 to support loading of IEFixes.js but IEFixes.js was merged into wikibits.js in r60994
Raimond Spekking [Sat, 30 Jan 2010 19:20:23 +0000 (19:20 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-01-30 19:00 UTC)
Alexandre Emsenhuber [Sat, 30 Jan 2010 17:40:17 +0000 (17:40 +0000)]
Per Nikerabbit, follow-up to r61690: document $interface parameter
Chad Horohoe [Sat, 30 Jan 2010 16:20:54 +0000 (16:20 +0000)]
Check $this not $wgUser in canSendEmail()
Victor Vasiliev [Sat, 30 Jan 2010 14:27:28 +0000 (14:27 +0000)]
Fix "you are blocked" message for users who were blocked by zero-ID user.
Conrad Irwin [Sat, 30 Jan 2010 12:46:16 +0000 (12:46 +0000)]
Fix for r61710. Changing subst: to subst:$1 would cause huge problems with localisation
instead add some proper functions to MagicWord.php to deal with the situation.
Roan Kattouw [Sat, 30 Jan 2010 12:09:28 +0000 (12:09 +0000)]
API: Fix E_NOTICE. !is_null() and isset() are not equivalent when indexing arrays
Roan Kattouw [Sat, 30 Jan 2010 12:07:40 +0000 (12:07 +0000)]
Bump $wgStyleVersion for r61700
Conrad Irwin [Sat, 30 Jan 2010 11:58:19 +0000 (11:58 +0000)]
bug 22297 - "syntax for substitution that doesn't break transclusion"
Adds "safesubst:$1" that works similarly to "subst:$1"
(relevant to bug 5453, bug 16714, bug 4484)
Aaron Schulz [Sat, 30 Jan 2010 09:10:03 +0000 (09:10 +0000)]
* Show diff link for DELETED_TEXT revs if user can see them (like history)
* Broke long line
Shinjiman [Sat, 30 Jan 2010 08:49:23 +0000 (08:49 +0000)]
Localisation updates Cantonese, Chinese and Literary Chinese
Chad Horohoe [Sat, 30 Jan 2010 01:28:58 +0000 (01:28 +0000)]
Followup r61694, expand comment based on [[Extension:Lockout]] and also deny login from session
Roan Kattouw [Fri, 29 Jan 2010 23:57:44 +0000 (23:57 +0000)]
Patch jQuery to test for 'nullpx' as well as 'NaNpx'
Chad Horohoe [Fri, 29 Jan 2010 23:52:06 +0000 (23:52 +0000)]
Followup r61655, add sys_get_temp_dir() support to wfTempDir(), use this in HttpTest rather than duplicating code
Chad Horohoe [Fri, 29 Jan 2010 23:29:53 +0000 (23:29 +0000)]
Add new global $wgBlockDisablesLogin to prevent logging in by blocked users, obsoletes new Lockout extension
Aryeh Gregor [Fri, 29 Jan 2010 21:44:01 +0000 (21:44 +0000)]
Refactor $wgEnforceHtmlIds code
Renamed setting to $wgExperimentalHtmlIds, off by default, and updated
the code to enforce the much laxer HTML5 rules. Still needs testing in
various browsers.
Alexandre Emsenhuber [Fri, 29 Jan 2010 21:32:45 +0000 (21:32 +0000)]
Step two in fixing OutputPage's documentation, more or less the same as r61647
Aryeh Gregor [Fri, 29 Jan 2010 20:48:41 +0000 (20:48 +0000)]
Fix whitespace in chick/main.css
Pointed out by Nikerabbit.
Rotem Liss [Fri, 29 Jan 2010 20:21:55 +0000 (20:21 +0000)]
Localization update for he.
Rotem Liss [Fri, 29 Jan 2010 20:19:36 +0000 (20:19 +0000)]
Reverting an apparent error in r61681, about treating the English file as a regular language file (thus removing ignored messages and reverting some changes).
Aryeh Gregor [Fri, 29 Jan 2010 20:13:55 +0000 (20:13 +0000)]
Set background: white for Chick
It was setting only color: black, so text was illegible if you had a
dark background set by default. We could remove the color: rule too,
but that might mess up other things that assume dark-on-light, and
doesn't match what other skins do. Reported by Dispenser on IRC.
Aryeh Gregor [Fri, 29 Jan 2010 20:13:37 +0000 (20:13 +0000)]
Use lowercase color names in CSS for consistency
Raimond Spekking [Fri, 29 Jan 2010 20:00:23 +0000 (20:00 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-01-29 19:00 UTC)
Mark A. Hershberger [Fri, 29 Jan 2010 19:18:41 +0000 (19:18 +0000)]
follow up r61655
Use Nikerabbit's much better wording for the error message.
Sam Reed [Fri, 29 Jan 2010 17:34:32 +0000 (17:34 +0000)]
Followup r61663 per Chads comment. Move $db declaration earlier, use $db->getType()
Remove now unused global
Alexandre Emsenhuber [Fri, 29 Jan 2010 17:27:30 +0000 (17:27 +0000)]
* (bug 22315) SpecialRecentChangesQuery hook now pass $query_options and checks the return value
Sam Reed [Fri, 29 Jan 2010 16:45:55 +0000 (16:45 +0000)]
Followup to 61664
Support LoginForm::UserBlocked in ApiLogin
Raimond Spekking [Fri, 29 Jan 2010 15:25:20 +0000 (15:25 +0000)]
* Add USER_BLOCKED case to UserLogin.
* Let Lockout extension use this case for a proper error message
Sam Reed [Fri, 29 Jan 2010 14:43:26 +0000 (14:43 +0000)]
Duplicate "definition" of $wgUser in same method
Move $wgDBtype later so only obtained if needed (ie we haven't died before then)
Sam Reed [Fri, 29 Jan 2010 14:38:57 +0000 (14:38 +0000)]
Reduce code duplication by having tables added in all code paths, by adding before if
Raimond Spekking [Fri, 29 Jan 2010 13:39:06 +0000 (13:39 +0000)]
* (bug 22181) Do not truncate if the ellipsis actually make the string longer
Chad Horohoe [Fri, 29 Jan 2010 11:50:58 +0000 (11:50 +0000)]
Remove trailing ?>
Mark A. Hershberger [Fri, 29 Jan 2010 08:13:23 +0000 (08:13 +0000)]
follow up r61319
took out the ".." but otherwise left it the same. On my system, this
installs an SQLite file in $IP/config/data by default using the web
installer. Setting it to "$IP/../data" presents the user with the
/full/path/to/the/MW/../data which seemed more confusing to me.
Mark A. Hershberger [Fri, 29 Jan 2010 07:25:09 +0000 (07:25 +0000)]
follow up r61357
* fix up fopen warnings — I was bedazzled by phpUnit's
set_error_handler that turned warnings into exceptions and Tim set
me right.
* Use Tim's read loop
* No need for private $fh member
* Fix some minor problems with PHP versions (no "timeout" param in
pre-5.2.1, POST issue in Hardy's PHP version where timeout is null.)
* Fix how tests are run on old versions of phpUnit.
Tim Starling [Fri, 29 Jan 2010 04:29:26 +0000 (04:29 +0000)]
Fix for r61582: if $wgDebugPrintHttpHeaders is false, don't construct the header string and then throw it away, skip the whole code block and save a few microseconds.
Chad Horohoe [Fri, 29 Jan 2010 02:37:51 +0000 (02:37 +0000)]
(bug 22310) Only need to declare $join_conds once
Tim Starling [Fri, 29 Jan 2010 00:51:08 +0000 (00:51 +0000)]
Fix careless errors in r61442 and r61444.
Aryeh Gregor [Fri, 29 Jan 2010 00:02:57 +0000 (00:02 +0000)]
stylize.php and fix whitespace for JSMin.php
Two spaces were being used for indentation instead of a tab, and for
some reason stylize.php didn't fix that, but repeated
s/^\(\( \)*\) /\1\t/ worked.
Alexandre Emsenhuber [Thu, 28 Jan 2010 21:58:50 +0000 (21:58 +0000)]
Step one in fixing OutputPage's documentation:
* Groupped methods by function
* Added documentation
* Fixed some doxygen warnings
* Some little style fixes
(more to come)
Raimond Spekking [Thu, 28 Jan 2010 21:54:45 +0000 (21:54 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-01-27 21:30 UTC)
Chad Horohoe [Thu, 28 Jan 2010 19:46:12 +0000 (19:46 +0000)]
Followup r61181, put @return nothing back on history(). Some people like it.
Jure Kajzer [Thu, 28 Jan 2010 14:58:45 +0000 (14:58 +0000)]
Fixed as per Tim's comments on r61179:
* made insertOneRow and getSequenceData private
* renamed fieldInfo to fieldInfoMulti and made it private (for internal use on Oracle only)
* wrapped fieldInfoMulti in fieldInfo with error if $table parameter is an array
* reverted tableName function to only support a non-array parameter
* wrapped all tableName calls with array parameter with array_map with callback
* wrapped fieldInfo into textFieldSize function to avoid reimplementation of functionality
* fixed unnessesary multiple calls to tableName with same parameter inside a single procedure
Roan Kattouw [Thu, 28 Jan 2010 12:46:50 +0000 (12:46 +0000)]
(bug 22286) Unicode 5.1 aliases for Malayam. This was done in the Wikimedia config at first, moving it into the trunk messages file per Siebrand
Aaron Schulz [Thu, 28 Jan 2010 08:57:34 +0000 (08:57 +0000)]
* Fixed $opts['tagfilter'] emptiness check
* Doc cleanup/spacing
Sam Reed [Thu, 28 Jan 2010 07:15:49 +0000 (07:15 +0000)]
Minor followup to r61609
If we're checking the key is *, no point reusing it, as we know what it is. Simplfy bug link/reference
OverlordQ [Thu, 28 Jan 2010 06:41:38 +0000 (06:41 +0000)]
Fix documentation errors (r61324)
Sam Reed [Wed, 27 Jan 2010 22:02:49 +0000 (22:02 +0000)]
* (bug 21922) YAML output should quote asterisk when used as key
Raimond Spekking [Wed, 27 Jan 2010 19:19:12 +0000 (19:19 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-01-27 19:00 UTC)
Chad Horohoe [Wed, 27 Jan 2010 19:14:18 +0000 (19:14 +0000)]
Use isset() instead of array_key_exists()
Jack D. Pond [Wed, 27 Jan 2010 19:08:31 +0000 (19:08 +0000)]
$mDesiredDestName property changed from protected to public. Used in extensions to check/validate/process user destination names in uploads.
Aryeh Gregor [Wed, 27 Jan 2010 18:59:52 +0000 (18:59 +0000)]
Use Html::element() for Xml::submitButton()
There are a bunch of other places where we could switch to Html methods
here too. See
<http://www.mediawiki.org/wiki/Special:Code/MediaWiki/61130#c5451>.
Niklas Laxström [Wed, 27 Jan 2010 17:21:18 +0000 (17:21 +0000)]
New configuration variables $wgDebugTimestamps and $wgDebugPrintHttpHeaders for controlling debug output.
I find these useful, maybe someone else will too.
Chad Horohoe [Wed, 27 Jan 2010 17:02:48 +0000 (17:02 +0000)]
Let crazy people run updates on broken setups like 5.3.1
Platonides [Wed, 27 Jan 2010 14:39:03 +0000 (14:39 +0000)]
Revert r61572. These titles are output parameters. A reference is the only way they can work correctly
(eg. think on a hook that always does 'return $titleResult = Title::newFromText("Foo");').
Platonides [Wed, 27 Jan 2010 11:52:35 +0000 (11:52 +0000)]
Apply r61570 (Follow-up r61150: Do not pass objects as references in new hooks).
This time in the correct place.
Tim Starling [Wed, 27 Jan 2010 09:50:19 +0000 (09:50 +0000)]
No jquery.ui for now.
Mark A. Hershberger [Wed, 27 Jan 2010 07:00:07 +0000 (07:00 +0000)]
Parser tests now working under phpunit
Mark A. Hershberger [Wed, 27 Jan 2010 06:58:15 +0000 (06:58 +0000)]
Break up tests so problems are easier to track down.
Mark A. Hershberger [Wed, 27 Jan 2010 06:51:42 +0000 (06:51 +0000)]
Make the instantiation tests actually work.
Tim Starling [Wed, 27 Jan 2010 05:17:26 +0000 (05:17 +0000)]
* Removed JS2 stuff from jquery.js. If there's anything we really need from it, it can be re-added to wikibits.js, but that can wait for the extension analysis which I'm going to do next.
* Added Ryan Grove's jsmin.php and wrote a maintenance script wrapper called minify.php
* Added a makefile to rebuild skins/common
* Rebuilt jquery.min.js
Tim Starling [Wed, 27 Jan 2010 04:17:49 +0000 (04:17 +0000)]
* Moved js2stopgap.js to skins/common/jquery.js, like I said I was going to do months ago.
* Add a $modules parameter to OutputPage::includeJQuery() so that we can include jquery.ui in the main UsabilityInitiative jQuery request in a reasonably flexible way, if we need to.
* Removed $wgExtensionJavascriptLoader, added in r61137 without explanation, seems to be the usual misspelt JS2/mwEmbed rubbish that I keep deleting.
Tim Starling [Wed, 27 Jan 2010 03:19:30 +0000 (03:19 +0000)]
Removed the nasty-looking JS-based position:fixed simulation, used by the "standard" (MW 1.0) skin for non-default "floating" quickbar settings in IE 6 and below. Appears to be broken anyway and nobody cares enough to fix it. To resolve r61071.
Conrad Irwin [Wed, 27 Jan 2010 03:06:56 +0000 (03:06 +0000)]
(bug 19600) don't display searchmenu-new when user has not got permission to
create the page.
Tim Starling [Wed, 27 Jan 2010 02:41:22 +0000 (02:41 +0000)]
Revert r61528, r61527, r61526, r61525, r61519, r61515, r61053, r61052 (Parser::doQuotes() rewrite). Lots of issues to discuss, needs more review than I have time to give it pre-1.16. I'll split it out to a branch.
Chad Horohoe [Wed, 27 Jan 2010 00:11:13 +0000 (00:11 +0000)]
Fix isSyndicated() description too
Chad Horohoe [Wed, 27 Jan 2010 00:09:25 +0000 (00:09 +0000)]
Make isSyndicated() return a boolean like its name, documentation and callers suggest it should