umherirrender [Sat, 23 Nov 2013 17:54:17 +0000 (18:54 +0100)]
Move functions to better place in Special:Search
The function direct behind the variable definition is not the prefer
place.
Change-Id: I9183e1f1af22644a4f811657fbf2245a11b48854
Brian Wolff [Sun, 15 Dec 2013 20:33:32 +0000 (20:33 +0000)]
Merge "Fixed spacing"
umherirrender [Sun, 15 Dec 2013 19:56:09 +0000 (20:56 +0100)]
Fixed spacing
- Removed double spaces in arrays
- Added space after for
- Added spaces around string concat
Change-Id: Ifbcaf35f9bfef1f97226a38b5bd74c237f61c99e
Bartosz Dziewoński [Sun, 8 Dec 2013 18:52:51 +0000 (19:52 +0100)]
SpecialUndelete: Use DifferenceEngine#addHeader instead of rolling our own
Change-Id: I4ea57e60aaf3112622d893ecd8b81f4e65e5806d
saper [Sat, 7 Dec 2013 15:40:58 +0000 (16:40 +0100)]
Insert test page into DB not to violate constraint
Page with id 0 does not exist at the time transaction
is committed to the database.
Unit tests with table constraints enabled
fail with:
1) RevisionStorageTest::testUserWasLastToEdit with data set #0 (3, true)
DBQueryError: A database error has occurred. Did you forget to run
maintenance/update.php after upgrading? See:
https://www.mediawiki.org/wiki/Manual:Upgrading#Run_the_update_script
Query: INSERT INTO "unittest_revision"
(rev_id,rev_page,rev_text_id /* more fields */ )
VALUES ('461','0','460' /* more fields */
Function: Revision::insertOn
Error: 23503 ERROR: insert or update on table "unittest_revision"
violates foreign key constraint "ut_revision_rev_page_fkey"
DETAIL: Key (rev_page)=(0) is not present in table "unittest_page".
/usr/home/saper/test/mytest/includes/db/Database.php:1111
/usr/home/saper/test/mytest/includes/db/DatabasePostgres.php:511
/usr/home/saper/test/mytest/includes/db/Database.php:1077
/usr/home/saper/test/mytest/includes/db/DatabasePostgres.php:871
/usr/home/saper/test/mytest/includes/Revision.php:1422
/usr/home/saper/test/mytest/tests/phpunit/includes/RevisionStorageTest.php:488
/usr/home/saper/test/mytest/tests/phpunit/MediaWikiTestCase.php:123
/usr/home/saper/test/mytest/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/usr/home/saper/test/mytest/tests/phpunit/MediaWikiPHPUnitCommand.php:64
/usr/home/saper/test/mytest/tests/phpunit/phpunit.php:115
Change-Id: I653a8bccdaa748a9bea453cd1dbf609a30e1ff6f
Mark A. Hershberger [Tue, 10 Dec 2013 13:33:04 +0000 (08:33 -0500)]
Attempt to fix problems noted in phpcs.
Seen at https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-strict-HEAD/4724/console
Change-Id: I1bcec887849f726cf0015a3a3a44bfc1f797658c
Mark A. Hershberger [Tue, 10 Dec 2013 13:00:49 +0000 (08:00 -0500)]
Attempt to fix problems noted in phpcs.
Seen at
https://integration.wikimedia.org/ci/job/mediawiki-core-regression-phpcs-HEAD/3256/console
Change-Id: If1272366fa242ccdf1191ba1686f2d1cdf046872
Tim Starling [Fri, 15 Nov 2013 03:44:06 +0000 (14:44 +1100)]
Improve redis connection error log
Include the server name in the log entry for exceptions thrown during
connect. We are logging a lot of these.
Change-Id: Ia3f775a9e22447efb067c3203a3b80c4385aa2c0
Kevin Israel [Sat, 7 Dec 2013 20:08:47 +0000 (15:08 -0500)]
Abstract out mysql_field_type() call from DatabaseBase
DatabaseMysqlBase::fieldType() is used in the maintenance script
convertLinks.php for upgrading from MediaWiki 1.2 or earlier. This
script was failing when the mysqli extension was enabled.
Follows-up
b1cc3511fd7a,
b2d64432ee02, and
00299ecb9515.
Change-Id: I5d888f4dd344ecba15506023d35f6d2d6e24cfd8
Kevin Israel [Sat, 7 Dec 2013 20:29:20 +0000 (15:29 -0500)]
Add new_name_timestamp index when upgrading from 1.1
This index is specified in some FORCE INDEX clauses, so it has to be
present. Patch already exists; the installer just wasn't using it.
There still are some other schema inconsistencies I have to track
down, so I'm not yet adding a release note that upgrading from 1.1
has been "fixed".
Change-Id: Ibd593d3f5b63f4cb033c6c9dabaac398bb1afd19
Alexandre Emsenhuber [Sun, 15 Dec 2013 14:21:11 +0000 (15:21 +0100)]
Remove unused variable $user from SkinTemplate::outputPage()
Change-Id: I566e835f8362671a08f9a2c34b6124f462fdb463
Kunal Mehta [Thu, 12 Dec 2013 20:59:40 +0000 (12:59 -0800)]
Add missing directories to findHooks.php
Change-Id: I60ead68fbed90ee6d94ee6d7d783f69bf1aaa9f8
jenkins-bot [Sun, 15 Dec 2013 12:15:03 +0000 (12:15 +0000)]
Merge "Clean some phpcs errors in Preferences.php"
Max Semenik [Thu, 12 Dec 2013 00:46:22 +0000 (04:46 +0400)]
Set default for nickname preference
Not having a default results in
1361430 pointless rows with
empty up_value in user_properties on enwiki only.
Part of work on bug 52777.
Change-Id: I63db3a813fbf11fd3d9a0f0535facc39d975c563
Amir E. Aharoni [Sun, 15 Dec 2013 07:20:11 +0000 (09:20 +0200)]
Clean some phpcs errors in Preferences.php
Change-Id: I315e562c5f85e464a8ca61be6a47e2a468156a55
Translation updater bot [Sat, 14 Dec 2013 20:42:14 +0000 (20:42 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: I81f2c786041718b678dbd9fba411e24d0c4d4cf7
umherirrender [Sat, 30 Nov 2013 00:57:58 +0000 (01:57 +0100)]
UserArray: Avoid * and double keys in select
Use User::selectFields to get all fields instead of *,
also use array_unqiue to make the sql nicer by having only single value
in the IN statement.
Change-Id: I0a4888be20f84f2955e82ced621aed526cc83f20
Vitaliy Filippov [Tue, 8 Oct 2013 11:15:03 +0000 (15:15 +0400)]
(bug 40889) Follow-up
6f1d4db3: Fix the upload form when radio buttons are shown.
The previous change had broken the upload form if URL uploads or
some other possible upload source types are enabled - i.e. in
the case when there are radio buttons. The "incorrect" label ID
was used by radiobutton.
Change-Id: I7c15fd4250b6a2d26af2cc0373da5ac6c884d690
Siebrand Mazeland [Tue, 3 Dec 2013 21:48:40 +0000 (22:48 +0100)]
Replace deprecated notifyRC2UDP() with notifyRCFeeds().
Change-Id: I54f6ce861ee0ecc6121df76e52ca3de16dd141fa
Brian Wolff [Sat, 14 Dec 2013 02:16:35 +0000 (19:16 -0700)]
Use canonical casing for Xml::option (no code changes)
Per Umherirrender.
Change-Id: I520d71cc9969fe823122565faea9e725f96972f4
Follow-up:
d0c0bad56d8ff3fe
Brian Wolff [Sat, 14 Dec 2013 06:44:09 +0000 (06:44 +0000)]
Merge "Removed excess title validity check"
Siebrand Mazeland [Thu, 5 Dec 2013 19:40:38 +0000 (20:40 +0100)]
Make visibleMetadataField protected
Related patch sets:
* https://gerrit.wikimedia.org/r/#/c/99429/ Extension PagedTiffHandler
Change-Id: I0441fdf1ce1e06688f16c62e1993bb05911b45bc
umherirrender [Fri, 6 Dec 2013 21:36:26 +0000 (22:36 +0100)]
Only show 'Show extended details' for file metadata having extra rows
When a file only has default visible metadata, there is no need
to allow extending the optional metadata, because there are none.
Also added comments in ImagePage.php and shared.css because this
system is scattered all over and each piece seems disconnected
(the shared.css block was incorrectly documented as only being
used to initially hide rows, wheareas in practice that never
happens and instead the collapsed state is toggled on click).
Change-Id: I595fed425135c1e8dd341258633217428bcb4154
This, that and the other [Sat, 21 Sep 2013 09:28:57 +0000 (19:28 +1000)]
Fix outdated comment in DefaultSettings
wgCopyUploadTimeout is used now.
Follow up to Ia85a97434c14adcdaafc0802cbe0530bfa57a435
Change-Id: I9838f3f13274f4276b6a51a50afdc64fa34554e2
jenkins-bot [Sat, 14 Dec 2013 02:36:42 +0000 (02:36 +0000)]
Merge "Document the wikipage.content hook"
Matthew Flaschen [Thu, 14 Nov 2013 08:05:29 +0000 (03:05 -0500)]
Document the wikipage.content hook
There is some text in the mw.hook documentation section, but that's
really intended to document mw.hook.
Change-Id: I2afb74a1124123220b26b50b3df64dd7bae80208
Brian Wolff [Fri, 6 Dec 2013 19:34:49 +0000 (15:34 -0400)]
Add method to get entire text layer. This could be useful for search
Change-Id: I22f5fc47aef3cf362cdf630980deea48fe531d45
jenkins-bot [Fri, 13 Dec 2013 20:51:14 +0000 (20:51 +0000)]
Merge "startup.js: log current time as global 'mediaWikiLoadStart'"
jenkins-bot [Fri, 13 Dec 2013 20:42:56 +0000 (20:42 +0000)]
Merge "Blacklist Google Glass web browser from JS"
jenkins-bot [Fri, 13 Dec 2013 20:19:34 +0000 (20:19 +0000)]
Merge "Fix WikiPage::prepareContentForEdit's default format handling"
Translation updater bot [Fri, 13 Dec 2013 20:17:19 +0000 (20:17 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Brad Jorsch [Fri, 13 Dec 2013 17:15:39 +0000 (12:15 -0500)]
Fix WikiPage::prepareContentForEdit's default format handling
If some caller passes null for the $serialization_format parameter,
they're going to break the in-memory caching of the prepared edit even
though it's likely that the format being used is the same as the format
being used by everything else.
It seems sensible to cache null as the default format for the content
object to avoid this.
Bug: 57026
Change-Id: I4ddcf6e388636e6a6397b664b8683ad774a09a04
Translation updater bot [Fri, 13 Dec 2013 19:58:40 +0000 (19:58 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: Idd97bcf1748297b4633435fd73530d7bc14e2707
Bryan Davis [Fri, 13 Dec 2013 19:49:45 +0000 (12:49 -0700)]
Fix TempFSFile creation
A new TempFSFile should be instantiated via the factory rather than
using the object constructor.
Change-Id: Icd059566087c6a644a0d0ed69abfe13b88b38ee4
jenkins-bot [Fri, 13 Dec 2013 19:03:56 +0000 (19:03 +0000)]
Merge "Fix TextContent::preSaveTransform() return type"
jenkins-bot [Fri, 13 Dec 2013 18:50:02 +0000 (18:50 +0000)]
Merge "Use TempFSFile in UploadFromUrl"
Brad Jorsch [Fri, 13 Dec 2013 17:51:47 +0000 (12:51 -0500)]
Fix TextContent::preSaveTransform() return type
TextContent::preSaveTransform should return an object of the same class
as $this, not a WikitextContent.
Apparently this was never noticed because most code paths rtrim the
input and TextContent::preSaveTransform returns $this if the rtrim is a
no-op on the input.
Bug: 58451
Change-Id: I9f8f78d52448d1ba055a654a12ff4fad86756110
jenkins-bot [Fri, 13 Dec 2013 18:17:30 +0000 (18:17 +0000)]
Merge "Fix error handling in File::createThumb."
jenkins-bot [Fri, 13 Dec 2013 15:51:15 +0000 (15:51 +0000)]
Merge "Made RepoGroup use ProcessCacheLRU"
Brian Wolff [Fri, 13 Dec 2013 08:54:20 +0000 (01:54 -0700)]
Fix error handling in File::createThumb.
Was checking for null, but transform always returns either
false or an object.
createThumb isn't used in core, but some extensions use it.
Bug: 58436
Change-Id: Icaf5088a193dc1d9b9c365f92722bef1f9c1dba6
Timo Tijhof [Fri, 13 Dec 2013 01:28:50 +0000 (02:28 +0100)]
Update oojs to v1.0.6
Code:
http://krinkle.github.io/oojs/releases/oojs-1.0.6.js
Release notes:
https://github.com/wikimedia/oojs/blob/v1.0.6/History.md
Change-Id: I75e814385f697d92fdd1d22b3a0dbec3e0fe397e
jenkins-bot [Fri, 13 Dec 2013 00:34:50 +0000 (00:34 +0000)]
Merge "mediawiki.mixins: Remove -o and -moz vendor prefixes for transition"
Aaron Schulz [Tue, 10 Dec 2013 22:29:06 +0000 (14:29 -0800)]
Update FSRepo to avoid the deprecated FileBackend construction style
Change-Id: Iaa8d57e22750582eb95e4abab7444ff291807416
Bryan Davis [Thu, 12 Dec 2013 23:10:14 +0000 (16:10 -0700)]
Use TempFSFile in UploadFromUrl
Make it a little harder for the developer to leak files in the temp
directory by managing the temporary file with a TempFSFile instance.
Change-Id: I8bafc3a6e6212781d9e2e4f8f370ce7c446f1fd5
jenkins-bot [Thu, 12 Dec 2013 22:08:35 +0000 (22:08 +0000)]
Merge "Removed stray ! in isQueueDeprioritized()"
Aaron Schulz [Thu, 12 Dec 2013 21:57:00 +0000 (13:57 -0800)]
Removed stray ! in isQueueDeprioritized()
Change-Id: I7a4b7f6205350dd61cb37a6cd9b57d40cd74e6c8
Translation updater bot [Thu, 12 Dec 2013 21:16:33 +0000 (21:16 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: I256c74a670f5576e22e7ee6c9d3eefdade64c788
Brian Wolff [Thu, 12 Dec 2013 18:51:57 +0000 (18:51 +0000)]
Merge "Avoid calling protected File field"
Bartosz Dziewoński [Sun, 8 Dec 2013 14:39:25 +0000 (15:39 +0100)]
SpecialWantedcategories: Show more current information when in cached mode
Usability improvements I thought up when trying to through nearly
500 entries on this page on pl.wp.
* Strike items on the list if the category was created or emptied
since the last update
* Show current number of items if it's different from the original one
Change-Id: Ifcc534f19fb60732bcd40f75ddca390106ebe28e
Aaron Schulz [Wed, 11 Dec 2013 19:16:41 +0000 (11:16 -0800)]
Avoid calling protected File field
bug: 58333
Change-Id: I0bd4a5fe9687c4261ca0f57e30f723e8bf2589ac
Brad Jorsch [Thu, 12 Dec 2013 15:01:33 +0000 (10:01 -0500)]
Add ApiBeforeMain hook
$wgExtensionFunctions is called before the RequestContext is really
available (i.e. getTitle() is null, accessing the User object may fail
because other extensions' UserLoadFromSession hooks don't expect to be
called that early, etc). The index.php code path has BeforeInitialize to
take action after RequestContext is available but before much else
happens, but the API doesn't (yet) have anything similar.
Bug: 58380
Change-Id: I0a167faaa4166da381194c53373d82e038848924
jenkins-bot [Thu, 12 Dec 2013 09:49:38 +0000 (09:49 +0000)]
Merge "Make (Title|User)Array implements Countable"
Niklas Laxström [Thu, 12 Dec 2013 09:19:19 +0000 (09:19 +0000)]
Make (Title|User)Array implements Countable
count( $results ) always returned 1, now expected number
Bug: 58377
Change-Id: I7d6b3bc1b09b46fe60cb5a74c25f9b28fffa5b73
jenkins-bot [Thu, 12 Dec 2013 09:17:43 +0000 (09:17 +0000)]
Merge "Always give sane output for Title::getUserCaseDBkey()"
jenkins-bot [Thu, 12 Dec 2013 05:01:14 +0000 (05:01 +0000)]
Merge "mediawiki.js: Minor clean up of comments and code"
Timo Tijhof [Thu, 5 Dec 2013 23:24:13 +0000 (00:24 +0100)]
mediawiki.js: Minor clean up of comments and code
* Put ternary on one line or separated over 3 lines.
* Whitepace inside parentheses (e.g. catch statement).
* Avoid trailing line comments.
* Capitalise description of parameters for consistency and to
have it better stand apart from the variable name.
* Phrase primary method block description as a single line
in the imperative mood.
* Avoid shortened urls inside documentation.
(updated Modernizr ref to a release instead of git hash).
* Using store.enabled as boolean (null being falsey).
* Merge subsequent if-statements having the same logical purpose
and body.
Change-Id: Ia1db9e54d528b2799187d80d2e3e22e31f74fb6b
Bartosz Dziewoński [Sun, 17 Nov 2013 15:02:29 +0000 (16:02 +0100)]
IcuCollation: Add CollationCkb subclass for Sorani Kurdish
ICU does not currently support Sorani Kurdish / Central Kurdish
language ('ckb'). CollationCkb uses the same collation rules as
Persian / Farsi ('fa'), but different characters for digits.
For use at ckb.wikipedia, which currently has 'uca-fa' collation
deployed as a workaround.
Added the MW language used for transforming digits to cache key for
first-letters data, in addition to the ICU locale.
Bug: 55630
Change-Id: I7d7f007592ede952859c5c9556b9ea5084b90e89
Bartosz Dziewoński [Sat, 12 Oct 2013 22:21:01 +0000 (00:21 +0200)]
IcuCollation: Sort digits under localised digits' headings
Previously both '1' and '۱' ("DIGIT ONE" and "EXTENDED ARABIC-INDIC
DIGIT ONE") were sorted under '1' heading, regardless of collation
locale.
Now they will be both sorted under localised heading name (transformed
using Language#formatNum), for example '1' for 'uca-en' collation or
'۱' for 'uca-fa' collation.
Bug: 55630
Change-Id: I0b745d955a6e72f53873c95648087aa5f90a8852
jenkins-bot [Thu, 12 Dec 2013 03:21:13 +0000 (03:21 +0000)]
Merge "Fix QueryPage transaction plan"
Yuri Astrakhan [Thu, 12 Dec 2013 01:58:19 +0000 (20:58 -0500)]
Better warning for Message object
Trying to track down the source of the production warnings
Change-Id: Iba666af3e84651fde338764d0f9d47a38b6b54e9
Juliusz Gonera [Fri, 6 Dec 2013 23:36:15 +0000 (15:36 -0800)]
mediawiki.mixins: Remove -o and -moz vendor prefixes for transition
-moz is needed for Firefox <= 15.0, -o is needed for Opera <= 12.0 [1].
Usage of those browsers is negligible [2].
[1] http://caniuse.com/css-transitions
[2] http://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm
Change-Id: I43bcf1efacb87ab61b78140fe85bd846d791b54a
Brian Wolff [Wed, 11 Dec 2013 23:06:57 +0000 (16:06 -0700)]
Always give sane output for Title::getUserCaseDBkey()
Sometimes (e.g. via Title::makeTitle), the usercase db key is
not set. If that happens we should fallback to the normal db key.
This fixes file redirects on repos where initialCapital is set
to false.
Change-Id: I38bc4ebeb41b06f5c718cf5f64da158e6c1a9f49
jenkins-bot [Wed, 11 Dec 2013 22:23:51 +0000 (22:23 +0000)]
Merge "CSSMin: Correctly format 'url()' values with parentheses etc."
jenkins-bot [Wed, 11 Dec 2013 22:18:11 +0000 (22:18 +0000)]
Merge "CSSMin: Change behavior for missing files"
jenkins-bot [Wed, 11 Dec 2013 22:11:31 +0000 (22:11 +0000)]
Merge "CSSMin: Fix remapOne() for URLs that are proto-relative or have query part"
Bartosz Dziewoński [Wed, 11 Dec 2013 21:00:29 +0000 (22:00 +0100)]
CSSMin: Correctly format 'url()' values with parentheses etc.
Introduce new static function, CSSMin::buildUrlValue.
Actually using such values in CSS does not work well because the
URL_REGEX is nowhere near good enough. :(
Change-Id: I04a7078dd0087bcb461fa5e5168c870d37c255f4
Translation updater bot [Wed, 11 Dec 2013 20:32:41 +0000 (20:32 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Bartosz Dziewoński [Wed, 11 Dec 2013 20:21:36 +0000 (21:21 +0100)]
CSSMin: Change behavior for missing files
We would previously return the path to the local file on the
filesystem, which is useless in all cases and possibly a security
issue in some. Now we return the URL at which the file would be
accessible had it existed.
Also reordered the code around that part to make the control flow
clearer and added a test.
Change-Id: I1d5befb2ea385ae4d316c5d8c5d1fc092b64c4ff
Translation updater bot [Wed, 11 Dec 2013 20:17:32 +0000 (20:17 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: I105dee236f2f05f91d0ffc4ae931c3012b48d938
Bartosz Dziewoński [Wed, 11 Dec 2013 19:11:44 +0000 (20:11 +0100)]
CSSMin: Fix remapOne() for URLs that are proto-relative or have query part
Bug: 58338
Change-Id: I836a2c054ae3edc07895b2388f4ec8663223347a
Aaron Schulz [Mon, 9 Dec 2013 20:24:32 +0000 (12:24 -0800)]
Changed TIME_ONLY to NAME_AND_TIME_ONLY in FileRepo
* This now returns a (final DB key, timestamp) map for each file.
This makes proper redirect handling easier for callers.
* Also fixed the case where ucfirst normalization is different in the
repo versus the local wiki.
* Also added $flags to RepoGroup::findFiles() as expected.
Change-Id: I978a1cc0a0589179c46e477cfd06c8bff4c08fa9
Brion Vibber [Wed, 11 Dec 2013 19:11:08 +0000 (11:11 -0800)]
Blacklist Google Glass web browser from JS
This will prevent things like collapsing sections on the Google Glass
web browser, and other interactive extras that really don't work well
on the limited UI (although the browser supports JS the interaction
model doesn't let you do much usefully, so a static page is better).
bug: 56008
Change-Id: I406d8131d4a8b3b98328e6c624433b67a18db645
jenkins-bot [Wed, 11 Dec 2013 19:13:53 +0000 (19:13 +0000)]
Merge "Allow customizing classes inside of diffs"
Max Semenik [Tue, 10 Dec 2013 23:58:51 +0000 (03:58 +0400)]
Allow customizing classes inside of diffs
Not every implementation might want them
Change-Id: Id186b71760d59be7e61458bf1f62965a0f2f826c
Aaron Schulz [Fri, 6 Dec 2013 21:31:35 +0000 (13:31 -0800)]
Tweaked FileRepo::findFiles() behavoir to match LocalRepo
* This seems more intuitive and deals with an API bug
bug: 45930
Change-Id: I5e265bb9c6063306669cc4014eeb17cfda86436b
raymond [Wed, 11 Dec 2013 16:57:02 +0000 (17:57 +0100)]
Add new message key to maintenace/messages.inc
Followup to Ica447a3b6f08422fd3c7452a5bd87d509dad9870
Change-Id: Ifed3c19dc1733c6454358f82ccd68dfd1f6c1e9a
jenkins-bot [Wed, 11 Dec 2013 15:42:19 +0000 (15:42 +0000)]
Merge "Preferences: Improve accessibility of the JS tabs of Preferences"
jenkins-bot [Wed, 11 Dec 2013 01:30:53 +0000 (01:30 +0000)]
Merge "Send QueryPage recache queries to a separate query group"
Ori.livneh [Wed, 11 Dec 2013 00:59:19 +0000 (00:59 +0000)]
Revert "Module storage: randomly choose between Function and $.globalEval"
Did not get a chance to deploy this.
This reverts commit
a20333cc4da04775db04b33407c88b4ccb5e5e74.
Change-Id: I6937d54897477f1942a8a9c312324a39d2a3868d
Tim Starling [Wed, 11 Dec 2013 00:57:00 +0000 (11:57 +1100)]
Fix QueryPage transaction plan
The COMMIT in updateSpecialPages.php was unmatched and just logged an
error. We would like the stale results to still be presented to the user
during the hours of query execution time, so doing a DELETE in
autocommit mode before the main query starts does not seem appropriate.
And holding a master transaction open for hours, with a lock on
querycache, is certainly not the right way to do it.
So, move the DELETE to after the completion of the main query, and wrap
a transaction around the updates to querycache and querycache_info so
that the user always sees a consistent populated UI. Remove the
unmatched COMMIT from updateSpecialPages.php.
Change-Id: I27c22b96f43a1064eb17a0c6a1c56d1f4a2dff9a
Tim Starling [Wed, 11 Dec 2013 00:48:47 +0000 (11:48 +1100)]
Send QueryPage recache queries to a separate query group
This essential feature was broken 3 years ago, in r78786. The group
connection was being used only for a call to the archaic
Database::fetchObject().
Change-Id: Ia4c76c88ecc77eb663a535b0625a1509882a35c7
jenkins-bot [Wed, 11 Dec 2013 00:34:40 +0000 (00:34 +0000)]
Merge "Added --wikidb param to sql.php"
jenkins-bot [Wed, 11 Dec 2013 00:32:55 +0000 (00:32 +0000)]
Merge "Module storage: randomly choose between Function and $.globalEval"
Aaron Schulz [Tue, 10 Dec 2013 23:03:41 +0000 (15:03 -0800)]
Added --wikidb param to sql.php
* This is useful for updating DBs that are not actually a that of a wiki.
For example a global blocking or central auth DB may not correspond to
any single wiki. Trying to use --wiki will fail with het deploy
Change-Id: I232182b79c9ca6421789f19771ba427498fff713
jenkins-bot [Tue, 10 Dec 2013 22:55:14 +0000 (22:55 +0000)]
Merge "Add "nocreate" and "createonly" options to edit.php"
jenkins-bot [Tue, 10 Dec 2013 22:26:49 +0000 (22:26 +0000)]
Merge "tests: beginning of tests for DjVu files"
Kunal Mehta [Tue, 10 Dec 2013 22:13:53 +0000 (14:13 -0800)]
Add "nocreate" and "createonly" options to edit.php
Change-Id: I2101360a934b8b9a92094c44429e3e2314c7fba3
Tpt [Sat, 30 Nov 2013 09:41:26 +0000 (10:41 +0100)]
tests: beginning of tests for DjVu files
Change-Id: I453b2b1a1c4999150a570e22170a9c630c2ef265
jenkins-bot [Tue, 10 Dec 2013 22:09:21 +0000 (22:09 +0000)]
Merge "filebackend: cleaned up the FileBackend constructor"
jenkins-bot [Tue, 10 Dec 2013 21:08:30 +0000 (21:08 +0000)]
Merge "API: Add iiprop=canonicaltitle"
Translation updater bot [Tue, 10 Dec 2013 20:51:02 +0000 (20:51 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Tue, 10 Dec 2013 20:50:37 +0000 (20:50 +0000)]
Merge "Deleting a page and then immediately create-protecting it caused a PHP Fatal error"
Translation updater bot [Tue, 10 Dec 2013 20:48:26 +0000 (20:48 +0000)]
Localisation updates from https://translatewiki.net.
Change-Id: I78257c1482d2a8a5a36693082c3228a63d0f4b8f
jenkins-bot [Tue, 10 Dec 2013 20:30:15 +0000 (20:30 +0000)]
Merge "Remove problem forced index"
jenkins-bot [Tue, 10 Dec 2013 20:14:04 +0000 (20:14 +0000)]
Merge "identify LogPager queries for load balancing"
Derk-Jan Hartman [Sun, 11 Aug 2013 07:11:40 +0000 (09:11 +0200)]
Preferences: Improve accessibility of the JS tabs of Preferences
This enables keyboard accessibility of the tabs, by only allowing
focus on one tab element using tabindex=0 and tabindex=-1 for the
other tabs. Navigation between tabs is then handled by using the left
and right arrow keys. This is the advised methodology.
We also add tab, tabpanel and tablist roles to improve accessibility
for assistive technology, while overriding the implicit tablist role
of the li element with 'presentation' to make sure we don't have mixed
semantics of lists and tabs.
We keep track of:
aria-selected: If this tab is currently selected
aria-controls: Which tabpanel is controlled by this tab
aria-labelledby: Which tab is the label for this tabpanel
aria-hidden: If this tabpanel is (not) visible
Tested using VoiceOver. Should also work with JAWS 14.
Change-Id: Ica447a3b6f08422fd3c7452a5bd87d509dad9870
Bartosz Dziewoński [Fri, 8 Nov 2013 20:17:27 +0000 (21:17 +0100)]
Canonicalize text and update docs of messages using 'loginreqlink'
Since 'loginreqlink' is being used as a part of patchwork messages we
should try to keep the grammar the same in all of its uses.
"You have to log in" / "You must log in" / "Please log in" were all
used with various frequencies; I changed (hopefully) all uses to
"Please log in".
Two messages receiving 'loginreqlink' as a parameter do not currently
use it: 'changeemail-no-info' and 'resetpass-no-info'. This is
intentional, as they are less "positive" than the rest and thus should
not link to the login form.
Updated and cross-referenced qqq of 'loginreqlink' and messages using it.
Change-Id: Ie245486051d6fbc72a596ba825bfd5d9e3a163bf
Ori Livneh [Tue, 10 Dec 2013 06:35:37 +0000 (22:35 -0800)]
Module storage: randomly choose between Function and $.globalEval
V8 disables certain optimizations for eval()'d code because scope resolution is
tricky. The same is not true for code compiled via Function(), which always
runs in global scope. Let's see if Function() is faster.
This patch makes ResourceLoader randomly use either Function() or $.globalEval.
The choice is recorded in a boolean `useFunction` property on mw.loader.store
so its value can be logged with load timing measurements. The logging will be
done in WikimediaEvents.
Bug: 58259
Change-Id: I7183778cb65c421ee19dcd61ee1dc0085f86bf10
Sean Pringle [Tue, 10 Dec 2013 06:20:33 +0000 (16:20 +1000)]
Remove problem forced index
bug: 58256
Change-Id: I48484b39f99d92f51e531324870236b00b481553
Sean Pringle [Tue, 10 Dec 2013 05:04:14 +0000 (15:04 +1000)]
Remove problem forced index. Bug 57175.
Change-Id: I94e0a743ccad0bad9a3a0d4d52b23abc0ef405b2