From: umherirrender <umherirrender_de.wp@web.de>
Date: Sat, 22 Sep 2012 22:42:34 +0000 (+0200)
Subject: SiteStats: use field names in select instead of *
X-Git-Tag: 1.31.0-rc.0~22307
X-Git-Url: http://git.cyclocoop.org/%22.%24redirect_annul.%22?a=commitdiff_plain;h=c6738a6ecd09dcbc9d55ffddbefa3d4d2e95793c;p=lhc%2Fweb%2Fwiklou.git

SiteStats: use field names in select instead of *

Change-Id: Id8eefdf5fb320a920b7d1c725e0d250f9b6125c1
---

diff --git a/includes/SiteStats.php b/includes/SiteStats.php
index 422d606b05..01841b67db 100644
--- a/includes/SiteStats.php
+++ b/includes/SiteStats.php
@@ -48,8 +48,7 @@ class SiteStats {
 			# Update schema
 			$u = new SiteStatsUpdate( 0, 0, 0 );
 			$u->doUpdate();
-			$dbr = wfGetDB( DB_SLAVE );
-			self::$row = $dbr->selectRow( 'site_stats', '*', false, __METHOD__ );
+			self::$row = self::doLoad( wfGetDB( DB_SLAVE ) );
 		}
 
 		self::$loaded = true;
@@ -91,7 +90,16 @@ class SiteStats {
 	 * @return Bool|ResultWrapper
 	 */
 	static function doLoad( $db ) {
-		return $db->selectRow( 'site_stats', '*', false, __METHOD__ );
+		return $db->selectRow( 'site_stats', array(
+				'ss_row_id',
+				'ss_total_views',
+				'ss_total_edits',
+				'ss_good_articles',
+				'ss_total_pages',
+				'ss_users',
+				'ss_active_users',
+				'ss_images',
+			), false, __METHOD__ );
 	}
 
 	/**