From fe7abeca083b0fb4bbb5f6e35b87f11b6c2b5f89 Mon Sep 17 00:00:00 2001
From: Raimond Spekking <raymond@users.mediawiki.org>
Date: Tue, 22 Apr 2008 09:01:04 +0000
Subject: [PATCH] Convenience tweaks: * Change link of groupname to the project
 group page * Add explicit link to Special:listusers. New message:
 'listgrouprights-members'

---
 includes/SpecialListgrouprights.php | 26 +++++++++++++++++++++-----
 languages/messages/MessagesDe.php   |  1 +
 languages/messages/MessagesEn.php   |  1 +
 maintenance/language/messages.inc   |  1 +
 4 files changed, 24 insertions(+), 5 deletions(-)

diff --git a/includes/SpecialListgrouprights.php b/includes/SpecialListgrouprights.php
index d03aefe859..aa65c22b73 100644
--- a/includes/SpecialListgrouprights.php
+++ b/includes/SpecialListgrouprights.php
@@ -48,15 +48,31 @@ class SpecialListGroupRights extends SpecialPage {
 				$groupnameLocalized = $msg;
 			}
 
-			if ( in_array( $group, $wgImplicitGroups ) )
-				$grouplink = $groupnameLocalized;
-			else
-				$grouplink = $this->skin->makeKnownLinkObj( SpecialPage::getTitleFor( 'Listusers' ), $groupnameLocalized, 'group=' . $group );
+			$msg = wfMsgForContent( 'grouppage-' . $groupname );
+			if ( wfEmptyMsg( 'grouppage-' . $groupname, $msg ) || $msg == '' ) {
+				$grouppageLocalized = $groupname;
+			} else {
+				$grouppageLocalized = $msg;
+			}
+
+			if( $group == '*' ) {
+				// Do not make a link for the generic * group
+				$grouppage = $groupnameLocalized;
+			} else {
+				$grouppage = $this->skin->makeLink( $grouppageLocalized, $groupnameLocalized );
+			}
+
+			if ( !in_array( $group, $wgImplicitGroups ) ) {
+				$grouplink = '<br />' . $this->skin->makeKnownLinkObj( SpecialPage::getTitleFor( 'Listusers' ), wfMsg( 'listgrouprights-members' ), 'group=' . $group );
+			} else {
+				// No link to Special:listusers for implicit groups as they are unlistable
+				$grouplink = '';
+			}
 
 			$wgOut->addHTML(
 				'<tr>
 					<td>' .
-						$grouplink .
+						$grouppage . $grouplink .
 					'</td>
 					<td>' .
 						self::formatPermissions( $permissions ) .
diff --git a/languages/messages/MessagesDe.php b/languages/messages/MessagesDe.php
index 6b6a99a4d1..9f2332efcc 100644
--- a/languages/messages/MessagesDe.php
+++ b/languages/messages/MessagesDe.php
@@ -1491,6 +1491,7 @@ auf die bereits die erste Weiterleitung zeigen sollte.',
 'listgrouprights-group'    => 'Gruppe',
 'listgrouprights-rights'   => 'Rechte',
 'listgrouprights-helppage' => 'Help:Gruppenrechte',
+'listgrouprights-members'  => '(Mitgliederliste)',
 
 # E-mail user
 'mailnologin'     => 'Fehler beim E-Mail-Versand',
diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php
index f2abae1478..5347f8adec 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -1910,6 +1910,7 @@ It may contain one or more characters which cannot be used in titles.',
 'listgrouprights-rights'   => 'Rights',
 'listgrouprights-link'     => '[[{{MediaWiki:Listgrouprights-helppage}}#$1|$1]]', # do not translate or duplicate this message to other languages
 'listgrouprights-helppage' => 'Help:Group rights',
+'listgrouprights-members'  => '(list of members)',
 
 # E-mail user
 'mailnologin'     => 'No send address',
diff --git a/maintenance/language/messages.inc b/maintenance/language/messages.inc
index ab34437958..56c88bda2f 100644
--- a/maintenance/language/messages.inc
+++ b/maintenance/language/messages.inc
@@ -1238,6 +1238,7 @@ $wgMessageStructure = array(
 		'listgrouprights-rights',
 		'listgrouprights-link',
 		'listgrouprights-helppage',
+		'listgrouprights-members',
 	),
 	'emailuser' => array(
 		'mailnologin',
-- 
2.20.1