From 286245181ddbf5f4b80e3da11dfa170354316573 Mon Sep 17 00:00:00 2001 From: Tobias Gritschacher Date: Mon, 4 Sep 2017 13:58:49 +0200 Subject: [PATCH] Check for Wikidiff2 version 0.3 NOT for 0.3.0 version_compare( '0.3', '0.3.0', '>=' ) gives false, so we need to check for 0.3 since the Wikidiff2 version is defined as 0.3 in https://gerrit.wikimedia.org/r/#/c/319866/60/Wikidiff2.h Bug: T166571 Change-Id: Id6e9f402af2fab784a3db2444f201022e2d0de3e --- includes/diff/DifferenceEngine.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/diff/DifferenceEngine.php b/includes/diff/DifferenceEngine.php index 7f9af604fd..34f285235a 100644 --- a/includes/diff/DifferenceEngine.php +++ b/includes/diff/DifferenceEngine.php @@ -918,7 +918,7 @@ class DifferenceEngine extends ContextSource { $wikidiff2Version = phpversion( 'wikidiff2' ); if ( $wikidiff2Version !== false && - version_compare( $wikidiff2Version, '0.3.0', '>=' ) + version_compare( $wikidiff2Version, '0.3', '>=' ) ) { $text = wikidiff2_do_diff( $otext, -- 2.20.1