Translation updater bot [Sat, 5 Jan 2019 14:01:58 +0000 (15:01 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I5f2f62795f2efc8b375d1ea2a0d413908792ecc9
jenkins-bot [Fri, 4 Jan 2019 22:50:33 +0000 (22:50 +0000)]
Merge "Make ContribsPager properties private again"
Kosta Harlan [Fri, 4 Jan 2019 21:33:45 +0000 (16:33 -0500)]
Make ContribsPager properties private again
Bug: T212771
Follows-Up: I2295a3fefe874a59458e6ea7edd2cfdd9e912096
Depends-On: I847cb6863be2b6b196b2a992c3dde13e0b21462a
Change-Id: I6b7d0c502ab0219de1b04c8e78e4aaffe43ea0d0
Translation updater bot [Fri, 4 Jan 2019 21:45:00 +0000 (22:45 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie96ca9a369fc56dfee770db77cd81378a9f9beda
jenkins-bot [Fri, 4 Jan 2019 21:16:34 +0000 (21:16 +0000)]
Merge "DeletedContribsPager: Add getters for properties accessed by Flow"
jenkins-bot [Fri, 4 Jan 2019 21:16:28 +0000 (21:16 +0000)]
Merge "Add getters for properties accessed by Flow"
Thalia [Fri, 4 Jan 2019 18:20:09 +0000 (18:20 +0000)]
Remove unnecessary calc operation in .less file
Change-Id: I3db79e58e6d590da0fc2b168d784e1f666c2337b
jenkins-bot [Fri, 4 Jan 2019 11:02:49 +0000 (11:02 +0000)]
Merge "Always load styles for Special:Block page"
jenkins-bot [Fri, 4 Jan 2019 10:12:23 +0000 (10:12 +0000)]
Merge "Temporarily make ContribsPager properties public to unblock Flow"
Kosta Harlan [Wed, 2 Jan 2019 16:24:20 +0000 (11:24 -0500)]
Temporarily make ContribsPager properties public to unblock Flow
This partially "reverts" Ic2367ca by explicitely marking the properties
Flow depends on as public. Before, these properties have not been
declared, but dynamically created. PHP marks dynamically created
properties as public by default.
Note that before Ic2367ca it was not even documented that these properties
exist. Flow was using undocumented code.
This revert is done to unblock the currently broken Beta cluster and
give us more time to find cleaner solutions. Some much more sustainable
solutions are discussed in T212771.
Bug: T212771
Change-Id: I2295a3fefe874a59458e6ea7edd2cfdd9e912096
Kosta Harlan [Fri, 4 Jan 2019 02:37:21 +0000 (21:37 -0500)]
DeletedContribsPager: Add getters for properties accessed by Flow
Bug: T212771
Follows-Up: I35dad85740cae47877e9eb62d179b1412099aad1
Change-Id: I9d324217cacc2d731945975b7066d4c17bd915fb
Reedy [Fri, 4 Jan 2019 02:17:43 +0000 (02:17 +0000)]
Don't hardcode guzzle dependancies
Change-Id: I09eb6c9a70c269f14e1e8309fdc572769c4fc07d
Kosta Harlan [Thu, 3 Jan 2019 18:54:06 +0000 (13:54 -0500)]
Add getters for properties accessed by Flow
Bug: T212771
Follows-Up: Ic2367ca7e8d8b2b7ae4f80ad04081a0db2821de5
Change-Id: I35dad85740cae47877e9eb62d179b1412099aad1
Translation updater bot [Thu, 3 Jan 2019 21:24:08 +0000 (22:24 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I78a173ff93a983f41c8baf5f3b1e739d1aa1f602
Thalia [Thu, 3 Jan 2019 19:04:48 +0000 (19:04 +0000)]
Always load styles for Special:Block page
Load the styles regardless of whether the user has
JavaScript.
Bug: T212880
Change-Id: If103aebd1ca1368ddee7322bf52f7d9d35bd950c
jenkins-bot [Thu, 3 Jan 2019 19:25:50 +0000 (19:25 +0000)]
Merge "Remove duplicate assertion in SpecialBlockTest"
jenkins-bot [Thu, 3 Jan 2019 17:54:16 +0000 (17:54 +0000)]
Merge "Special:Block: Align partial input field better with rest of interface"
jenkins-bot [Thu, 3 Jan 2019 17:54:11 +0000 (17:54 +0000)]
Merge "Fix type for UserMailer::send $body param"
jenkins-bot [Thu, 3 Jan 2019 17:54:05 +0000 (17:54 +0000)]
Merge "Add check for editing restriction widget on Special:Block"
Volker E [Wed, 2 Jan 2019 23:54:15 +0000 (15:54 -0800)]
Special:Block: Align partial input field better with rest of interface
Also include sizing foundational variables to deal with `em` rendering quirks,
aimed to be replaced by central ones in future.
Change-Id: Iba65f68b233becba6054ca068a4cf7aaee0d8e4c
Thalia [Thu, 3 Jan 2019 17:06:50 +0000 (17:06 +0000)]
Remove duplicate assertion in SpecialBlockTest
Change-Id: I55d0112a8e3acf06fdfca979552a2746ae928c4f
Umherirrender [Thu, 3 Jan 2019 17:01:54 +0000 (18:01 +0100)]
Fix type for UserMailer::send $body param
It is documented to be an array, so add it to the type
Change-Id: I92c56fd92f2c09f75d9370aab711b7446c31beb5
jenkins-bot [Thu, 3 Jan 2019 11:58:06 +0000 (11:58 +0000)]
Merge "watcheditem: Remove unused import/use statement"
Thalia [Thu, 3 Jan 2019 10:59:20 +0000 (10:59 +0000)]
Add check for editing restriction widget on Special:Block
If partial blocks is not enabled, editing restriction widget
will not exist, so check before binding events.
Bug: T212808
Change-Id: I33fd7efdc24c026338e25d7c0751d31bc9a7baba
Derick Alangi [Thu, 3 Jan 2019 10:31:32 +0000 (11:31 +0100)]
watcheditem: Remove unused import/use statement
Namespace imported but never used hence removed as it's not
necessary.
Change-Id: I788852cdbd310f4c891d1f438aac691719386044
jenkins-bot [Thu, 3 Jan 2019 00:11:48 +0000 (00:11 +0000)]
Merge "Convert Special:AllMessages to use OOUI"
jenkins-bot [Wed, 2 Jan 2019 23:53:35 +0000 (23:53 +0000)]
Merge "mailmap: list new address not detected by updateCredits.php"
jenkins-bot [Wed, 2 Jan 2019 23:53:28 +0000 (23:53 +0000)]
Merge "Update CREDITS file to include new contributors"
Sethakill [Wed, 4 May 2016 19:23:04 +0000 (21:23 +0200)]
Convert Special:AllMessages to use OOUI
Moved form from pager and
added new HTMLSelectLanguageField.
Bug: T117749
Bug: T134425
Change-Id: I46dc6cc8f7ddf8552a726202df136cbbff66588c
jenkins-bot [Wed, 2 Jan 2019 23:10:31 +0000 (23:10 +0000)]
Merge "SkinApi: Do not load 'mediawiki.searchSuggest'"
jenkins-bot [Wed, 2 Jan 2019 23:10:26 +0000 (23:10 +0000)]
Merge "Make sql.php exit status more informative"
jenkins-bot [Wed, 2 Jan 2019 21:48:11 +0000 (21:48 +0000)]
Merge "Unbreak Pbkdf2PasswordTest"
jenkins-bot [Wed, 2 Jan 2019 21:22:49 +0000 (21:22 +0000)]
Merge "filerepo: Replace confusing substr() with rtrim()"
Translation updater bot [Wed, 2 Jan 2019 21:02:33 +0000 (22:02 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ife6a31781d2ab05655f80a1c45bdd71b008f75c5
jenkins-bot [Wed, 2 Jan 2019 20:58:30 +0000 (20:58 +0000)]
Merge "filerepo: Avoid two pointless substr() in File"
jenkins-bot [Wed, 2 Jan 2019 20:58:25 +0000 (20:58 +0000)]
Merge "Make use of \File::getArchiveRel to avoid code duplication"
jenkins-bot [Wed, 2 Jan 2019 20:55:02 +0000 (20:55 +0000)]
Merge "user: Ensure returned user groups are sorted"
jdlrobson [Wed, 2 Jan 2019 19:35:38 +0000 (11:35 -0800)]
Tag markers should be wrapped in parentheses on diff page
Bug: T212613
Change-Id: I87ba8a12f520bcad7354dc9ed1c9f46aa02c715f
Bartosz Dziewoński [Wed, 2 Jan 2019 19:21:18 +0000 (20:21 +0100)]
SkinApi: Do not load 'mediawiki.searchSuggest'
Bug: T212752
Change-Id: Ia6fba6934d0dfc528ad07a159bc5fbf03e9e9f24
jenkins-bot [Wed, 2 Jan 2019 16:49:44 +0000 (16:49 +0000)]
Merge "Sync up with Parsoid parserTests.txt"
jenkins-bot [Wed, 2 Jan 2019 16:22:06 +0000 (16:22 +0000)]
Merge "Add missing property declarations to LocalFileTest"
Subramanya Sastry [Fri, 28 Dec 2018 16:27:08 +0000 (10:27 -0600)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
391acbfe0c93d632727ea08cd2a10b4dba8c257f
Change-Id: I0e8c154eaf118f9cd5b58d657f64d0829a65c8f0
Thiemo Kreuz [Wed, 2 Jan 2019 15:29:04 +0000 (16:29 +0100)]
filerepo: Replace confusing substr() with rtrim()
I just looked at this code for ten minutes to understand what
sub-string is extracted here. Not only are the numbers hard to
understand: With 0 and -1 the last character is removed – that's
really all this does. Even more problematic is the fact there is
no check, hint, not even a comment explaining *which* character is
removed. If – for whatever reason – the code above returns a string
that does *not* end with a slash, the unconditional substr() call
must destroy this string.
rtrim() shows the character.
I checked and these strings are all guaranteed to use forward
slashes, never backwards (Windows) slashes.
Change-Id: I2e17fd583982920bb8a0ca73035094099e5e5d31
Thiemo Kreuz [Wed, 2 Jan 2019 15:27:09 +0000 (16:27 +0100)]
filerepo: Avoid two pointless substr() in File
In both cases the slash was added one line above, just to be cut off
again.
Change-Id: I15ff6b47821033f123f555f02c42fc8984ad9800
Thiemo Kreuz [Wed, 2 Jan 2019 15:24:56 +0000 (16:24 +0100)]
Make use of \File::getArchiveRel to avoid code duplication
Before, the string "archive/" was hard-coded in many places.
Change-Id: I62e4471711d183f37e89dc02f3709187164faf0e
Thiemo Kreuz [Wed, 2 Jan 2019 14:25:44 +0000 (15:25 +0100)]
Add missing property declarations to LocalFileTest
Change-Id: I518a7a939042110f7ca67b0697e35e2e35105a08
jenkins-bot [Wed, 2 Jan 2019 12:37:03 +0000 (12:37 +0000)]
Merge "Remove unused line"
Alangi Derick [Mon, 3 Dec 2018 12:38:03 +0000 (13:38 +0100)]
logging: Correct $logId default value in LogPager.php
$logId holds the log entry ID of some specific log and the datatype
is an integer (int) which is correct but looking at the constructor,
it does take a bool (false) which contradicts the docs above. So per
@Thiemo's advice after review of prev PS, it would be better to replace
false with 0 and leave the docs untouched.
Change-Id: Ieceb79a6cbaa248e1b7a7d3c1d51eb26bb3a2d84
jenkins-bot [Wed, 2 Jan 2019 11:03:18 +0000 (11:03 +0000)]
Merge "Move exif messages to a separate i18n file"
jenkins-bot [Wed, 2 Jan 2019 10:34:19 +0000 (10:34 +0000)]
Merge "Revert "build: Run minus-x to check for executable files that shouldn't be""
Jforrester [Wed, 2 Jan 2019 10:19:43 +0000 (10:19 +0000)]
Revert "build: Run minus-x to check for executable files that shouldn't be"
This reverts commit
bd2a718cf09cc5826d5a1ef27b1fbb21741e4342.
Bug: T212766
Change-Id: Ic453d7e672ad6c1e39f33f7efd104483f95f5b89
Max Semenik [Wed, 2 Jan 2019 08:21:13 +0000 (00:21 -0800)]
Unbreak Pbkdf2PasswordTest
Due to https://github.com/sebastianbergmann/phpunit/issues/3459 it was
looking for a wrong function name and was skipping the test even when PHP
support was present.
Change-Id: I2508f192a76275286e95bd6a06e4628d98b11737
Max Semenik [Thu, 27 Dec 2018 06:16:32 +0000 (22:16 -0800)]
Remove unused line
Change-Id: I4bc6ec69b84b5f29e3c4c7833697f4d2be82e29a
Translation updater bot [Tue, 1 Jan 2019 20:55:56 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I3ea23299dd3d8608c829977c8aa1f3dfe2505d3d
ryan10145 [Fri, 5 Jan 2018 03:16:23 +0000 (22:16 -0500)]
build: Run minus-x to check for executable files that shouldn't be
Bug: T175794
Change-Id: Ia94b3e832ff21f9f76bd63924bf289cd2afdefbc
MarcoAurelio [Tue, 1 Jan 2019 17:42:54 +0000 (18:42 +0100)]
mailmap: list new address not detected by updateCredits.php
Depends-On: Id54c1832313f489d9d1857d03f1663137d04ef60
Change-Id: I48073307b0fa76b159d358084601ba803d27bad2
jenkins-bot [Tue, 1 Jan 2019 14:37:45 +0000 (14:37 +0000)]
Merge "Revert "Cached HTML/JS shouldn't show two toggle links""
jenkins-bot [Tue, 1 Jan 2019 14:29:49 +0000 (14:29 +0000)]
Merge "Mark constructors of IndexPager subclasses as public"
jenkins-bot [Tue, 1 Jan 2019 14:16:12 +0000 (14:16 +0000)]
Merge "Improve documentation of wfDeprecated"
jenkins-bot [Tue, 1 Jan 2019 14:12:04 +0000 (14:12 +0000)]
Merge "SpecialTags: Add <thead> and <tbody> in the sortable table"
jenkins-bot [Tue, 1 Jan 2019 14:10:45 +0000 (14:10 +0000)]
Merge "SpecialMediaStatistics: Add <thead> and <tbody> in the table"
jenkins-bot [Tue, 1 Jan 2019 14:05:53 +0000 (14:05 +0000)]
Merge "tablesorter: Simplify jQuery#removeClass usage by using array"
Fomafix [Sun, 30 Dec 2018 13:42:40 +0000 (14:42 +0100)]
SpecialTags: Add <thead> and <tbody> in the sortable table
This avoids that module 'jquery.tablesorter' has to add the elements.
With change I0b446d18f47428d8c0c4aed78b75de16fe106218 this also avoids
a flash of missing sorting buttons while loading.
Change-Id: If6368af27606ebdb6f8d6e3bbe742706ec45e4e6
jenkins-bot [Tue, 1 Jan 2019 13:50:45 +0000 (13:50 +0000)]
Merge "Use ContextSource::getConfig instead of globals"
Fomafix [Sun, 30 Dec 2018 18:00:57 +0000 (19:00 +0100)]
tablesorter: Simplify jQuery#removeClass usage by using array
Since jQuery 3.3, .removeClass() supports arrays.
https://blog.jquery.com/2018/01/19/jquery-3-3-0-a-fragrant-bouquet-of-deprecations-and-is-that-a-new-feature/
Change-Id: I7302373357efe9fbd619cfeedfec364fd245b335
Umherirrender [Mon, 31 Dec 2018 20:13:49 +0000 (21:13 +0100)]
Use ContextSource::getConfig instead of globals
Change-Id: I26dd9b1efc0292bbe0044d823f639a2ac5e339dd
Umherirrender [Mon, 31 Dec 2018 20:14:59 +0000 (21:14 +0100)]
Use ContextSource::getConfig instead of globals in Skin.php
Change-Id: I2c1b8ab875ff8d671a7cad6c056fb1c23112e241
Fomafix [Sat, 29 Dec 2018 21:16:36 +0000 (22:16 +0100)]
SpecialMediaStatistics: Add <thead> and <tbody> in the table
This avoids that jquery.tablesorter has to add the elements.
Change-Id: Iab7baa641113552720df022cd05d7c4970b4a886
Fomafix [Sat, 29 Dec 2018 09:44:05 +0000 (10:44 +0100)]
Revert "Cached HTML/JS shouldn't show two toggle links"
This reverts commit
51edd7e9fa3a27e796498547044d063813886503.
All caches are now expired.
Bug: T195053
Change-Id: I16403b5cd57c3cc8acd3afaf6152e30ebb8d4a05
jenkins-bot [Sat, 29 Dec 2018 01:10:13 +0000 (01:10 +0000)]
Merge "auth: Follow up on
e907d4328dc3e"
jenkins-bot [Fri, 28 Dec 2018 23:08:40 +0000 (23:08 +0000)]
Merge "Special:Search: Generate toggle buttons in HTML instead of JavaScript"
Fomafix [Sun, 23 Dec 2018 14:13:00 +0000 (15:13 +0100)]
Special:Search: Generate toggle buttons in HTML instead of JavaScript
This change ensures that the toggle buttons are already present while
loading.
Depends-On: I41225ccdf8a95a7c501fb6eea99abbd08353f4ea
Change-Id: I3292cf48214b842542ba97730ad91a1e95d127fe
Reedy [Thu, 27 Dec 2018 20:29:14 +0000 (20:29 +0000)]
Improve documentation of wfDeprecated
Change-Id: I20b7724f0cf2b0221ae27412844e4019ae451b61
Reedy [Thu, 27 Dec 2018 20:19:35 +0000 (20:19 +0000)]
Deprecate PasswordPolicyChecks::checkPopularPasswordBlacklist
Change-Id: I4c90e361b7538efeb0c5efa7ca61aed2e468591c
Gergő Tisza [Thu, 20 Dec 2018 22:51:14 +0000 (14:51 -0800)]
Simplify default password policy
* Remove PasswordNotInLargeBlacklist => false, it's a no-op
* Deduplicate PasswordCannotMatchUsername
* Remove PasswordCannotBePopular. There is no point in using both
PasswordCannotBePopular (top 10K passwords from SecLists) and
PasswordNotInLargeBlacklist (top 100K passwords from SecLists),
and the CDB lookup is probably not that cheap.
Change-Id: I868846931988b88f06800e42861e82e2bb0bc427
Jayprakash12345 [Sat, 30 Jun 2018 13:20:44 +0000 (18:50 +0530)]
Correct $magicWords for sa.wiki
Bug: T102320
Change-Id: I4ef78dc7a41916a9af6aa259de455e3948662913
Martin Urbanec [Thu, 27 Dec 2018 15:43:15 +0000 (16:43 +0100)]
Update CREDITS file to include new contributors
Ran the updateCredits.php script to include new contributors of
MW and its extensions into the CREDITS file after a while. Keeping
the contributor list updated is useful.
Change-Id: Id54c1832313f489d9d1857d03f1663137d04ef60
Amir Aharoni [Wed, 5 Sep 2018 12:16:50 +0000 (15:16 +0300)]
Move exif messages to a separate i18n file
Bug: T167762
Change-Id: I17900ff07cd9b15f00c7118b4206cf1cdc074469
Translation updater bot [Thu, 27 Dec 2018 08:16:39 +0000 (09:16 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: If00b12af3d4346114260c9e4312bcab489e9a622
Fomafix [Tue, 25 Dec 2018 13:35:21 +0000 (14:35 +0100)]
Fix comments in language class tests
* Add `@covers LanguageGa`.
* Language code `bs` is for "Bosnian (bosanski)" and not for "Croatian
(hrvatski)".
Change-Id: I605bdd254518dd708343e36a2dee65dd0aa17b63
MarcoAurelio [Mon, 24 Dec 2018 14:51:11 +0000 (15:51 +0100)]
Fix typo "maintainance"
Bug: T201491
Change-Id: I8724206404a461eaace3b60f91c7704bd6581ee2
jenkins-bot [Mon, 24 Dec 2018 01:51:37 +0000 (01:51 +0000)]
Merge "Update OOUI to v0.30.0"
jenkins-bot [Sun, 23 Dec 2018 23:47:10 +0000 (23:47 +0000)]
Merge "Add 'suppressrevision' right to new 'oversight' grant"
Martin Urbanec [Sat, 29 Sep 2018 18:40:33 +0000 (20:40 +0200)]
Add 'suppressrevision' right to new 'oversight' grant
Change-Id: Ic7eeff94ea533670c85c9e82801f38fded9e7a30
James D. Forrester [Sat, 22 Dec 2018 11:36:59 +0000 (11:36 +0000)]
Update OOUI to v0.30.0
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.30.0
Bug: T150071
Bug: T150781
Bug: T183271
Bug: T190581
Bug: T196208
Bug: T208644
Bug: T208821
Bug: T210039
Bug: T210914
Bug: T211154
Bug: T211223
Bug: T212064
Bug: T212068
Bug: T212159
Bug: T212186
Bug: T212299
Bug: T212389
Depends-On: I00d3fa932de968019c6ad676237ed5e5077fb961
Change-Id: I00d3fa932de968019c6ad676237ed5e5077fb962
Max Semenik [Fri, 28 Apr 2017 21:08:32 +0000 (14:08 -0700)]
user: Ensure returned user groups are sorted
Without it, Special:UserRights sometimes fails with a bogus conflict error
just because groups are somehow ordered differently.
Bug: T164211
Change-Id: I9c7f51338e0849d9e134dc780eb13c542960c655
Mukunda Modell [Fri, 19 Oct 2018 18:45:54 +0000 (13:45 -0500)]
eval.php: write error messages to stderr
Error messages should go to stderr not stdout.
Bug: T121597
Change-Id: Ibde26059982d1e621a104694343682a2032ac844
jenkins-bot [Sat, 22 Dec 2018 00:25:15 +0000 (00:25 +0000)]
Merge "XmlSelect: Fix PHPDoc param comments for addOption() & formatOptions()"
Alangi Derick [Mon, 17 Dec 2018 15:51:19 +0000 (16:51 +0100)]
XmlSelect: Fix PHPDoc param comments for addOption() & formatOptions()
Change-Id: I60f1bd78b3820510f9fbc497e1c703f9da7fd900
jenkins-bot [Fri, 21 Dec 2018 23:39:16 +0000 (23:39 +0000)]
Merge "Mark protected IndexPager properties also as protected in subclasses"
jenkins-bot [Fri, 21 Dec 2018 23:33:07 +0000 (23:33 +0000)]
Merge "Avoid expensive array_shift where possible"
jenkins-bot [Fri, 21 Dec 2018 23:33:01 +0000 (23:33 +0000)]
Merge "Revision: Assert that $mRecord is never null in Revision"
jenkins-bot [Fri, 21 Dec 2018 23:29:59 +0000 (23:29 +0000)]
Merge "Linker: Deprecate non-Language types for $lang of tocList() and generateTOC()"
daniel [Thu, 20 Dec 2018 18:26:42 +0000 (19:26 +0100)]
Revision: Assert that $mRecord is never null in Revision
Bug: T187153
Change-Id: I828954855aa24114ec756e45d4dfe1468b2efa27
jenkins-bot [Fri, 21 Dec 2018 22:42:41 +0000 (22:42 +0000)]
Merge "objectcache: add expiration check callback to WANObjectCache::getWithSetCallback"
jenkins-bot [Fri, 21 Dec 2018 22:42:08 +0000 (22:42 +0000)]
Merge "rdbms: add trace to getLagFromPtHeartbeat() log entries"
Aaron Schulz [Fri, 21 Dec 2018 21:24:54 +0000 (21:24 +0000)]
Merge "Make thumbnail image decoding async"
Thiemo Kreuz [Thu, 20 Dec 2018 16:58:15 +0000 (17:58 +0100)]
Mark private properties in ContribsPager as "private"
There should not be any code accessing these. The way to set these
properties is via the constructor.
Change-Id: I8f2a8e88b8dfad53d0b16bc3f73974b894a031fb
Aaron Schulz [Wed, 5 Dec 2018 19:46:57 +0000 (14:46 -0500)]
objectcache: add expiration check callback to WANObjectCache::getWithSetCallback
This is useful when the timestamps to be checked depend on the value or are stored
in the database rather than as check keys.
Change-Id: I81ab08a943ee7d2f96a132d371965501941ed37f
Thiemo Kreuz [Thu, 20 Dec 2018 16:54:51 +0000 (17:54 +0100)]
Remove redundant property declarations
These are already declared and initialized in the base class. No need
to repeat this.
Change-Id: I4f83202cc9076bd68fa25490bdf8b4a2913b6b04