Kunal Mehta [Sun, 20 May 2018 19:13:05 +0000 (12:13 -0700)]
registration: Validate AutoloadNamespaces keys have trailing \
The PSR-4 autoloader requires "AutoloadNamespaces" keys to have a
trailing \ (\\ in JSON), so add a validation check for that.
Unfortunately the validation error isn't great, since it checks to see
if the property matches patternProperties, and when it doesn't, it
claims the property isn't defined since additionalProperties is false.
But it's still better than not failing when they are missing.
Bug: T189136
Change-Id: If01bd06cdd767fb704a8ff85cdf1c143e53fa4ca
jenkins-bot [Sat, 19 May 2018 23:13:25 +0000 (23:13 +0000)]
Merge "Re-enable MediaWiki.Usage.AssignmentInReturn.AssignmentInReturn sniff"
jenkins-bot [Sat, 19 May 2018 23:13:22 +0000 (23:13 +0000)]
Merge "Re-enable MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals sniff"
jenkins-bot [Sat, 19 May 2018 22:24:34 +0000 (22:24 +0000)]
Merge "Autofix MediaWiki.Commenting.FunctionComment.SpacingDoc* errors"
Kunal Mehta [Sat, 19 May 2018 21:52:00 +0000 (14:52 -0700)]
Re-enable MediaWiki.Usage.AssignmentInReturn.AssignmentInReturn sniff
...except in tests, where there's a pattern of using it in data
providers.
Change-Id: Iea15cd9c6046910b0c91044cd2aeaff1a40f4fc5
Kunal Mehta [Sat, 19 May 2018 21:41:41 +0000 (14:41 -0700)]
Re-enable MediaWiki.Usage.SuperGlobalsUsage.SuperGlobals sniff
Disable it in specific files and places where there are legitimate uses
to access $_GET and $_POST directly.
For EditPage, which wants to output $_POST for debugging information,
introduce WebRequest::getPostValues() as a wrapper, matching the
existing ::getQueryValues().
Change-Id: I2cb0a7012fb7ed29dcd720056b42f56508ddc5fa
jenkins-bot [Sat, 19 May 2018 21:26:35 +0000 (21:26 +0000)]
Merge "Re-enable Generic.Files.OneObjectStructurePerFile sniff"
Kunal Mehta [Sat, 19 May 2018 20:46:54 +0000 (13:46 -0700)]
Autofix MediaWiki.Commenting.FunctionComment.SpacingDoc* errors
Change-Id: I63761ebce04c03b9b13237919c27cc10180f198f
Kunal Mehta [Mon, 7 May 2018 08:53:28 +0000 (01:53 -0700)]
Re-enable Generic.Files.OneObjectStructurePerFile sniff
Whitelist existing violations in .phpcs.xml, and enable the sniff to
prevent people from accidentally introducing new violations.
languages/ is blanket exempted since languages that have language
converters tend to have two classes in one file.
tests/ is also blanket exempted since many tests create mock classes,
and we don't care about PSR-4 compliance in tests.
Change-Id: I56be2f23bae3e24c062198b766cb48edab5e395e
Timo Tijhof [Wed, 28 Mar 2018 00:57:06 +0000 (17:57 -0700)]
resourceloader: Apply safemode to startup module registry
This effectively applies safemode to the mw.loader client,
without the client itself needing specific knowledge of safemode.
Test Plan:
* Unchanged: When viewing a page in safemode, the 'user' and
'site' modules are still not queued by OutputPage.
* New: mw.loader.getState('site'), previously would yield
'registered', but will now yield null.
* New: mw.loader.load('site'), previously loaded the module,
it now logs a dependency warning for unknown module, like for
any other unknown module.
* New: mw.loader.using('site'), previously resolved, it is now
rejected.
Bug: T185303
Change-Id: I672e3891c8e1b3c2d13655fa134d0f1d031b8247
Translation updater bot [Sat, 19 May 2018 20:01:55 +0000 (22:01 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia5116d3301606e7672799523c838bb598e7d3b66
jenkins-bot [Sat, 19 May 2018 14:17:57 +0000 (14:17 +0000)]
Merge "Document nodata for HTMLFormFields"
Florian Schmidt [Mon, 23 Jan 2017 19:30:36 +0000 (20:30 +0100)]
Document nodata for HTMLFormFields
This could be a useful feature for users of HTMLForm, so they should be
able to know about it.
Bug: T156056
Change-Id: Ib444051e38292c06ebe370465b7c751e136d42b2
jenkins-bot [Sat, 19 May 2018 13:16:16 +0000 (13:16 +0000)]
Merge "Change a.external padding from 15px to 13px to match Vector"
jenkins-bot [Sat, 19 May 2018 12:19:38 +0000 (12:19 +0000)]
Merge "resourceloader: Simplify mwLoadEnd hook implementation"
jenkins-bot [Sat, 19 May 2018 12:09:28 +0000 (12:09 +0000)]
Merge "makeCollapsible: Remove animations"
jenkins-bot [Sat, 19 May 2018 11:56:57 +0000 (11:56 +0000)]
Merge "Add ct_tag_id field to change_tag table"
Derk-Jan Hartman [Sat, 19 May 2018 11:12:18 +0000 (13:12 +0200)]
makeCollapsible: Remove animations
The animations are:
* not well liked
* non-configurable (in presence and time)
* bad for performance
* javascript based instead of CSS
Removing them allows us to make it easier to replace NavFrame and
collapsible as deployed by the communities, and will be better for
mobile use as well.
Bug: T195049
Change-Id: I5eb505d1bd2097fe5d98db47293583e7225310de
Timo Tijhof [Mon, 7 May 2018 21:57:40 +0000 (22:57 +0100)]
resourceloader: Simplify mwLoadEnd hook implementation
In addition to the high overhead of $.Deferred per-module in
mw.loader.using(), this was also using $.when() and another
Deferred in catch() for casting.
The handler for marking mwLoadEnd needs a Promise in our fallback
for compatibility with the original using() call. But the code
within our fallback does not need to use N promises, for that
we can simply use a counter that we decrement, given we only need
to worry about completion.
So basically, use `Deferred#always(callback)`
instead of `Deferred.catch(=>Defered().resolve)).then(callback)`.
This is in preparation for moving the code to NavigationTiming.
Change-Id: I20514d3fe680fc9384a0f7ce0880652970d86856
jenkins-bot [Sat, 19 May 2018 10:48:08 +0000 (10:48 +0000)]
Merge "tablesorter: test for data-sort-value on children"
jenkins-bot [Sat, 19 May 2018 10:41:42 +0000 (10:41 +0000)]
Merge "tablesorter: be more specific about reserving space for header cells"
jenkins-bot [Sat, 19 May 2018 10:38:23 +0000 (10:38 +0000)]
Merge "Avoid unnecessary WaitConditionLoop delays in ChronologyProtector"
jenkins-bot [Sat, 19 May 2018 09:26:48 +0000 (09:26 +0000)]
Merge "Add Special:PasswordPolicies"
Ed Sanders [Sat, 19 May 2018 09:20:52 +0000 (11:20 +0200)]
Change a.external padding from 15px to 13px to match Vector
This is the default in Vector & Minerva, but was never
upstreamed to core. Other skins (e.g. Monobook) use the same
icons so it doesn't make sense to maintain two standards
for spacing.
Change-Id: I7eaf0756d4d58c0f902238b48176334689f3c704
Reedy [Sat, 18 Nov 2017 21:59:47 +0000 (21:59 +0000)]
Add Special:PasswordPolicies
Bug: T174812
Change-Id: Ifb4876f7309a667154c7469c29e703b6c33d54af
jenkins-bot [Sat, 19 May 2018 08:55:05 +0000 (08:55 +0000)]
Merge "Define pt as fallback for tet"
jenkins-bot [Sat, 19 May 2018 08:47:21 +0000 (08:47 +0000)]
Merge "resourceloader: Allow style-only modules to have deprecation warnings"
Aaron Schulz [Thu, 10 May 2018 23:18:19 +0000 (16:18 -0700)]
Avoid unnecessary WaitConditionLoop delays in ChronologyProtector
Since it takes time for the agent to get the response and set the
cookie and, as well, the time into a request that a LoadBalancer is
initialized varies by many seconds (cookies loaded from the start),
give the cookie a much lower TTL than the DB positions in the stash.
This avoids having to wait for a position with a given cpPosIndex
value, when the position already expired from the store, which is
a waste of time.
Also include the timestamp in "cpPosIndex" cookies to implement
logical expiration in case clients do not expire them correctly.
Bug: T194403
Bug: T190082
Change-Id: I97d8f108dec59c5ccead66432a097cda8ef4a178
jenkins-bot [Fri, 18 May 2018 20:39:25 +0000 (20:39 +0000)]
Merge "Remove else from UserGroupMembership"
Translation updater bot [Fri, 18 May 2018 20:18:58 +0000 (22:18 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I22321d32a7eff63c6aadeaf86d60f12b9cc11b09
Reedy [Fri, 18 May 2018 19:39:26 +0000 (19:39 +0000)]
Remove else from UserGroupMembership
Change-Id: I7c18df1cab69df5f124c95b1ddb241e3f1be5927
jenkins-bot [Fri, 18 May 2018 18:44:01 +0000 (18:44 +0000)]
Merge "Special:Preferences: Construct fake tabs to avoid FOUC"
jenkins-bot [Fri, 18 May 2018 18:27:26 +0000 (18:27 +0000)]
Merge "Remove everything related to CollationFa"
Ed Sanders [Mon, 23 Apr 2018 11:56:13 +0000 (12:56 +0100)]
Special:Preferences: Construct fake tabs to avoid FOUC
Bug: T192769
Bug: T189366
Change-Id: I4aabda97d14d97dce3e35abda2ce82925d721c9b
jenkins-bot [Fri, 18 May 2018 17:03:47 +0000 (17:03 +0000)]
Merge "Make Special:TrackingCategories sortable"
jenkins-bot [Fri, 18 May 2018 16:58:34 +0000 (16:58 +0000)]
Merge "Use redirect=no in whatLinksHere if the target is a redirect"
jenkins-bot [Fri, 18 May 2018 16:54:52 +0000 (16:54 +0000)]
Merge "Add checkbox in Special:ListUsers to display only users in temporary user groups"
jenkins-bot [Fri, 18 May 2018 16:54:50 +0000 (16:54 +0000)]
Merge "resourceloader: Refactor CSP $nonce passing"
Daimona Eaytoy [Mon, 7 May 2018 18:37:46 +0000 (20:37 +0200)]
Use redirect=no in whatLinksHere if the target is a redirect
When the user is looking at links to a redirect page and clicks on the
link of the page, he would expect to be sent to the page itself, not to
the final destination of the redirect.
Bug: T189860
Change-Id: I11e663cbce32b4199f16df6ed1e9b980630ece7a
jenkins-bot [Fri, 18 May 2018 16:42:47 +0000 (16:42 +0000)]
Merge "Names.php: Remove U+200E after autonym of language 'lki'"
Amir Sarabadani [Fri, 18 May 2018 14:44:18 +0000 (16:44 +0200)]
Remove everything related to CollationFa
This workaround was needed when ICU in production was broken
but after T189295 this is not needed anymore and we switched off
this collation from all Persian Wikis already
Bug: T139110
Change-Id: Ifad89555b6ac96a3eb36ca24b55e1f8ee57a1f05
jenkins-bot [Fri, 18 May 2018 15:32:34 +0000 (15:32 +0000)]
Merge "Strip Unicode 6.3.0 directional formatting characters from title"
jenkins-bot [Fri, 18 May 2018 15:32:30 +0000 (15:32 +0000)]
Merge "Strip soft hyphens (U+00AD) from title"
jenkins-bot [Fri, 18 May 2018 14:52:06 +0000 (14:52 +0000)]
Merge "Fix documentation of InfoAction::pageInfo"
Amir Sarabadani [Fri, 11 May 2018 19:16:37 +0000 (21:16 +0200)]
Add ct_tag_id field to change_tag table
Part of normalizing the table
Bug: T193867
Change-Id: I8c38e673aab14c5b87e5501da1a752c5bd4709c8
jenkins-bot [Fri, 18 May 2018 13:32:38 +0000 (13:32 +0000)]
Merge "Special:PrefixIndex: Convert to OOUI"
jenkins-bot [Fri, 18 May 2018 13:06:09 +0000 (13:06 +0000)]
Merge "makeCollapsible: Add test for nested collapsibles"
jenkins-bot [Fri, 18 May 2018 12:55:34 +0000 (12:55 +0000)]
Merge "Use .json extension for OOUI source maps"
gopavasanth [Sat, 21 Apr 2018 13:24:16 +0000 (18:54 +0530)]
Special:PrefixIndex: Convert to OOUI
Bug: T117726
Change-Id: I13c4d6d5132b7085bc954a97d270efbef0acb846
Bartosz Dziewoński [Mon, 14 May 2018 17:49:30 +0000 (19:49 +0200)]
Use .json extension for OOUI source maps
OOUI is being changed to use .json in
I94eff6d2588937bf1d932b7624576dfe35016ead.
Bug: T194676
Change-Id: I5971efc2db7a2cdc5ca0ba843625b76de25dbd8b
jenkins-bot [Fri, 18 May 2018 11:35:52 +0000 (11:35 +0000)]
Merge "Special:AllPages: Overriding the title for form submission"
Jayprakash12345 [Tue, 8 May 2018 20:21:43 +0000 (01:51 +0530)]
Special:AllPages: Overriding the title for form submission
Bug: T193965
Change-Id: I10867b89e94d9aa54f30f5f4f8b5974f68479f6f
jenkins-bot [Fri, 18 May 2018 09:19:41 +0000 (09:19 +0000)]
Merge "Enable a bunch of disabled phan checks that are no longer failing"
jenkins-bot [Fri, 18 May 2018 09:13:24 +0000 (09:13 +0000)]
Merge "Enable "PhanTypeInvalidRightOperand" phan checks"
jenkins-bot [Fri, 18 May 2018 09:08:53 +0000 (09:08 +0000)]
Merge "Enable "PhanUndeclaredVariable" phan check"
jenkins-bot [Fri, 18 May 2018 09:08:50 +0000 (09:08 +0000)]
Merge "Fix improper parameters to ReflectionMethod::invoke"
jenkins-bot [Fri, 18 May 2018 08:08:44 +0000 (08:08 +0000)]
Merge "mw.special.changeslist.enhanced: Remove special case handled by jquery.makeCollapsible now"
Kunal Mehta [Fri, 18 May 2018 06:27:59 +0000 (23:27 -0700)]
Enable a bunch of disabled phan checks that are no longer failing
Change-Id: I471bffa8a4aa20d22e7e1830a2b01fce3e099d9e
Kunal Mehta [Fri, 18 May 2018 06:27:42 +0000 (23:27 -0700)]
Enable "PhanTypeInvalidRightOperand" phan checks
HTMLFormField subclasses triggered false positives when phan incorrectly
thought that $this->mOptions was only a boolean.
ReplacementArray $this->data was defined as possibly being boolean, but
in reality that never happened.
Change-Id: I06bae9c9952366ff7927df37373b146d570f4a02
Kunal Mehta [Fri, 18 May 2018 05:35:31 +0000 (22:35 -0700)]
Enable "PhanUndeclaredVariable" phan check
All of the instances of it have been fixed. This would have prevented
T194899 from happening in the first place.
Change-Id: I19357ffc858022d3b89a040eafe9047f83df1c88
Kunal Mehta [Fri, 18 May 2018 05:30:58 +0000 (22:30 -0700)]
Fix improper parameters to ReflectionMethod::invoke
The first argument to the function is supposed to be an object, or null if
the method is static.
Otherwise on PHP 7.2 the tests fail with:
ReflectionMethod::invoke() expects parameter 1 to be object, string given
Change-Id: I7002be5809f9dfbee0788907fe85139d05c0e1fc
Timo Tijhof [Thu, 17 May 2018 18:25:49 +0000 (20:25 +0200)]
resourceloader: Refactor CSP $nonce passing
Follows-up
70941efd35562dcb700 which broke various public
signatures of the ClientHtml class that I'd prefer to handle
differently.
This commit mainly restores support for all previously public
signatures, and either removes the need for a parameter, or moves
it to the end of the original signature (as optional param).
* ClientHtml::getHeadHtml: Remove the positional/required parameter
that was added. Restoring the method to being a stateless computer
that requires no parameters. Pass the option via construct instead.
* ClientHtml::makeLoad:
- Make $nonce optional.
- Restore $extraQuery as optional.
* ResourceLoader::makeInlineScript: Document $nonce as optional
(matching the implementation).
Change-Id: Iaf33f2a060048e6606fba8d875b6d2953b21ef45
Kunal Mehta [Fri, 18 May 2018 05:18:20 +0000 (22:18 -0700)]
ApiCSPReport: Fix undefined $userAgent variable
Bug: T194899
Change-Id: Ia83f961da1db2d1245859ae584db883b7a11081c
Derk-Jan Hartman [Thu, 17 May 2018 18:20:13 +0000 (20:20 +0200)]
makeCollapsible: Add test for nested collapsibles
Follow-up to: I1c3c29dc9ca4ccbf8da83796e56964a7a6d58a81
Bug: T168689
Change-Id: I7059d870976e36b20634e9c2c919408b3eb1d7fc
Translation updater bot [Thu, 17 May 2018 19:54:02 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I75e62a47c7b013e87304f62e87f589ea588a469e
jenkins-bot [Thu, 17 May 2018 18:50:45 +0000 (18:50 +0000)]
Merge "resourceloader: Make various CSSMin performance optimizations and cleanups"
Thiemo Kreuz [Thu, 19 Apr 2018 13:45:44 +0000 (15:45 +0200)]
resourceloader: Make various CSSMin performance optimizations and cleanups
This is called relatively often. Even small improvements might have an
impact.
I'm intentionally replacing method_exists with class_exists because the
old check looked like it was done for backwards compatibility (MediaWiki
before 1.27 did not contained the method), while in reality this code is
meant to run without MediaWiki. This is much better reflected with a
straight "if this class doesn't exist, there is no MediaWiki".
I'm intentionally using the …::class feature. Yes, this works, even if the
class is not there.
Change-Id: I7f250a7cb000105bb751f68f25c6cc1c44c8f221
Bartosz Dziewoński [Tue, 8 May 2018 14:28:01 +0000 (16:28 +0200)]
mw.special.changeslist.enhanced: Remove special case handled by jquery.makeCollapsible now
No longer needed after
8cdfcc5fd4ba36b7c91ac8097390220de230f8ae.
This reverts
070374b7a4811bfb5c9da4350bc16b77321537e3.
Change-Id: I78879358f6305c1b0fa6dbba8fe9fdc06ab05cc0
jenkins-bot [Thu, 17 May 2018 17:44:09 +0000 (17:44 +0000)]
Merge "CSSMin: Do not escape U+FFFD as code point"
jenkins-bot [Thu, 17 May 2018 16:26:16 +0000 (16:26 +0000)]
Merge "mediawiki.special.watchlist: Combine visitedstatus module"
jenkins-bot [Thu, 17 May 2018 16:15:22 +0000 (16:15 +0000)]
Merge "mediawiki.special: Combine various tiny specialpage style modules"
jenkins-bot [Thu, 17 May 2018 11:45:14 +0000 (11:45 +0000)]
Merge "jquery.spinner: Remove obsolete IE8 support"
jenkins-bot [Thu, 17 May 2018 11:45:11 +0000 (11:45 +0000)]
Merge "jquery.spinner: Move files to their own src/ directory"
Fomafix [Thu, 17 May 2018 10:18:27 +0000 (12:18 +0200)]
CSSMin: Do not escape U+FFFD as code point
The current editors draft from 23 April 2018 does not require to escape
the REPLACEMENT CHARACTER (U+FFFD) as code point anymore.
https://drafts.csswg.org/cssom/#serialize-a-string
If the character is NULL (U+0000), then the REPLACEMENT CHARACTER
(U+FFFD).
https://www.w3.org/TR/2016/WD-cssom-1-
20160317/#serialize-a-string
If the character is NULL (U+0000), then the REPLACEMENT CHARACTER
(U+FFFD) escaped as code point.
Change-Id: Ia67e89b3c9561ca29e133d61a2eca8f3db306d8c
Bartosz Dziewoński [Wed, 16 May 2018 15:56:26 +0000 (17:56 +0200)]
resourceloader: Allow style-only modules to have deprecation warnings
The deprecation warning for the module 'mediawiki.ui' (used
e.g. on Special:UserLogin) is now actually shown.
Change-Id: If35a106c77622dbf7e8b5628fbea28f9e7ffd76d
jenkins-bot [Thu, 17 May 2018 07:54:30 +0000 (07:54 +0000)]
Merge "objectcache: add BagOStuff comment additions about access scope"
Aaron Schulz [Tue, 15 May 2018 22:33:38 +0000 (15:33 -0700)]
objectcache: add BagOStuff comment additions about access scope
Change-Id: Id23859a58ea3bde0338ba4d22ce12ffcbbf4480a
Timo Tijhof [Wed, 16 May 2018 22:57:25 +0000 (00:57 +0200)]
jquery.spinner: Remove obsolete IE8 support
This is a JS-only module that cannot be loaded on IE8 given
it's currently in Grade C (Grade A requires IE11).
Change-Id: I8707d7d2fd1d20c2b354c1589248ba7fda0d5e85
Timo Tijhof [Wed, 16 May 2018 22:55:42 +0000 (00:55 +0200)]
jquery.spinner: Move files to their own src/ directory
Reduce clutter in src/jquery/.
Bug: T193826
Change-Id: Idb9c7ab89a10728249b6051057b7edbf7efcca78
Timo Tijhof [Fri, 11 May 2018 15:18:23 +0000 (16:18 +0100)]
mediawiki.special.watchlist: Combine visitedstatus module
The 'mediawiki.special.changeslist.visitedstatus' module is only
used in SpecialWatchlist.php, which also always loads
'mediawiki.special.watchlist'. Thus, registering them as seperate
deliverables isn't needed.
In terms of size, they're also sufficiently small that even if
they could load under different conditions, it'd fine to load
as one module regardless.
Bug: T192623
Change-Id: I67d78083ce7a3000c05356e3eb0bcb98d0c1e990
Timo Tijhof [Fri, 11 May 2018 14:33:41 +0000 (15:33 +0100)]
mediawiki.special: Combine various tiny specialpage style modules
These stylesheets are sufficiently tiny that it doesn't make sense to
offer them the ability to be loaded separately from each other (saving
bytes in double-digits) at the cost of 1) exporting a dedicated registry
item with meta data shipped on every page view, 2) reduced cache re-use
from increased fragmentation.
Instead, move these to the 'mediawiki.special' style module.
The entries retain their own files to keep them as easy to find
and edit as before.
Where not already, ensure addModuleStyles() is always placed above
any addModules() call in the same method. The load order isn't
affected by the call order, but given blocking style-modules load
before async JS, it helps to order them in a way that visually
matches the effective load order (from top to bottom).
The following 7 modules were remove without deprecation:
1. "mediawiki.special.apisandbox.styles" (1 rule)
2. "mediawiki.special.edittags.styles" (3 rules)
3. "mediawiki.special.movePage.styles" (1 rule)
4. "mediawiki.special.pagesWithProp" (1 rule)
5. "mediawiki.special.upload.styles" (2 rules)
6. "mediawiki.special.watchlist.styles" (3 rules)
7. "mediawiki.special.comparepages.styles" (4 rules)
These module names were only used on the core classes loading them, and
aren't depended on outside core by module name, rather, extensions and
gadgets depend on the styles styles being loaded in a blocking manner on
these pages, which remains unaffected.
Bug: T192623
Change-Id: I6e663dc3c80c7104c9b9abdde44c654543185373
jenkins-bot [Wed, 16 May 2018 21:58:21 +0000 (21:58 +0000)]
Merge "Preferences: Fix timezone selectors"
Translation updater bot [Wed, 16 May 2018 20:47:27 +0000 (22:47 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id63d8cbbd732543020b777d068e00cc48657a6bf
Brad Jorsch [Wed, 4 Apr 2018 20:22:01 +0000 (16:22 -0400)]
API: Introduce "templated parameters"
With MCR coming up, ApiEditPage is going to need to be able to take
"text" and "contentmodel" parameters for each slot-role, and enumerating
such parameters for every possible slot would probably get rather
confusing as to what is required when, or at least long-winded in
repeating the exact same thing for every possible role.
So let's abstract it: we'll have an "editroles" parameter to specify which
slots are being edited, and ApiEditPage will just declare that
"text-{role}" and "contentmodel-{role}" parameters should exist for each
value of "editroles" in the submission.
Note this patch doesn't introduce anything that uses templated
parameters, just the functionality itself. For testing purposes you
might cherry pick I2d658e9a.
Bug: T174032
Change-Id: Ia19a1617b73067bfb1f0f16ccc57d471778b7361
Fomafix [Wed, 16 May 2018 18:10:05 +0000 (20:10 +0200)]
Names.php: Remove U+200E after autonym of language 'lki'
The LEFT-TO-RIGHT MARK (U+200E) after the RTL autonym of the language
'lki' was inserted in
04fcd20c.
The LRM causes wrong parentheses on mixed bidi sequences on Google
Chrome:
<span dir="rtl">({{#language:lki}}) Foo</span>
Change-Id: I9db84938e2b2142a3cb61955dfcbda790e6bbc5f
Ed Sanders [Wed, 16 May 2018 17:10:47 +0000 (18:10 +0100)]
Preferences: Fix timezone selectors
Change-Id: I6a3c4c811361188a9a288cf688f64155b48a906d
jenkins-bot [Wed, 16 May 2018 16:51:38 +0000 (16:51 +0000)]
Merge "parser: Don't unnecessarily add and remove a pipe "
jenkins-bot [Wed, 16 May 2018 16:40:07 +0000 (16:40 +0000)]
Merge "resourceloader: avoid use of $.globalEval in mediawiki.js"
Arlo Breault [Wed, 16 May 2018 15:29:10 +0000 (11:29 -0400)]
parser: Don't unnecessarily add and remove a pipe
Change-Id: I884ab88f9e8ac6f402cd4b3a54e33ccbd30637a2
Raymond [Wed, 16 May 2018 13:39:44 +0000 (15:39 +0200)]
Make Special:TrackingCategories sortable
https://de.wikipedia.org/wiki/Spezial:Tracking-Kategorien is longer
than 1 screen page
Change-Id: Idf2681960bc87f5f189b1666899bd609d74495bb
jenkins-bot [Wed, 16 May 2018 13:31:56 +0000 (13:31 +0000)]
Merge "Deprecate overriding SearchEngine::search*"
jenkins-bot [Wed, 16 May 2018 13:00:35 +0000 (13:00 +0000)]
Merge "Add missing __METHOD__ to onTransactionPreCommitOrIdle() caller"
jenkins-bot [Wed, 16 May 2018 12:53:05 +0000 (12:53 +0000)]
Merge "Deduplicate archive.ar_rev_id"
Brad Jorsch [Fri, 27 Apr 2018 17:10:36 +0000 (13:10 -0400)]
Deduplicate archive.ar_rev_id
Old bugs and such may have left the archive table with multiple rows
using the same ar_rev_id, or rows that also exist in the revision table.
These need to be cleaned up for MCR.
The maintenance script added here will delete rows that appear to be
duplicates of the same change, and will assign new IDs to rows that do
not appear to be duplicates.
Bug: T193180
Change-Id: I39b0825c9469e074ded3df33a4f06a1ef0edb494
jenkins-bot [Wed, 16 May 2018 07:58:23 +0000 (07:58 +0000)]
Merge "Special:PrefixIndex: Fix regression on prefix input value"
jenkins-bot [Wed, 16 May 2018 01:09:47 +0000 (01:09 +0000)]
Merge "mw.widgets.datetime.DateTimeInputWidget: Increase width"
Prateek Saxena [Tue, 15 May 2018 08:41:35 +0000 (14:11 +0530)]
mw.widgets.datetime.DateTimeInputWidget: Increase width
The condition to add extra width for 'strings' was already there
but was putting the same value for both. Increased from 1.15 to
1.25 per character for strings.
Bug: T193907
Change-Id: I474a8a84756d7222a47ef9d4f2d4b50050c4e20e
jenkins-bot [Tue, 15 May 2018 23:20:50 +0000 (23:20 +0000)]
Merge "registration: Improve duplicate config setting exception"
Aaron Schulz [Tue, 15 May 2018 19:52:19 +0000 (12:52 -0700)]
Add missing __METHOD__ to onTransactionPreCommitOrIdle() caller
Change-Id: I3722411dc63ff69253096f9c05e4fd1f130931ae
jenkins-bot [Tue, 15 May 2018 20:09:59 +0000 (20:09 +0000)]
Merge "Make internal search methods private for db implementations"