From: Dayllan Maza <dmaza@wikimedia.org>
Date: Tue, 19 Mar 2019 15:12:08 +0000 (-0400)
Subject: Remove block cookie stats measurement implementation
X-Git-Tag: 1.34.0-rc.0~2469^2
X-Git-Url: http://git.cyclocoop.org/%22.%24image2.%22?a=commitdiff_plain;h=dba3a36be43320f24cca24b5d6f6df1406ae8b29;p=lhc%2Fweb%2Fwiklou.git

Remove block cookie stats measurement implementation

When setting a cookie on IP blocks was rolled out we wanted to
add some form of measurement to keep an eye on it. This patch is
removing that implementation 'cause it is not needed anymore.

Bug: T218596
Change-Id: I33ee164157b539560a3d88c6f3018dc013218640
---

diff --git a/includes/user/User.php b/includes/user/User.php
index a5f48a7643..786f2882c4 100644
--- a/includes/user/User.php
+++ b/includes/user/User.php
@@ -1414,10 +1414,6 @@ class User implements IDBAccessObject, UserIdentity {
 				] );
 				if ( $shouldSetCookie ) {
 					$block->setCookie( $this->getRequest()->response() );
-
-					// temporary measure the use of cookies on ip blocks
-					$stats = MediaWikiServices::getInstance()->getStatsdDataFactory();
-					$stats->increment( 'block.ipblock.setCookie.success' );
 				}
 			} elseif ( $this->isLoggedIn() && $config->get( 'CookieSetOnAutoblock' ) ) {
 				$shouldSetCookie = $block->getType() === Block::TYPE_USER && $block->isAutoblocking();