From: Bartosz Dziewoński <matma.rex@gmail.com>
Date: Wed, 10 Jan 2018 22:08:02 +0000 (+0100)
Subject: SpecialProtectedpages: Remove options not used by HTMLForm
X-Git-Tag: 1.31.0-rc.0~916^2
X-Git-Url: http://git.cyclocoop.org/%22.%24image2.%22?a=commitdiff_plain;h=b8f51affc3f6b0ca1c673d104b12bf4ed211ddc1;p=lhc%2Fweb%2Fwiklou.git

SpecialProtectedpages: Remove options not used by HTMLForm

HTMLForm gets the selected value from the request. The values
specified in the form descriptor were never used. (You can specify a
default value, but that uses the 'default' key anyway.)

Change-Id: I095ee004cbe74470f33c72b391b22dd4395bff6e
---

diff --git a/includes/specials/SpecialProtectedpages.php b/includes/specials/SpecialProtectedpages.php
index 2ef9eafffb..ac34996283 100644
--- a/includes/specials/SpecialProtectedpages.php
+++ b/includes/specials/SpecialProtectedpages.php
@@ -101,7 +101,6 @@ class SpecialProtectedpages extends SpecialPage {
 				'name' => 'namespace',
 				'id' => 'namespace',
 				'cssclass' => 'namespaceselector',
-				'selected' => $namespace,
 				'all' => '',
 				'label' => $this->msg( 'namespace' )->text(),
 			],
@@ -112,21 +111,18 @@ class SpecialProtectedpages extends SpecialPage {
 				'label' => $this->msg( 'protectedpages-indef' )->text(),
 				'name' => 'indefonly',
 				'id' => 'indefonly',
-				'value' => $indefOnly
 			],
 			'cascadecheck' => [
 				'type' => 'check',
 				'label' => $this->msg( 'protectedpages-cascade' )->text(),
 				'name' => 'cascadeonly',
 				'id' => 'cascadeonly',
-				'value' => $cascadeOnly
 			],
 			'redirectcheck' => [
 				'type' => 'check',
 				'label' => $this->msg( 'protectedpages-noredirect' )->text(),
 				'name' => 'noredirect',
 				'id' => 'noredirect',
-				'value' => $noRedirect,
 			],
 			'sizelimit' => [
 				'class' => 'HTMLSizeFilterField',
@@ -166,7 +162,6 @@ class SpecialProtectedpages extends SpecialPage {
 		return [
 			'type' => 'select',
 			'options' => $options,
-			'value' => $pr_type,
 			'label' => $this->msg( 'restriction-type' )->text(),
 			'name' => $this->IdType,
 			'id' => $this->IdType,
@@ -200,7 +195,6 @@ class SpecialProtectedpages extends SpecialPage {
 		return [
 			'type' => 'select',
 			'options' => $options,
-			'value' => $pr_level,
 			'label' => $this->msg( 'restriction-level' )->text(),
 			'name' => $this->IdLevel,
 			'id' => $this->IdLevel