From: Tim Starling <tstarling@wikimedia.org>
Date: Mon, 3 Dec 2012 23:08:51 +0000 (+1100)
Subject: Make Language::isValidBuiltInCode() return bool
X-Git-Tag: 1.31.0-rc.0~21439
X-Git-Url: http://git.cyclocoop.org/%22.%24image2.%22?a=commitdiff_plain;h=79e9df0dc7c42ac5a5ea11ee450533a61cf004a7;p=lhc%2Fweb%2Fwiklou.git

Make Language::isValidBuiltInCode() return bool

Make Language::isValidBuiltInCode() return true or false, as
documented. Previously returned 0 or 1. Hacked around in I81ba3228.

Change-Id: Iaa7515095d687d745d878faaa957aae51737abf7
---

diff --git a/languages/Language.php b/languages/Language.php
index 7475d2fb60..a72f98f671 100644
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -277,7 +277,7 @@ class Language {
 			throw new MWException( __METHOD__ . " must be passed a string, $type given$addmsg" );
 		}
 
-		return preg_match( '/^[a-z0-9-]+$/i', $code );
+		return (bool)preg_match( '/^[a-z0-9-]+$/i', $code );
 	}
 
 	/**