From: Aaron Schulz <aaron@users.mediawiki.org>
Date: Sun, 9 Dec 2007 22:21:47 +0000 (+0000)
Subject: Make this more efficient. Just get all bot users from user_groups and flag rows by... 
X-Git-Tag: 1.31.0-rc.0~50475
X-Git-Url: http://git.cyclocoop.org/%22.%24image2.%22?a=commitdiff_plain;h=6872b812c974099bbe833ba4731dda72087d2c11;p=lhc%2Fweb%2Fwiklou.git

Make this more efficient. Just get all bot users from user_groups and flag rows by them. Same for autopatrol users.
---

diff --git a/maintenance/rebuildrecentchanges.inc b/maintenance/rebuildrecentchanges.inc
index 5101815385..c7d01d02db 100644
--- a/maintenance/rebuildrecentchanges.inc
+++ b/maintenance/rebuildrecentchanges.inc
@@ -121,14 +121,13 @@ function rebuildRecentChangesTablePass3()
 
 		print( "Flagging bot account edits...\n" );
 
-		# Find all users in RC that are bots
-		$sql = "SELECT DISTINCT rc_user FROM $recentchanges " .
-			"LEFT JOIN $usergroups ON rc_user=ug_user " . 
+		# Find all users that are bots
+		$sql = "SELECT DISTINCT ug_user FROM $usergroups " .
 			"WHERE ug_group IN($botwhere)";
 		$res = $dbw->query( $sql, DB_MASTER );
 
 		while( $obj = $dbw->fetchObject( $res ) ) {
-			$botusers[] = $obj->rc_user;
+			$botusers[] = $obj->ug_user;
 		}
 		# Fill in the rc_bot field
 		if( !empty($botusers) ) {
@@ -146,13 +145,12 @@ function rebuildRecentChangesTablePass3()
 		print( "Flagging auto-patrolled edits...\n" );
 
 		# Find all users in RC with autopatrol rights
-		$sql = "SELECT DISTINCT rc_user FROM $recentchanges " .
-			"LEFT JOIN $usergroups ON rc_user=ug_user " . 
+		$sql = "SELECT DISTINCT ug_user FROM $usergroups " .
 			"WHERE ug_group IN($patrolwhere)";
 		$res = $dbw->query( $sql, DB_MASTER );
 
 		while( $obj = $dbw->fetchObject( $res ) ) {
-			$patrolusers[] = $obj->rc_user;
+			$patrolusers[] = $obj->ug_user;
 		}
 		
 		# Fill in the rc_patrolled field