From: Elliott Eggleston <ejegg@ejegg.com>
Date: Wed, 27 Feb 2019 15:48:58 +0000 (-0500)
Subject: Fix warning on QUnit modules without dependencies
X-Git-Tag: 1.34.0-rc.0~2709
X-Git-Url: http://git.cyclocoop.org/%22.%24image2.%22?a=commitdiff_plain;h=667ef8fa62c23078c729d1577954e277c9a8835f;p=lhc%2Fweb%2Fwiklou.git

Fix warning on QUnit modules without dependencies

Check if $module['dependencies'] is set before checking whether
it's a string.

Change-Id: I9ece83d4ec92d0d3a41a1c6863492e646f011eab
---

diff --git a/includes/resourceloader/ResourceLoader.php b/includes/resourceloader/ResourceLoader.php
index 415808212d..3d1335049b 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -424,7 +424,7 @@ class ResourceLoader implements LoggerAwareInterface {
 		// Add the QUnit testrunner as implicit dependency to extension test suites.
 		foreach ( $testModules['qunit'] as &$module ) {
 			// Shuck any single-module dependency as an array
-			if ( is_string( $module['dependencies'] ) ) {
+			if ( isset( $module['dependencies'] ) && is_string( $module['dependencies'] ) ) {
 				$module['dependencies'] = [ $module['dependencies'] ];
 			}