From: Platonides Date: Wed, 20 Jul 2011 15:13:58 +0000 (+0000) Subject: Fixup r89029. You don't include the brackets in the method name! X-Git-Tag: 1.31.0-rc.0~28723 X-Git-Url: http://git.cyclocoop.org/%22.%24image2.%22?a=commitdiff_plain;h=36edac0170d64e6a8a7a7a5afe3debf90bce1913;p=lhc%2Fweb%2Fwiklou.git Fixup r89029. You don't include the brackets in the method name! --ta línea y las que están debajo serán ignoradas-- M includes/media/SVGMetadataExtractor.php M tests/phpunit/includes/media/SVGMetadataExtractorTest.php --- diff --git a/includes/media/SVGMetadataExtractor.php b/includes/media/SVGMetadataExtractor.php index 97c468c7aa..791c5105c3 100644 --- a/includes/media/SVGMetadataExtractor.php +++ b/includes/media/SVGMetadataExtractor.php @@ -177,7 +177,7 @@ class SVGReader { return; } // TODO: find and store type of xml snippet. metadata['metadataType'] = "rdf" - if( method_exists( $this->reader, 'readInnerXML()' ) ) { + if( method_exists( $this->reader, 'readInnerXML' ) ) { $this->metadata[$metafield] = trim( $this->reader->readInnerXML() ); } else { throw new MWException( "The PHP XMLReader extension does not come with readInnerXML() method. Your libxml is probably out of date (need 2.6.20 or later)." ); diff --git a/tests/phpunit/includes/media/SVGMetadataExtractorTest.php b/tests/phpunit/includes/media/SVGMetadataExtractorTest.php index 07ab4c1581..6979ed017e 100644 --- a/tests/phpunit/includes/media/SVGMetadataExtractorTest.php +++ b/tests/phpunit/includes/media/SVGMetadataExtractorTest.php @@ -18,7 +18,7 @@ class SVGMetadataExtractorTest extends MediaWikiTestCase { */ function testGetXMLMetadata( $infile, $expected ) { $r = new XMLReader(); - if( !method_exists( $r, 'readInnerXML()' ) ) { + if( !method_exists( $r, 'readInnerXML' ) ) { $this->markTestSkipped( 'XMLReader::readInnerXML() does not exist (libxml >2.6.20 needed).' ); return; }