From: Bartosz Dziewoński <matma.rex@gmail.com>
Date: Sun, 17 Aug 2014 22:04:57 +0000 (+0200)
Subject: Remove EnhancedChangesList::arrow() and friends
X-Git-Tag: 1.31.0-rc.0~14395^2
X-Git-Url: http://git.cyclocoop.org/%22.%24image2.%22?a=commitdiff_plain;h=07aef8f753be6b0860a855eeecb7f0f1a66ce9d9;p=lhc%2Fweb%2Fwiklou.git

Remove EnhancedChangesList::arrow() and friends

Not used in core, the only usage outside removed in Ieb5bb6f9.

Also removed two now-unused files from skins/common/.

Bug: 69675
Change-Id: Ia0e9fc2af25af903db085f2a05c04dcd9aff213e
---

diff --git a/RELEASE-NOTES-1.24 b/RELEASE-NOTES-1.24
index 30d59bad16..d5446ae9f6 100644
--- a/RELEASE-NOTES-1.24
+++ b/RELEASE-NOTES-1.24
@@ -333,6 +333,7 @@ changes to languages because of Bugzilla reports.
 * Action::checkCanExecute() no longer has a return value.
 * Removed cleanupForIRC(), loadFromCurRow(), newFromCurRow(), notifyRC2UDP()
   and sendToUDP() from RecentChange.php. (deprecated since 1.22)
+* Removed EnhancedChangesList::arrow(), sideArrow(), downArrow(), spacerArrow().
 
 ==== Renamed classes ====
 * CLDRPluralRuleConverter_Expression to CLDRPluralRuleConverterExpression
diff --git a/includes/changes/EnhancedChangesList.php b/includes/changes/EnhancedChangesList.php
index b471ea5ebe..82e36d95bf 100644
--- a/includes/changes/EnhancedChangesList.php
+++ b/includes/changes/EnhancedChangesList.php
@@ -474,50 +474,6 @@ class EnhancedChangesList extends ChangesList {
 		return $r;
 	}
 
-	/**
-	 * Generate HTML for an arrow or placeholder graphic
-	 * @param string $dir One of '', 'd', 'l', 'r'
-	 * @param string $alt
-	 * @param string $title
-	 * @return string HTML "<img>" tag
-	 */
-	protected function arrow( $dir, $alt = '', $title = '' ) {
-		global $wgStylePath;
-		$encUrl = htmlspecialchars( $wgStylePath . '/common/images/Arr_' . $dir . '.png' );
-		$encAlt = htmlspecialchars( $alt );
-		$encTitle = htmlspecialchars( $title );
-
-		return "<img src=\"$encUrl\" width=\"12\" height=\"12\" alt=\"$encAlt\" title=\"$encTitle\" />";
-	}
-
-	/**
-	 * Generate HTML for a right- or left-facing arrow,
-	 * depending on language direction.
-	 * @return string HTML "<img>" tag
-	 */
-	protected function sideArrow() {
-		$dir = $this->getLanguage()->isRTL() ? 'l' : 'r';
-
-		return $this->arrow( $dir, '+', $this->msg( 'rc-enhanced-expand' )->text() );
-	}
-
-	/**
-	 * Generate HTML for a down-facing arrow
-	 * depending on language direction.
-	 * @return string HTML "<img>" tag
-	 */
-	protected function downArrow() {
-		return $this->arrow( 'd', '-', $this->msg( 'rc-enhanced-hide' )->text() );
-	}
-
-	/**
-	 * Generate HTML for a spacer image
-	 * @return string HTML "<img>" tag
-	 */
-	protected function spacerArrow() {
-		return $this->arrow( '', codepointToUtf8( 0xa0 ) ); // non-breaking space
-	}
-
 	/**
 	 * Enhanced RC ungrouped line.
 	 *
diff --git a/skins/common/images/Arr_l.png b/skins/common/images/Arr_l.png
deleted file mode 100644
index 2246254f42..0000000000
Binary files a/skins/common/images/Arr_l.png and /dev/null differ
diff --git a/skins/common/images/Arr_r.png b/skins/common/images/Arr_r.png
deleted file mode 100644
index 467a555a4d..0000000000
Binary files a/skins/common/images/Arr_r.png and /dev/null differ