Revert r42584 "Hook SkinTemplateTabAction now passes $title by reference allowing...

$title is used previous to this call, so that isn't an appropriate place to change it.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 9fbe9c5..c431f84 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -175,8 +175,6 @@ The following extensions are migrated into MediaWiki 1.14:
 * Special:Wanted templates special page added to display missing templates
   linked from articles
 * Make search matches bold only, not red as well
-* Hook SkinTemplateTabAction now passes $title by reference allowing it to be 
-  changed by extensions.
 * Added 'UserRights::showEditUserGroupsForm' hook to allow extensions to alter
   the groups that the user can be added to or removed from in Special:UserRights
 

diff --git a/docs/hooks.txt b/docs/hooks.txt
index b4ea587..2c8e174 100644 (file)
--- a/docs/hooks.txt
+++ b/docs/hooks.txt
@@ -1175,7 +1175,7 @@ $out: Css to return
 'SkinTemplateTabAction': Override SkinTemplate::tabAction().
        You can either create your own array, or alter the parameters for the normal one.
 &$this:     The SkinTemplate instance.
-&$title:     Title instance for the page.
+$title:     Title instance for the page.
 $message:   Visible label of tab.
 $selected:  Whether this is a selected tab.
 $checkEdit: Whether or not the action=edit query should be added if appropriate.

diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php
index cae4073..33307e3 100644 (file)
--- a/includes/SkinTemplate.php
+++ b/includes/SkinTemplate.php
@@ -608,7 +608,7 @@ class SkinTemplate extends Skin {
 
                $result = array();
                if( !wfRunHooks('SkinTemplateTabAction', array(&$this,
-                               &$title, $message, $selected, $checkEdit,
+                               $title, $message, $selected, $checkEdit,
                                &$classes, &$query, &$text, &$result)) ) {
                        return $result;
                }