Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions
authorBartosz Dziewoński <matma.rex@gmail.com>
Thu, 18 Sep 2014 14:49:08 +0000 (16:49 +0200)
committerKrinkle <krinklemail@gmail.com>
Sat, 20 Sep 2014 20:28:22 +0000 (20:28 +0000)
commitbf1168b8cde7145ce4c85ba9bcb765494c288823
tree295738f02431371946095afcba554d7504b4ca91
parent900b772ed89492be9833a4c7f6570c0dea49cfb4
Fix CSSJanus flipping in LESS mixins and remove broken custom LESS functions

Custom LESS functions are problematic for us for a number of reasons,
as outlined by Timo on bug 67368. We should get rid of them.

The only use case was implementing CSSMin data: URI embedding in LESS,
which used to be impossible due to lessc not preserving comments (bug
54673). However, thanks to new syntax added in f3779e06 we can insert
the annotations in such a way that the compiler won't mess with them.
The same technique is used in OOjs UI since 584ed144.

The LESS-function-based embedding implementation also meant that we
were unable to flip images for RTL (bug 66091 and friends: bug 66773,
bug 68326). The annotation one doesn't have this limitation.

Bug: 67368
Bug: 66091
Bug: 66773
Bug: 68326
Change-Id: I3062346ed63272a1c22b5df27b4cc1de2a699d9a
RELEASE-NOTES-1.24
includes/AutoLoader.php
includes/DefaultSettings.php
includes/installer/Installer.php
includes/resourceloader/ResourceLoaderLESSFunctions.php [deleted file]
resources/src/mediawiki.less/mediawiki.mixins.less
tests/phpunit/includes/resourceloader/ResourceLoaderLESSTest.php [deleted file]
tests/phpunit/includes/resourceloader/fixtures/001-embeddable.css [deleted file]
tests/phpunit/includes/resourceloader/fixtures/001-embeddable.less [deleted file]