From dd724a817b1f0360d470030a0d502ace15387ffa Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Mon, 31 Mar 2008 18:01:39 +0000 Subject: [PATCH] Return '' to avoid vague cryptic error message when a user lacks permissions --- includes/DifferenceEngine.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includes/DifferenceEngine.php b/includes/DifferenceEngine.php index 0671fa0057..ee870225bd 100644 --- a/includes/DifferenceEngine.php +++ b/includes/DifferenceEngine.php @@ -426,9 +426,9 @@ CONTROL; wfProfileIn( $fname ); // Check if the diff should be hidden from this user if ( $this->mOldRev && !$this->mOldRev->userCan(Revision::DELETED_TEXT) ) { - return false; + return ''; } else if ( $this->mNewRev && !$this->mNewRev->userCan(Revision::DELETED_TEXT) ) { - return false; + return ''; } // Cacheable? $key = false; -- 2.20.1