From c5b1edbb07e58dd0e466639782a82dd1db715376 Mon Sep 17 00:00:00 2001 From: Rob Church Date: Thu, 21 Jun 2007 11:50:15 +0000 Subject: [PATCH] Minor code refactoring --- includes/SpecialListusers.php | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/includes/SpecialListusers.php b/includes/SpecialListusers.php index 293d10d6cb..7879f7298a 100644 --- a/includes/SpecialListusers.php +++ b/includes/SpecialListusers.php @@ -122,31 +122,23 @@ class UsersPager extends AlphabeticPager { $out = Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript ) ) . '
' . Xml::element( 'legend', array(), wfMsg( 'listusers' ) ); - - # Title $out .= Xml::hidden( 'title', $self->getPrefixedUrl() ); # Username field $out .= Xml::label( wfMsg( 'listusersfrom' ), 'offset' ) . ' ' . Xml::input( 'username', 20, $this->requestedUser, array( 'id' => 'offset' ) ) . ' '; - if( $this->mLimit ) - $out .= Xml::hidden( 'limit', $this->mLimit ); - # Group drop-down list $out .= Xml::label( wfMsg( 'group' ), 'group' ) . ' ' . Xml::openElement('select', array( 'name' => 'group', 'id' => 'group' ) ) . - Xml::option( wfMsg( 'group-all' ), '' ); # Item for "all groups" - - $groups = User::getAllGroups(); - foreach( $groups as $group ) { - $attribs = array( 'value' => $group ); - $attribs['selected'] = ( $group == $this->requestedGroup ) ? 'selected' : ''; - $out .= Xml::option( User::getGroupName( $group ), $attribs['value'], $attribs['selected'] ); - } + Xml::option( wfMsg( 'group-all' ), '' ); + foreach( User::getAllGroups() as $group ) + $out .= Xml::option( User::getGroupName( $group ), $group, $group == $this->requestedGroup ); $out .= Xml::closeElement( 'select' ) . ' '; # Submit button and form bottom + if( $this->mLimit ) + $out .= Xml::hidden( 'limit', $this->mLimit ); $out .= Xml::submitButton( wfMsg( 'allpagessubmit' ) ) . '
' . Xml::closeElement( 'form' ); -- 2.20.1