From 941e3c66ba67863278bc11b9c0a23e47abfadefe Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Thu, 14 Jun 2018 23:09:52 +0100 Subject: [PATCH] resourceloader: Un-deprecate ClientHtml::setModuleStyles() This follows 80e5b160e0985, which introduced ClientHtml::setModuleScripts() and setModuleStyles() with @deprecated marks. There was a vague intention to remove both at some point. The commit did not deprecate the related methods in OutputPage and ParserOutput. The plan that eventually formed at T188689 was to keep methods relating to "setModuleStyles" for the time being, and focus first on the removal of the methods relating to "setModuleScripts". The latter since been properly marked as deprecated and removal is scheduled for 1.33. There is no current plan to deprecate/remove addModuleStyles from OutputPage and ParserOutput. As such, the internal helper method that makes those possible, probably shouldn't me marked as deprecated. Bug: T188689 Change-Id: Ia36c057b73fe834bcbb2e3e8993d1a793a12ab72 --- includes/resourceloader/ResourceLoaderClientHtml.php | 1 - 1 file changed, 1 deletion(-) diff --git a/includes/resourceloader/ResourceLoaderClientHtml.php b/includes/resourceloader/ResourceLoaderClientHtml.php index b9ff7325ac..20faf8b175 100644 --- a/includes/resourceloader/ResourceLoaderClientHtml.php +++ b/includes/resourceloader/ResourceLoaderClientHtml.php @@ -95,7 +95,6 @@ class ResourceLoaderClientHtml { /** * Ensure the styles of one or more modules are loaded. * - * @deprecated since 1.28 * @param array $modules Array of module names */ public function setModuleStyles( array $modules ) { -- 2.20.1