From 4bff6f1558ce72cdd3299f8b5dbfc893b80cb217 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 5 Apr 2019 01:09:30 +0100 Subject: [PATCH] jobqueue: Document Title as valid param type for compat MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Follows-up 9b4938c40d02c. This should fix build failures that are preventing merges in repos where Phan is finding Job::__construct(string, Title) where it currently fails as follows: CompileArticleMetadataJob.php:11 PhanTypeMismatchArgument Argument 2 (params) is …\Title|string but \Job::__construct() takes array As Phan is reading the php doc I guess. Change-Id: I94b442f06b6858d136546bf22f2465cf8f071ab0 --- includes/jobqueue/Job.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/jobqueue/Job.php b/includes/jobqueue/Job.php index 22ff4468dd..0b5e62df89 100644 --- a/includes/jobqueue/Job.php +++ b/includes/jobqueue/Job.php @@ -65,7 +65,7 @@ abstract class Job implements IJobSpecification { * Create the appropriate object to handle a specific job * * @param string $command Job command - * @param array $params Job parameters + * @param array|Title $params Job parameters * @throws InvalidArgumentException * @return Job */ -- 2.20.1