From 3615dbda36112adb6efb65199aee0f8ad2c2510c Mon Sep 17 00:00:00 2001 From: Alex Ivanov Date: Mon, 18 Nov 2013 23:22:07 +0200 Subject: [PATCH] API: Add default setting for OpenSearch limit parameter This is done as part of a GCI 2013 task. Bug: 30089 Change-Id: I4c1a850520976a5b8b433feee4807c5f6960e3ac --- RELEASE-NOTES-1.23 | 2 ++ includes/DefaultSettings.php | 6 ++++++ includes/api/ApiOpenSearch.php | 4 +++- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES-1.23 b/RELEASE-NOTES-1.23 index c5791ba0fd..5c7edc8b39 100644 --- a/RELEASE-NOTES-1.23 +++ b/RELEASE-NOTES-1.23 @@ -37,6 +37,8 @@ production. * (bug 56033) Add content model to the page information. * Added Article::MissingArticleConditions hook to give extensions a chance to hide their (unrelated) log entries. +* Added $wgOpenSearchDefaultLimit defining the default number of entries to show + on action=opensearch API call. === Bug fixes in 1.23 === * (bug 41759) The "updated since last visit" markers (on history pages, recent diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index d428910ad9..8faae6008c 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -5236,6 +5236,12 @@ $wgOpenSearchTemplate = false; */ $wgEnableOpenSearchSuggest = true; +/** + * Integer defining default number of entries to show on + * OpenSearch call. + */ +$wgOpenSearchDefaultLimit = 10; + /** * Expiry time for search suggestion responses */ diff --git a/includes/api/ApiOpenSearch.php b/includes/api/ApiOpenSearch.php index 433b743a72..4b8578bd59 100644 --- a/includes/api/ApiOpenSearch.php +++ b/includes/api/ApiOpenSearch.php @@ -90,10 +90,12 @@ class ApiOpenSearch extends ApiBase { } public function getAllowedParams() { + global $wgOpenSearchDefaultLimit; + return array( 'search' => null, 'limit' => array( - ApiBase::PARAM_DFLT => 10, + ApiBase::PARAM_DFLT => $wgOpenSearchDefaultLimit, ApiBase::PARAM_TYPE => 'limit', ApiBase::PARAM_MIN => 1, ApiBase::PARAM_MAX => 100, -- 2.20.1