From 110ca3e706f23908e6d13ea8625970cb703ee57c Mon Sep 17 00:00:00 2001
From: jdlrobson <jdlrobson@gmail.com>
Date: Tue, 26 Mar 2019 11:51:39 -0700
Subject: [PATCH] mediawiki.special.changeslist is a skinStyle module

Allow skins full control over styling changelists
Several styles relating to unicode-bidi and client-js are
made mandatory.

The mw-changeslist-legend rules I will review separately with
Volker to determine whether they should be mandatory too, once
I'm more informed about how Minerva might use them.

Change-Id: I92c5fdc33b50771bd45e4945185c27395c608eb4
---
 resources/Resources.php                       |  5 +++-
 .../changeslist.less                          | 24 ++++++++++++++++++
 .../default.less}                             | 25 -------------------
 3 files changed, 28 insertions(+), 26 deletions(-)
 create mode 100644 resources/src/mediawiki.special.changeslist/changeslist.less
 rename resources/src/{mediawiki.special.changeslist.less => mediawiki.special.changeslist/default.less} (69%)

diff --git a/resources/Resources.php b/resources/Resources.php
index b2d0ad26c6..cb32340f11 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -2147,7 +2147,10 @@ return [
 	],
 	'mediawiki.special.changeslist' => [
 		'styles' => [
-			'resources/src/mediawiki.special.changeslist.less',
+			'resources/src/mediawiki.special.changeslist/changeslist.less'
+		],
+		'skinStyles' => [
+			'default' => 'resources/src/mediawiki.special.changeslist/default.less',
 		],
 		'targets' => [ 'desktop', 'mobile' ],
 	],
diff --git a/resources/src/mediawiki.special.changeslist/changeslist.less b/resources/src/mediawiki.special.changeslist/changeslist.less
new file mode 100644
index 0000000000..f24d1f2352
--- /dev/null
+++ b/resources/src/mediawiki.special.changeslist/changeslist.less
@@ -0,0 +1,24 @@
+.client-js .mw-input-hidden {
+	display: none;
+}
+
+/*
+ * Titles, including username links, and also tag names
+ * are prone to getting jumbled up
+ * with other titles, usernames, etc. in mixed RTL-LTR environment.
+ */
+.mw-changeslist .mw-tag-marker,
+.mw-changeslist .mw-title {
+	unicode-bidi: embed;
+}
+
+/*
+ * Bidi-isolate these numbers.
+ * See https://phabricator.wikimedia.org/T93484
+ */
+.mw-plusminus-pos,
+.mw-plusminus-neg,
+.mw-plusminus-null {
+	unicode-bidi: -moz-isolate;
+	unicode-bidi: isolate;
+}
diff --git a/resources/src/mediawiki.special.changeslist.less b/resources/src/mediawiki.special.changeslist/default.less
similarity index 69%
rename from resources/src/mediawiki.special.changeslist.less
rename to resources/src/mediawiki.special.changeslist/default.less
index c78354b2b1..203beee349 100644
--- a/resources/src/mediawiki.special.changeslist.less
+++ b/resources/src/mediawiki.special.changeslist/default.less
@@ -2,10 +2,6 @@
  * Styling for Special:Watchlist and Special:RecentChanges
  */
 
-.client-js .mw-input-hidden {
-	display: none;
-}
-
 /* Make sure namespace label is aligned correctly on mobile when checkboxes are displayed */
 .mw-label.mw-namespace-label {
 	vertical-align: top;
@@ -15,16 +11,6 @@
 	font-weight: bold;
 }
 
-/*
- * Titles, including username links, and also tag names
- * are prone to getting jumbled up
- * with other titles, usernames, etc. in mixed RTL-LTR environment.
- */
-.mw-changeslist .mw-tag-marker,
-.mw-changeslist .mw-title {
-	unicode-bidi: embed;
-}
-
 /* Colored watchlist and recent changes numbers */
 .mw-plusminus-pos {
 	color: #006400; /* dark green */
@@ -38,17 +24,6 @@
 	color: #a2a9b1; /* gray */
 }
 
-/*
- * Bidi-isolate these numbers.
- * See https://phabricator.wikimedia.org/T93484
- */
-.mw-plusminus-pos,
-.mw-plusminus-neg,
-.mw-plusminus-null {
-	unicode-bidi: -moz-isolate;
-	unicode-bidi: isolate;
-}
-
 /* Prevent FOUC if legend is initially collapsed */
 .mw-changeslist-legend.mw-collapsed .mw-collapsible-content {
 	display: none;
-- 
2.20.1