From 0278585c72ae738a6be162206ecaf4e06ecbf917 Mon Sep 17 00:00:00 2001
From: Aryeh Gregor <ayg@aryeh.name>
Date: Fri, 10 Aug 2018 11:26:57 +0300
Subject: [PATCH] Improve MediaWikiVersionFetcherTest

Let's test that the value is actually correct, not just that it's a
string.

Change-Id: I4d76a48696a838ee6882ffce10d024f7518dcd4a
---
 tests/phpunit/includes/MediaWikiVersionFetcherTest.php | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/phpunit/includes/MediaWikiVersionFetcherTest.php b/tests/phpunit/includes/MediaWikiVersionFetcherTest.php
index 87a7dffde1..cb234b2c31 100644
--- a/tests/phpunit/includes/MediaWikiVersionFetcherTest.php
+++ b/tests/phpunit/includes/MediaWikiVersionFetcherTest.php
@@ -10,13 +10,14 @@
  *
  * @author Jeroen De Dauw < jeroendedauw@gmail.com >
  */
-class MediaWikiVersionFetcherTest extends PHPUnit\Framework\TestCase {
+class MediaWikiVersionFetcherTest extends MediaWikiTestCase {
 
 	use MediaWikiCoversValidator;
 
 	public function testReturnsResult() {
+		global $wgVersion;
 		$versionFetcher = new MediaWikiVersionFetcher();
-		$this->assertInternalType( 'string', $versionFetcher->fetchVersion() );
+		$this->assertSame( $wgVersion, $versionFetcher->fetchVersion() );
 	}
 
 }
-- 
2.20.1