MarcoAurelio [Fri, 2 Feb 2018 22:34:17 +0000 (23:34 +0100)]
Add Siberian Tatar (sty) language
Bug: T186359
Change-Id: Iecfdda0bcfbcc491565b6de36046791a3e5c540a
jenkins-bot [Fri, 2 Feb 2018 23:54:27 +0000 (23:54 +0000)]
Merge "JavaScriptMinifier: Fix "Uninitialized offset" in regexp char class parsing"
jenkins-bot [Fri, 2 Feb 2018 23:32:27 +0000 (23:32 +0000)]
Merge "skins: Deprecate QuickTemplate::setTranslator and MediaWikiI18N::set"
jenkins-bot [Fri, 2 Feb 2018 23:28:14 +0000 (23:28 +0000)]
Merge "mediawiki.api.edit: Fix errors"
jenkins-bot [Fri, 2 Feb 2018 21:38:29 +0000 (21:38 +0000)]
Merge "Do not concat exception class name in Timestamp compat"
Fomafix [Mon, 29 Jan 2018 08:38:35 +0000 (09:38 +0100)]
mediawiki.api.edit: Fix errors
* Use title = String( title ) to support title with type mw.Title also on the
POST request.
* Use titles: [ title ] instead of titles: title to ensure that a '|' in the
title is not interpreted as multi value separator.
* Reject on invalid === true to prevent processing invalid titles.
Change-Id: Ia6a3d9b4b658a89f8969f0d64bf06a53638eb553
jenkins-bot [Fri, 2 Feb 2018 21:05:40 +0000 (21:05 +0000)]
Merge "Remove Skin::showIPinHeader(), deprecated since 1.27"
jenkins-bot [Fri, 2 Feb 2018 21:03:15 +0000 (21:03 +0000)]
Merge "OutputPage: Remove methods deprecated in 1.27 or before"
Translation updater bot [Fri, 2 Feb 2018 20:55:25 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Id6a360383034c78b0723dc7896640d365add4ab5
Timo Tijhof [Fri, 2 Feb 2018 20:37:46 +0000 (12:37 -0800)]
skins: Deprecate QuickTemplate::setTranslator and MediaWikiI18N::set
These methods have no callers anywhere in Wikimedia Git.
Deprecate it now, remove in MediaWiki 1.32.
This is part of removing the legacy MediaWikiI18N class.
Bug: T186090
Change-Id: Ie2ca6a4b4f4481dc5cd81e7ed5543a05ee611f42
James D. Forrester [Wed, 31 Jan 2018 22:32:41 +0000 (14:32 -0800)]
Remove Skin::showIPinHeader(), deprecated since 1.27
Change-Id: I46e5f84512413c9c4fbdfa43abf8908d6a6e11be
James D. Forrester [Wed, 31 Jan 2018 21:33:06 +0000 (13:33 -0800)]
OutputPage: Remove methods deprecated in 1.27 or before
Eighteen uses of readOnlyPage and three of addExtensionStyle; all
have fixes awaiting merge. Marking as dependent on the only one
in a Wikimedia-deployed extension.
Depends-On: Ib3ea649bc68dd0edc025133721b46996d1e8901f
Change-Id: I636ebc7dead55f1ae654a13d3b6ebb023ecfe8e1
jenkins-bot [Fri, 2 Feb 2018 20:31:02 +0000 (20:31 +0000)]
Merge "SpecialPage: Hard deprecate getTitle, deprecated since 1.23"
jenkins-bot [Fri, 2 Feb 2018 19:46:37 +0000 (19:46 +0000)]
Merge "Add tablesUsed to RevisionStoreDbTest"
addshore [Mon, 29 Jan 2018 17:08:58 +0000 (17:08 +0000)]
Add tablesUsed to RevisionStoreDbTest
Bug: T183777
Change-Id: Ie8bc2a9aca341a44c22828c9e9c3a7f89c7f87cd
jenkins-bot [Fri, 2 Feb 2018 18:41:07 +0000 (18:41 +0000)]
Merge "SiteStats row initialization cleanups"
jenkins-bot [Fri, 2 Feb 2018 18:41:02 +0000 (18:41 +0000)]
Merge "Remove wrapclass from parser cache key"
WMDE-Fisch [Thu, 1 Feb 2018 17:27:07 +0000 (18:27 +0100)]
Do not concat exception class name in Timestamp compat
It seems this is not necessary and confused my IDE in thinking
'Exception' is an alias for TimestampException.
Given that we use a namespaced reference to the class,
ClassCollector still won't see it. Updated test to verify that.
Change-Id: I7c9258c5739a64959442af1296e2b93395260894
jenkins-bot [Fri, 2 Feb 2018 18:23:52 +0000 (18:23 +0000)]
Merge "mediawiki.api.category: Avoid exceptions"
jenkins-bot [Fri, 2 Feb 2018 16:58:28 +0000 (16:58 +0000)]
Merge "Throw exception if php-curl is missing"
jenkins-bot [Fri, 2 Feb 2018 16:36:59 +0000 (16:36 +0000)]
Merge "Print: pre-wrap <pre> elements"
Moritz Schubotz (physikerwelt) [Fri, 2 Feb 2018 15:37:00 +0000 (16:37 +0100)]
Throw exception if php-curl is missing
Currently MediaWiki just dies silently, if the php
curl extension is missing.
Throw an exception instead that redirects the admin to the appropriate help page.
Change-Id: I25edfcb34ee5451a742cac6ae099019a16f6c417
Fomafix [Mon, 29 Jan 2018 11:57:00 +0000 (12:57 +0100)]
mediawiki.api.category: Avoid exceptions
This change avoids some exceptions in processing the API response
* Ensure that a "|" in the title is not interpreted as multi value
separator.
* The key query is missing on empty title.
* The key query.pages is missing on title="#" or title="mw:".
Change-Id: Idc82412337d0733cc58a78b1e202f5fdfd8f31cd
Derk-Jan Hartman [Fri, 2 Feb 2018 14:24:26 +0000 (15:24 +0100)]
Print: pre-wrap <pre> elements
This seems to have been overlooked when T103780 was fixed during 1.26
Bug: T185129
Change-Id: I6f0068d66a5641c4f5092d5a2d0356c061fd2763
Aaron Schulz [Wed, 31 Jan 2018 21:39:44 +0000 (13:39 -0800)]
SiteStats row initialization cleanups
* Remove unreachable code (field cannot be both null and -1)
* Avoid PHP warnings during test runs in miser mode due to
the $row field being "false".
* Init the site_stats row in unit tests to unbreak miser mode.
Change-Id: Ieb45cb3068b71e01aa12c674e0bfcf13a7f2493c
jenkins-bot [Fri, 2 Feb 2018 04:25:46 +0000 (04:25 +0000)]
Merge "rdbms: set the schema in the LBFactory local domain"
jenkins-bot [Fri, 2 Feb 2018 04:22:05 +0000 (04:22 +0000)]
Merge "Shell: Set pipes to non-blocking"
jdlrobson [Fri, 18 Aug 2017 17:55:35 +0000 (12:55 -0500)]
Add mobile and desktop thresholds
This will allow us to centralise these values similar to tablet
device width and allow us to remove a Minerva/MobileFrontend
dependency
Going forward we will encourage explicitly tracked imports
deviceWidthTablet is retained for backwards compatibility
but on long term it should be imported directly from mediawiki.ui's
variables
Bug: T171365
Change-Id: Ib9f843147db4473ce5590741e0fb490384b0007e
jenkins-bot [Fri, 2 Feb 2018 04:04:13 +0000 (04:04 +0000)]
Merge "Make interim WAN cache key deactivation logic broader"
jenkins-bot [Fri, 2 Feb 2018 04:00:27 +0000 (04:00 +0000)]
Merge "rdbms: Bump TransactionProfiler log entries to WARNING"
Aaron Schulz [Wed, 31 Jan 2018 22:33:28 +0000 (14:33 -0800)]
rdbms: Bump TransactionProfiler log entries to WARNING
Change-Id: I4816cfb8c8cd3b8e3dd2fe10c028c4654cc82854
jenkins-bot [Fri, 2 Feb 2018 03:51:32 +0000 (03:51 +0000)]
Merge "deferred: Make MWCallableUpdate support a list of DB handles"
jenkins-bot [Fri, 2 Feb 2018 03:34:06 +0000 (03:34 +0000)]
Merge "objectcache: use region prefixes for mcrouter-backed WAN cache"
jenkins-bot [Fri, 2 Feb 2018 02:45:27 +0000 (02:45 +0000)]
Merge "Warn if stateful ParserOutput transforms are used"
jenkins-bot [Fri, 2 Feb 2018 02:31:24 +0000 (02:31 +0000)]
Merge "benchmarks: Fix divide by zero in Benchmarker"
Brad Jorsch [Thu, 1 Feb 2018 21:26:09 +0000 (16:26 -0500)]
benchmarks: Fix divide by zero in Benchmarker
Follows-up
593442683dc471c0.
Bug: T186269
Change-Id: I011a8614e0acf489daf5bd9dcb932e920b995092
jenkins-bot [Fri, 2 Feb 2018 01:27:33 +0000 (01:27 +0000)]
Merge "qunit: Test `before` and `after` hooks in QUnit testrunner"
jenkins-bot [Fri, 2 Feb 2018 01:24:12 +0000 (01:24 +0000)]
Merge "qunit: Refactor and simplify testrunner to fix nested modules"
jenkins-bot [Fri, 2 Feb 2018 01:18:41 +0000 (01:18 +0000)]
Merge "Added letter Kra (ĸ) to special characters toolbar"
navisk13 [Tue, 30 Jan 2018 13:11:50 +0000 (18:41 +0530)]
Added letter Kra (ĸ) to special characters toolbar
Added 'Kra' to latin extended collection in the file /resources/src/mediawiki.language/specialcharacters.json
Bug: T185918
Change-Id: Ibc739297e5a1b8d109202477e1314cc3a0d6d5b4
Brad Jorsch [Fri, 22 Dec 2017 18:47:33 +0000 (13:47 -0500)]
Remove wrapclass from parser cache key
This will result in an exception from WikiPage::getParserOutput() if
anything was missed.
This also hard-deprecates ParserOptions::setWrapOutputClass( false )
Bug: T181846
Change-Id: Ica541e1f6b52f5eec6d28cff60ba64bf525258c7
Depends-On: Ie5d6c5ce34c05b8fe2353d3bb36b2a3a4166ec4b
Depends-On: Ibfaefde2f3811151ec712554cbc9cf2415ed017f
Depends-On: I55048bbae5d4d2d0c79c241c1784448b82db3bb4
Depends-On: I23a26ba0dfbe83007cd40e97d71a2139a5ecddc7
Depends-On: Ibc013a41f4a463f4014fbbce7ce27f8690161728
Depends-On: Ie936dff918dc0869503a924298b4580402038b52
Brad Jorsch [Fri, 22 Dec 2017 18:32:49 +0000 (13:32 -0500)]
Add 'unwrap' ParserOutput post-cache transform
And deprecate passing false for ParserOptions::setWrapOutputClass().
There are three cases for the Parser wrapper: the default
mw-parser-output, a custom wrapper, or no wrapper. As things currently
stand, we have to fragment the parser cache on each of these options,
which uses a nontrival amount of storage space (T167784).
Ideally we'd do all the wrapping as a post-cache transform, but
TemplateStyles needs to know the wrapper in use in order to properly
prefix its CSS rules (that's why we added the wrapper in the first
place). So, second best option is to make *un*wrapping be a post-cache
transform and make "custom wrapper" be uncacheable.
This patch does the first bit (unwrapping as a post-cache transform),
and a followup will do the second part once the deprecation process is
satisfied.
Bug: T181846
Change-Id: Iba16e78c41be992467101e7d83e9c3134765b101
Brad Jorsch [Thu, 1 Feb 2018 18:45:35 +0000 (13:45 -0500)]
Shell: Set pipes to non-blocking
The select(2) system call only guarantees a "sufficiently small write"
can be made without blocking. It doesn't define what that means.
And on Linux the read might block too in certain cases, although I don't
know if any of them can occur here.
Regardless, set all the pipes to non-blocking, which avoids the blocking
that's behind T184171.
And then, since a non-blocking read might validly return empty-string or
a non-blocking write might validly return 0, use feof() to check for EOF
and actually close the write pipe when it runs out of data.
Bug: T184171
Change-Id: I403235a328630112b6920905730f933777e2d453
Translation updater bot [Thu, 1 Feb 2018 20:56:02 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I3eb13a00f4f315cc23b29602a8ef1206f26065dc
Aaron Schulz [Tue, 5 Dec 2017 06:05:31 +0000 (22:05 -0800)]
objectcache: use region prefixes for mcrouter-backed WAN cache
This allows for mcrouter to have proper cross-DC and intra-DC timeouts.
Change-Id: If48f740f435d266a2050839f34611c0c8f36b3a7
jenkins-bot [Thu, 1 Feb 2018 17:43:10 +0000 (17:43 +0000)]
Merge "Add ability to proxy thumbnail requests to a service"
jenkins-bot [Thu, 1 Feb 2018 17:41:53 +0000 (17:41 +0000)]
Merge "Hygiene: Use “OOUI” as unified name in build and code documentation"
jenkins-bot [Thu, 1 Feb 2018 16:01:35 +0000 (16:01 +0000)]
Merge "Bump composer/spdx-licenses to 1.3.0"
jenkins-bot [Thu, 1 Feb 2018 15:33:24 +0000 (15:33 +0000)]
Merge "Fix jump-to-nav element overlap on RCFilters"
Thiemo Mättig [Thu, 1 Feb 2018 11:48:29 +0000 (12:48 +0100)]
Add missing PHPDoc block to DifferenceEngine::getParserOutput
Bug: T186163
Change-Id: Ifde6f8e458d90b1ec250dc4d587cd428717fe509
Aleksey Bekh-Ivanov (WMDE) [Wed, 2 Aug 2017 14:21:56 +0000 (16:21 +0200)]
qunit: Test `before` and `after` hooks in QUnit testrunner
Change-Id: Ib5b5d29e860d37dbec675e5d24c31b57c5e64102
Gilles Dubuc [Mon, 20 Nov 2017 06:57:29 +0000 (07:57 +0100)]
Add ability to proxy thumbnail requests to a service
Bug: T169144
Change-Id: I4af09a8b75e7158d6ff15f97e8f067b66ac33d5c
Stanislav Malyshev [Thu, 1 Feb 2018 07:05:20 +0000 (23:05 -0800)]
Fix invocation of MWHttpRequest::factory with one argument.
Change-Id: Ib96c2888a6fd91ca80c162a80d283f650d6fa4b9
Kunal Mehta [Thu, 1 Feb 2018 07:01:02 +0000 (23:01 -0800)]
Bump composer/spdx-licenses to 1.3.0
https://github.com/composer/spdx-licenses/compare/1.2.0...1.3.0
Change-Id: I41be6cecc1b322796ed448f664eb58642d7511ff
Volker E [Wed, 17 Jan 2018 07:04:01 +0000 (23:04 -0800)]
Hygiene: Use “OOUI” as unified name in build and code documentation
Bug: T182360
Change-Id: I981c574003fa505fe133be6da405e73330c4e9a1
Aaron Schulz [Tue, 23 Jan 2018 15:06:32 +0000 (16:06 +0100)]
deferred: Make MWCallableUpdate support a list of DB handles
Change-Id: I0371ecd20101c5e622497e5912676300b040865e
Aaron Schulz [Thu, 1 Feb 2018 00:47:09 +0000 (16:47 -0800)]
Make interim WAN cache key deactivation logic broader
* This is how it was before
d5aa846d8, which accidentally changed
the behavior. The WAN cache call in Setup.php was too coupled to
the ChronologyProtector cookies. It made the assumption that DB
positions and cookies are stored even when there are no replica
databases setup (which changed in that patch).
* Check the "UseDC" cookie instead, which is already set in exactly
the cases this logic should apply.
Bug: T185328
Change-Id: I4dd2a6ca6cdead0052d59be86e6030dbe01f141b
Timo Tijhof [Wed, 31 Jan 2018 21:05:09 +0000 (13:05 -0800)]
qunit: Refactor and simplify testrunner to fix nested modules
Follows-up
5a49381406,
43dc5c1539e88,
2454f51b2742dae.
* Merge the three QUnit.module extensions into one.
* Change makeSafeEnv() to use Object.create() instead of creating
a simplified objects so that other properties are still accessible.
The 'testrunner-nested > Dummy' test now actually runs,
previously it was lost.
Change-Id: Id4aeb93582f8cc73b0dffe768a7864002ec85deb
Timo Tijhof [Fri, 26 Jan 2018 18:16:13 +0000 (10:16 -0800)]
skins: Deprecate QuickTemplate::setRef()
Removed all use from core. It was only used in a handful of other
repos, most of which have been updated already.
Bug: T140664
Change-Id: I6b1ea3221022597ca38a5cd40eee040d34d1abb8
L10n-bot [Wed, 31 Jan 2018 20:55:05 +0000 (20:55 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Wed, 31 Jan 2018 20:54:53 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I6a6aa5aefc1fcc048d16bc4f509efdbfd6006ddc
jenkins-bot [Wed, 31 Jan 2018 20:53:36 +0000 (20:53 +0000)]
Merge "tests: Add @group and @covers to wfArrayFilterTest"
Timo Tijhof [Wed, 31 Jan 2018 20:14:02 +0000 (12:14 -0800)]
tests: Add @group and @covers to wfArrayFilterTest
Change-Id: I6565ad21b6d6e78d876f730596e213555143c3fc
jenkins-bot [Wed, 31 Jan 2018 18:47:59 +0000 (18:47 +0000)]
Merge "Rewrite pref cleanup script"
Aaron Schulz [Tue, 30 Jan 2018 03:09:07 +0000 (19:09 -0800)]
rdbms: set the schema in the LBFactory local domain
Also, enforce that new DB connection use the domain
schema as is the case with the DB name and table prefix.
The code worked previously since the local domain did not override
the schema in the server configuration arrays, so it happened not
to clobber the domain schema.
Lastly, fix unit test fatal in LBFactorySingle::forEachLB() when
called during LBFactorySingle::_destruct().
Change-Id: Ia9ddef0f21591d0c8b15f2947cd61569e3fec7a0
jenkins-bot [Wed, 31 Jan 2018 15:53:51 +0000 (15:53 +0000)]
Merge "jquery.textSelection: Remove code supporting IE 6 selection APIs"
jenkins-bot [Wed, 31 Jan 2018 15:53:28 +0000 (15:53 +0000)]
Merge "jquery.textSelection: Remove final remnants of WikiEditor iframe support"
jenkins-bot [Wed, 31 Jan 2018 14:51:26 +0000 (14:51 +0000)]
Merge "Move @group and @covers tags in tests close to class"
jenkins-bot [Wed, 31 Jan 2018 13:40:37 +0000 (13:40 +0000)]
Merge "resourceloader: Add minified version of mw.loader.implement() wrapper"
Bartosz Dziewoński [Wed, 31 Jan 2018 05:44:53 +0000 (06:44 +0100)]
jquery.textSelection: Remove code supporting IE 6 selection APIs
Removing all the code that uses the document.selection and
document.body.createTextRange() APIs, or that only runs if
these APIs are present (workarounds for old IE bugs).
These APIs were supported by Internet Explorer up to version 9
and by Opera up to version 10.5. More recent versions of both
browsers only support the standard selection APIs.
Bug: T186005
Change-Id: I32dc5a16b03cf1c2ea44f6c7361447607ccc7e62
Bartosz Dziewoński [Wed, 31 Jan 2018 05:37:54 +0000 (06:37 +0100)]
jquery.textSelection: Remove final remnants of WikiEditor iframe support
After WikiEditor's experimental iframe mode was removed in
952d6b9d8fc1d4ac606b6f8d0a3341ba7ec27e02, the code here was mostly
removed in
62b4198859e4ac7cf41775dc8bc943272e3ddfc3, but this little
stub remained to support CodeEditor (it piggy-backed on that feature
to support textSelection() overrides). That was also cleaned up
afterwards in
37228b257896e0a36816a61543ed5809e8ad6596, but everyone
forgot about this little remnant.
This code was not doing anything, as nothing sets the 'context.$iframe'
property anymore, in any extension.
Change-Id: I0ffe2405df7d6aaecc51b06ba6c7fea5fd8380b4
jenkins-bot [Wed, 31 Jan 2018 04:48:32 +0000 (04:48 +0000)]
Merge "rdbms: make affectedRows() work more consistently"
jenkins-bot [Wed, 31 Jan 2018 04:43:38 +0000 (04:43 +0000)]
Merge "rdbms: avoid pointless "SHOW SLAVE STATUS" calls in masterPosWait()"
Aaron Schulz [Sun, 28 Jan 2018 14:10:39 +0000 (06:10 -0800)]
rdbms: make affectedRows() work more consistently
* Update replace()/upsert() to combine the affected row
count for the non-native case
* Also make replace() atomic in the non-native case,
similar to how upsert() already works
Change-Id: I6c9bcba54eca6bcf4a93a9b230aaedf7f36aa877
Timo Tijhof [Wed, 31 Jan 2018 03:55:15 +0000 (19:55 -0800)]
JavaScriptMinifier: Fix "Uninitialized offset" in regexp char class parsing
Bug: T75556
Change-Id: I0bb63212dd44aec3c6b40477553dbf6a471bc7b3
jenkins-bot [Wed, 31 Jan 2018 03:13:46 +0000 (03:13 +0000)]
Merge "Revert "Remove workaround for comparing database domain IDs.""
Aaron Schulz [Tue, 30 Jan 2018 12:39:36 +0000 (04:39 -0800)]
rdbms: avoid pointless "SHOW SLAVE STATUS" calls in masterPosWait()
This code branch is not useful in the GTID case
Change-Id: Ia112c9b4b9c1f1297cc4eaac7f4a5a1ca882f02e
jenkins-bot [Tue, 30 Jan 2018 23:53:30 +0000 (23:53 +0000)]
Merge "rdbms: clean up non-native Database::replace() code"
jenkins-bot [Tue, 30 Jan 2018 22:20:53 +0000 (22:20 +0000)]
Merge "Fix $wgSharedDB with sqlite"
jenkins-bot [Tue, 30 Jan 2018 21:00:56 +0000 (21:00 +0000)]
Merge "Fix issue when modifying groups in Special:Userrights"
Translation updater bot [Tue, 30 Jan 2018 20:57:21 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibfb41f389c5b2c511d9372a423e2caa5cc844b37
Ryan Schmidt [Sun, 23 Jul 2017 04:19:49 +0000 (21:19 -0700)]
Fix issue when modifying groups in Special:Userrights
If a user has permission to remove a group but not add it, they cannot
manipulate other groups on a user who currently has the un-addable
group. An error is shown that the expiry is invalid and prevents the
save. To fix this, add a hidden input that is hardcoded to the existing
expiration (either 'existing' if it is a temporary assignment, or
'infinite' if the assignment does not expire), so that the validation
succeeds. Validation of this input is already taken care of in
execute(), so it is not possible for a user to extend an expiration this
way if they do not have the necessary privileges to do so.
Bug: T171345
Change-Id: I9268c05d6c491eab45147f8a9941ad4d4e1f563f
Chad Horohoe [Tue, 25 Jul 2017 20:32:31 +0000 (13:32 -0700)]
Rewrite pref cleanup script
- Keep the current hidden pref cleanup stuff, that's not harmful
and marginally useful
- Drop preferences we dunno wtf they're about. Cuz they're probably
deprecated or otherwise unused
- Normalize preferences into accepted value ranges. This part is kinda
hard and I haven't figured it out, so slap a TODO
More to come, stay tuned!
Change-Id: I70047adba0034136d107ce7534294cc6fa3c1860
Ryan Schmidt [Tue, 2 Jan 2018 17:56:32 +0000 (11:56 -0600)]
Fix $wgSharedDB with sqlite
At the time of the constructor, tableAliases will always be an empty
array. As such, the ATTACH command is never run for shared dbs, and we
get query errors when later trying to reference them. This changes it so
that the shared db is attached whenever the table aliases are finally
set.
Since table aliases may be set multiple times, the list of already
attached dbs was moved into class scope so that subsequent calls to set
the aliases do not result in query errors.
Bug: T181962
Change-Id: Ia654e996f54077bc3749b884a528e121ab25a2d2
jenkins-bot [Tue, 30 Jan 2018 20:02:16 +0000 (20:02 +0000)]
Merge "parser: Replace Sanitizer::armorLinksCallback() with a closure"
Max Semenik [Mon, 13 Nov 2017 23:48:03 +0000 (15:48 -0800)]
parser: Replace Sanitizer::armorLinksCallback() with a closure
Used only once, small enough. Perfect candidate to not be exposed
even as a private function.
Change-Id: Ic020a596f709cb4f69c48ffe8138f9023a5c4062
jenkins-bot [Tue, 30 Jan 2018 19:51:00 +0000 (19:51 +0000)]
Merge "mw.Feedback: If the message is posted remotely, link the title correctly"
jenkins-bot [Tue, 30 Jan 2018 19:44:06 +0000 (19:44 +0000)]
Merge "postEdit: Show a different success messsage on publish vs. save wikis"
jenkins-bot [Tue, 30 Jan 2018 19:35:13 +0000 (19:35 +0000)]
Merge "objectcache: add some WANObjectCache comments to set() and delete()"
James D. Forrester [Tue, 18 Apr 2017 15:59:08 +0000 (08:59 -0700)]
postEdit: Show a different success messsage on publish vs. save wikis
Bug: T183901
Change-Id: I065f733bd8b27bda68023cd1b718e257fd135aa2
Bartosz Dziewoński [Tue, 30 Jan 2018 11:12:46 +0000 (12:12 +0100)]
resourceloader: Move FILTER_NOMIN annotation to the beginning of output
This allows ResourceLoader::filter() to handle this case slightly
faster, since it searches for this annotation from the beginning.
In practice this is a negligible performance optimization, but let's
set a good example for the future.
Also tweak the comments and whitespace:
* Move comment about the FILTER_NOMIN from doc comment to code comment,
it's an implementation detail and not meant for public documentation
* Remove duplicated documentation from the parent class
* Change whitespace to be identical in both cases
Change-Id: I624914ff28d903027ba58710708ccc3c66af9e24
James D. Forrester [Wed, 25 Oct 2017 16:42:12 +0000 (09:42 -0700)]
SpecialPage: Hard deprecate getTitle, deprecated since 1.23
Change-Id: I839e9aaa0be7491087cc144ea13153abb2e77aa6
Addshore [Tue, 30 Jan 2018 17:22:50 +0000 (17:22 +0000)]
Revert "Remove workaround for comparing database domain IDs."
This seems to have broken stuff, see failing tests on:
https://gerrit.wikimedia.org/r/#/c/406302/
Could not insert main page: RevisionStore for cannot
be used with a DB connection for jenkins_u0_mw
This reverts commit
d2a4d614fce09cdf9dfc137f8507b504e09c0ccc.
Bug: T186017
Change-Id: Ic3de8e856d7d6b224b02816f2c5a1aa0648cd184
jenkins-bot [Tue, 30 Jan 2018 17:43:13 +0000 (17:43 +0000)]
Merge "SpecialExpandTemplates: Remove leftover 'mw-ui-input-inline' class"
jenkins-bot [Tue, 30 Jan 2018 16:24:55 +0000 (16:24 +0000)]
Merge "Remove unused method parameters from TestBagOStuff"
Thiemo Mättig [Wed, 10 Jan 2018 13:32:56 +0000 (14:32 +0100)]
Remove unused method parameters from TestBagOStuff
This is a test mock exclusively used in tests. All code I'm removing here
is unused and neither needed nor covered by any test.
Change-Id: Ifd010c49973460f6fbb2cd83f8fd63488f5fd291
Bartosz Dziewoński [Tue, 30 Jan 2018 14:29:44 +0000 (15:29 +0100)]
SpecialExpandTemplates: Remove leftover 'mw-ui-input-inline' class
mediawiki.ui is not loaded on this page anymore after the OOUI
conversion. However, if some extension etc. were to load it, this
field (page title) would have the styles applies unexpectedly,
and it looks rather silly with them (very narrow).
Change-Id: I5cfe71897f435a514c6971b3a0ff7521e422324c
Bartosz Dziewoński [Tue, 30 Jan 2018 09:26:15 +0000 (10:26 +0100)]
jquery.textSelection: Remove outdated FIXME comments
These are from 2010 or earlier; they blame to
32377424b94 / rSVN72349,
which is a huge SVN branch merge and I'm not going to dig past that.
To be honest I don't really understand them (perhaps some context has
been lost over the years), but their main point is "we may not need
these functions", to which I say we definitely need them because
they've been a public API for over 7 years now.
Change-Id: I43a5453003e8d64d00323eb973629a96b6b386ab
jenkins-bot [Tue, 30 Jan 2018 05:55:38 +0000 (05:55 +0000)]
Merge "Remove workaround for comparing database domain IDs."
daniel [Tue, 30 Jan 2018 03:43:11 +0000 (19:43 -0800)]
Remove workaround for comparing database domain IDs.
Change-Id: I240d68eddec871794ed98b7ce67773114ee73ff7