From: Brion Vibber <brion@users.mediawiki.org>
Date: Sat, 13 Jan 2007 22:36:32 +0000 (+0000)
Subject: Quick and dirty guard against a FakeTitle making its way into message transformation.
X-Git-Tag: 1.31.0-rc.0~54426
X-Git-Url: http://git.cyclocoop.org/%22.%24h.%22?a=commitdiff_plain;h=f724ad0838f92f6dfc9618c8729c7270db8d5997;p=lhc%2Fweb%2Fwiklou.git

Quick and dirty guard against a FakeTitle making its way into message transformation.
This could break job processing when a message using {{PAGENAME}} or similar got interpreted;
for instance using {{int:noarticeltext}}.

The message transformation uses $wgTitle, which is... probably not super.
Better fix might be to distinguish inline transformation in some nice way,
so the parser would use its own title object already set locally... or something.

ugh!
---

diff --git a/includes/Parser.php b/includes/Parser.php
index 400ce4a4fa..32c3fc961f 100644
--- a/includes/Parser.php
+++ b/includes/Parser.php
@@ -3843,7 +3843,7 @@ class Parser
 
 		wfProfileIn($fname);
 
-		if ( $wgTitle ) {
+		if ( $wgTitle && !( $wgTitle instanceof FakeTitle ) ) {
 			$this->mTitle = $wgTitle;
 		} else {
 			$this->mTitle = Title::newFromText('msg');