From: Timo Tijhof <krinklemail@gmail.com>
Date: Wed, 22 May 2019 18:29:09 +0000 (+0100)
Subject: resourceloader: Add tests for StartUpModule dep tree optimisation
X-Git-Tag: 1.34.0-rc.0~1619^2
X-Git-Url: http://git.cyclocoop.org/%22.%24h.%22?a=commitdiff_plain;h=b2d120ae3276e30bbc6fab11f3505269655324c6;p=lhc%2Fweb%2Fwiklou.git

resourceloader: Add tests for StartUpModule dep tree optimisation

Bug: T223402
Change-Id: I0450c052852068f3c78312f48a42645a8b77bc5c
---

diff --git a/tests/phpunit/includes/resourceloader/ResourceLoaderStartUpModuleTest.php b/tests/phpunit/includes/resourceloader/ResourceLoaderStartUpModuleTest.php
index d4b5ed6c91..b5dd008b3f 100644
--- a/tests/phpunit/includes/resourceloader/ResourceLoaderStartUpModuleTest.php
+++ b/tests/phpunit/includes/resourceloader/ResourceLoaderStartUpModuleTest.php
@@ -33,6 +33,78 @@ mw.loader.register( [
         "test.blank",
         "{blankVer}"
     ]
+] );',
+			] ],
+			[ [
+				'msg' => 'Optimise the dependency tree (basic case)',
+				'modules' => [
+					'a' => new ResourceLoaderTestModule( [ 'dependencies' => [ 'b', 'c', 'd' ] ] ),
+					'b' => new ResourceLoaderTestModule( [ 'dependencies' => [ 'c' ] ] ),
+					'c' => new ResourceLoaderTestModule( [ 'dependencies' => [] ] ),
+					'd' => new ResourceLoaderTestModule( [ 'dependencies' => [] ] ),
+				],
+				'out' => '
+mw.loader.addSource( {
+    "local": "/w/load.php"
+} );
+mw.loader.register( [
+    [
+        "a",
+        "{blankVer}",
+        [
+            1,
+            3
+        ]
+    ],
+    [
+        "b",
+        "{blankVer}",
+        [
+            2
+        ]
+    ],
+    [
+        "c",
+        "{blankVer}"
+    ],
+    [
+        "d",
+        "{blankVer}"
+    ]
+] );',
+			] ],
+			[ [
+				'msg' => 'Optimise the dependency tree (tolerate unknown deps)',
+				'modules' => [
+					'a' => new ResourceLoaderTestModule( [ 'dependencies' => [ 'b', 'c', 'x' ] ] ),
+					'b' => new ResourceLoaderTestModule( [ 'dependencies' => [ 'c', 'x' ] ] ),
+					'c' => new ResourceLoaderTestModule( [ 'dependencies' => [] ] ),
+				],
+				'out' => '
+mw.loader.addSource( {
+    "local": "/w/load.php"
+} );
+mw.loader.register( [
+    [
+        "a",
+        "{blankVer}",
+        [
+            1,
+            "x"
+        ]
+    ],
+    [
+        "b",
+        "{blankVer}",
+        [
+            2,
+            "x"
+        ]
+    ],
+    [
+        "c",
+        "{blankVer}"
+    ]
 ] );',
 			] ],
 			[ [
@@ -454,8 +526,7 @@ mw.loader.register( [
 
 	/**
 	 * @dataProvider provideGetModuleRegistrations
-	 * @covers ResourceLoaderStartUpModule::getModuleRegistrations
-	 * @covers ResourceLoaderStartUpModule::compileUnresolvedDependencies
+	 * @covers ResourceLoaderStartUpModule
 	 * @covers ResourceLoader::makeLoaderRegisterScript
 	 */
 	public function testGetModuleRegistrations( $case ) {