From: Thiemo Kreuz <thiemo.kreuz@wikimedia.de>
Date: Tue, 15 Jan 2019 13:42:50 +0000 (+0100)
Subject: Fix documentation for RevisionRecord::$mPageId
X-Git-Tag: 1.34.0-rc.0~2980^2
X-Git-Url: http://git.cyclocoop.org/%22.%24h.%22?a=commitdiff_plain;h=ade1921eca38b2b09b12acdd2be96a8c11d12aec;p=lhc%2Fweb%2Fwiklou.git

Fix documentation for RevisionRecord::$mPageId

As far as I can see this is impossible to be null. The getPageId()
method that returns this value is documented to "@return int" only.

Introduced in I140f43a. That was the patch that introduced this class.

Bug: T174025
Change-Id: Iae4fa5410537504e0dd354b463be3b371e4cad76
---

diff --git a/includes/Revision/RevisionRecord.php b/includes/Revision/RevisionRecord.php
index 1a7831b5f4..95749c5643 100644
--- a/includes/Revision/RevisionRecord.php
+++ b/includes/Revision/RevisionRecord.php
@@ -62,7 +62,7 @@ abstract class RevisionRecord {
 	protected $mWiki = false;
 	/** @var int|null */
 	protected $mId;
-	/** @var int|null */
+	/** @var int */
 	protected $mPageId;
 	/** @var UserIdentity|null */
 	protected $mUser;