From: Derick Alangi <alangiderick@gmail.com>
Date: Mon, 25 Mar 2019 14:20:19 +0000 (+0100)
Subject: objectcache: Remove unused variable $cache which is overriden
X-Git-Tag: 1.34.0-rc.0~2373^2
X-Git-Url: http://git.cyclocoop.org/%22.%24h.%22?a=commitdiff_plain;h=47e7f59682fb1e14679b5e0c5016b3d7d6095587;p=lhc%2Fweb%2Fwiklou.git

objectcache: Remove unused variable $cache which is overriden

This variable was defined to false and immediately overriden in the
if condition below it which makes the assignment above useless.

Change-Id: Ie72ec7a8860d2a38f59f38b3d861217d39da3e29
---

diff --git a/includes/objectcache/ObjectCache.php b/includes/objectcache/ObjectCache.php
index dc8b146c3a..fed085425a 100644
--- a/includes/objectcache/ObjectCache.php
+++ b/includes/objectcache/ObjectCache.php
@@ -238,7 +238,6 @@ class ObjectCache {
 		global $wgMainCacheType, $wgMessageCacheType, $wgParserCacheType;
 		$candidates = [ $wgMainCacheType, $wgMessageCacheType, $wgParserCacheType ];
 		foreach ( $candidates as $candidate ) {
-			$cache = false;
 			if ( $candidate !== CACHE_NONE && $candidate !== CACHE_ANYTHING ) {
 				$cache = self::getInstance( $candidate );
 				// CACHE_ACCEL might default to nothing if no APCu