From: Reedy <reedy@wikimedia.org>
Date: Sun, 9 Dec 2012 02:33:51 +0000 (+0000)
Subject: Move insertUpdateRow call before return applyPatch to make it reachable
X-Git-Tag: 1.31.0-rc.0~21373
X-Git-Url: http://git.cyclocoop.org/%22.%24h.%22?a=commitdiff_plain;h=452c73060c5cad90429ba2a89420f4f70ed22989;p=lhc%2Fweb%2Fwiklou.git

Move insertUpdateRow call before return applyPatch to make it reachable

This might not be quite right... We might want to cache the result of apply patch, insert the row and then return the result...

Change-Id: Ie6a1bb16d2912ad43aa8fd45b2bf10a8bf8652ae
---

diff --git a/includes/installer/DatabaseUpdater.php b/includes/installer/DatabaseUpdater.php
index b200dcf161..913eef5d55 100644
--- a/includes/installer/DatabaseUpdater.php
+++ b/includes/installer/DatabaseUpdater.php
@@ -721,8 +721,8 @@ abstract class DatabaseUpdater {
 		} elseif( $this->updateRowExists( $updateKey ) ) {
 			$this->output( "...$field in table $table already modified by patch $patch.\n" );
 		} else {
-			return $this->applyPatch( $patch, $fullpath, "Modifying $field field of table $table" );
 			$this->insertUpdateRow( $updateKey );
+			return $this->applyPatch( $patch, $fullpath, "Modifying $field field of table $table" );
 		}
 		return true;
 	}