From: Brion Vibber <brion@users.mediawiki.org>
Date: Wed, 9 Apr 2008 00:02:13 +0000 (+0000)
Subject: * (bug 11039) Add missing labels on protection form
X-Git-Tag: 1.31.0-rc.0~48503
X-Git-Url: http://git.cyclocoop.org/%22.%24h.%22?a=commitdiff_plain;h=19f2ab0bc4ca66f01d7c7170b438ee81e3ed0b57;p=lhc%2Fweb%2Fwiklou.git

* (bug 11039) Add missing labels on protection form
May help with screen readers which get a bit lost on the listbox-in-table layout
Fixed up some release notes entries
---

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index a8c1e6706b..010d2947d4 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -63,8 +63,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 13490) Show upload/file size limit on upload form
 * Redesign of Special:Userrights
 * Make rev_deleted log entries more intelligible.
-* (6943) Added PAGESINCATEGORY: magic word
-* (13624) Fix regression with manual thumb= parameter on images
+* (bug 6943) Added PAGESINCATEGORY: magic word
 
 
 === Bug fixes in 1.13 ===
@@ -159,6 +158,9 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 13630) Fixed warnings for pass by reference at call time in
   Special:Revisiondelete when generating the log entry.
 * (bug 12064) BeforePageDisplay hook is now called for all skins
+* (bug 13624) Fix regression with manual thumb= parameter on images
+* (bug 11039) Add missing labels on protection form
+
 
 === API changes in 1.13 ===
 
diff --git a/includes/ProtectionForm.php b/includes/ProtectionForm.php
index 0d2d88cc34..6bcc359b4f 100644
--- a/includes/ProtectionForm.php
+++ b/includes/ProtectionForm.php
@@ -233,7 +233,10 @@ class ProtectionForm {
 
 		foreach( $this->mRestrictions as $action => $required ) {
 			/* Not all languages have V_x <-> N_x relation */
-			$out .= Xml::element( 'th', null, wfMsg( 'restriction-' . $action ) );
+			$label = Xml::element( 'label',
+					array( 'for' => "mwProtect-level-$action" ),
+					wfMsg( 'restriction-' . $action ) );
+			$out .= "<th>$label</th>";
 		}
 		$out .= "</tr>
 			<tr>\n";