From: jdlrobson <jdlrobson@gmail.com>
Date: Tue, 26 Mar 2019 18:51:39 +0000 (-0700)
Subject: mediawiki.special.changeslist is a skinStyle module
X-Git-Tag: 1.34.0-rc.0~2326^2
X-Git-Url: http://git.cyclocoop.org/%22.%24h.%22?a=commitdiff_plain;h=110ca3e706f23908e6d13ea8625970cb703ee57c;p=lhc%2Fweb%2Fwiklou.git

mediawiki.special.changeslist is a skinStyle module

Allow skins full control over styling changelists
Several styles relating to unicode-bidi and client-js are
made mandatory.

The mw-changeslist-legend rules I will review separately with
Volker to determine whether they should be mandatory too, once
I'm more informed about how Minerva might use them.

Change-Id: I92c5fdc33b50771bd45e4945185c27395c608eb4
---

diff --git a/resources/Resources.php b/resources/Resources.php
index b2d0ad26c6..cb32340f11 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -2147,7 +2147,10 @@ return [
 	],
 	'mediawiki.special.changeslist' => [
 		'styles' => [
-			'resources/src/mediawiki.special.changeslist.less',
+			'resources/src/mediawiki.special.changeslist/changeslist.less'
+		],
+		'skinStyles' => [
+			'default' => 'resources/src/mediawiki.special.changeslist/default.less',
 		],
 		'targets' => [ 'desktop', 'mobile' ],
 	],
diff --git a/resources/src/mediawiki.special.changeslist.less b/resources/src/mediawiki.special.changeslist.less
deleted file mode 100644
index c78354b2b1..0000000000
--- a/resources/src/mediawiki.special.changeslist.less
+++ /dev/null
@@ -1,71 +0,0 @@
-/*
- * Styling for Special:Watchlist and Special:RecentChanges
- */
-
-.client-js .mw-input-hidden {
-	display: none;
-}
-
-/* Make sure namespace label is aligned correctly on mobile when checkboxes are displayed */
-.mw-label.mw-namespace-label {
-	vertical-align: top;
-}
-
-.mw-changeslist-line-watched .mw-title {
-	font-weight: bold;
-}
-
-/*
- * Titles, including username links, and also tag names
- * are prone to getting jumbled up
- * with other titles, usernames, etc. in mixed RTL-LTR environment.
- */
-.mw-changeslist .mw-tag-marker,
-.mw-changeslist .mw-title {
-	unicode-bidi: embed;
-}
-
-/* Colored watchlist and recent changes numbers */
-.mw-plusminus-pos {
-	color: #006400; /* dark green */
-}
-
-.mw-plusminus-neg {
-	color: #8b0000; /* dark red */
-}
-
-.mw-plusminus-null {
-	color: #a2a9b1; /* gray */
-}
-
-/*
- * Bidi-isolate these numbers.
- * See https://phabricator.wikimedia.org/T93484
- */
-.mw-plusminus-pos,
-.mw-plusminus-neg,
-.mw-plusminus-null {
-	unicode-bidi: -moz-isolate;
-	unicode-bidi: isolate;
-}
-
-/* Prevent FOUC if legend is initially collapsed */
-.mw-changeslist-legend.mw-collapsed .mw-collapsible-content {
-	display: none;
-}
-
-.mw-changeslist-legend.mw-collapsed {
-	margin-bottom: 0;
-}
-
-/* Prevent pushing down the content if legend is collapsed */
-.mw-changeslist-legend.mw-collapsed ~ ul:first-of-type > li:first-child,
-.mw-changeslist-legend.mw-collapsed + h4 + div > table.mw-changeslist-line:first-child {
-	clear: right;
-}
-
-/* Hide RCFilters highlight containers if RCFilters is not enabled.
-   This is overridden in mw.ui.rcfilters.ChangesListWrapperWidget.less if RCFilters is enabled. */
-.mw-rcfilters-ui-highlights {
-	display: none;
-}
diff --git a/resources/src/mediawiki.special.changeslist/changeslist.less b/resources/src/mediawiki.special.changeslist/changeslist.less
new file mode 100644
index 0000000000..f24d1f2352
--- /dev/null
+++ b/resources/src/mediawiki.special.changeslist/changeslist.less
@@ -0,0 +1,24 @@
+.client-js .mw-input-hidden {
+	display: none;
+}
+
+/*
+ * Titles, including username links, and also tag names
+ * are prone to getting jumbled up
+ * with other titles, usernames, etc. in mixed RTL-LTR environment.
+ */
+.mw-changeslist .mw-tag-marker,
+.mw-changeslist .mw-title {
+	unicode-bidi: embed;
+}
+
+/*
+ * Bidi-isolate these numbers.
+ * See https://phabricator.wikimedia.org/T93484
+ */
+.mw-plusminus-pos,
+.mw-plusminus-neg,
+.mw-plusminus-null {
+	unicode-bidi: -moz-isolate;
+	unicode-bidi: isolate;
+}
diff --git a/resources/src/mediawiki.special.changeslist/default.less b/resources/src/mediawiki.special.changeslist/default.less
new file mode 100644
index 0000000000..203beee349
--- /dev/null
+++ b/resources/src/mediawiki.special.changeslist/default.less
@@ -0,0 +1,46 @@
+/*
+ * Styling for Special:Watchlist and Special:RecentChanges
+ */
+
+/* Make sure namespace label is aligned correctly on mobile when checkboxes are displayed */
+.mw-label.mw-namespace-label {
+	vertical-align: top;
+}
+
+.mw-changeslist-line-watched .mw-title {
+	font-weight: bold;
+}
+
+/* Colored watchlist and recent changes numbers */
+.mw-plusminus-pos {
+	color: #006400; /* dark green */
+}
+
+.mw-plusminus-neg {
+	color: #8b0000; /* dark red */
+}
+
+.mw-plusminus-null {
+	color: #a2a9b1; /* gray */
+}
+
+/* Prevent FOUC if legend is initially collapsed */
+.mw-changeslist-legend.mw-collapsed .mw-collapsible-content {
+	display: none;
+}
+
+.mw-changeslist-legend.mw-collapsed {
+	margin-bottom: 0;
+}
+
+/* Prevent pushing down the content if legend is collapsed */
+.mw-changeslist-legend.mw-collapsed ~ ul:first-of-type > li:first-child,
+.mw-changeslist-legend.mw-collapsed + h4 + div > table.mw-changeslist-line:first-child {
+	clear: right;
+}
+
+/* Hide RCFilters highlight containers if RCFilters is not enabled.
+   This is overridden in mw.ui.rcfilters.ChangesListWrapperWidget.less if RCFilters is enabled. */
+.mw-rcfilters-ui-highlights {
+	display: none;
+}