Remove form when including empty Special:WhatLinksHere

Included special pages should never show a form, because a included
special page is designed to show the result of something, not allow
starting a search (where than Special:WhatLinksHere is opened instead of
showing the result within the wiki page).

On no input Special:WhatLinksHere would output nothing, like a
transcluded Special:Contributions would do.

Bug: T67779
Change-Id: I289fd8fe6bbd4238581035770a472b1c7b9f2643

diff --git a/includes/specials/SpecialWhatlinkshere.php b/includes/specials/SpecialWhatlinkshere.php
index 40cce5e..0b3175a 100644 (file)
--- a/includes/specials/SpecialWhatlinkshere.php
+++ b/includes/specials/SpecialWhatlinkshere.php
@@ -73,7 +73,9 @@ class SpecialWhatLinksHere extends IncludableSpecialPage {
 
                $this->target = Title::newFromURL( $opts->getValue( 'target' ) );
                if ( !$this->target ) {
-                       $out->addHTML( $this->whatlinkshereForm() );
+                       if ( !$this->including() ) {
+                               $out->addHTML( $this->whatlinkshereForm() );
+                       }
 
                        return;
                }