Merge "RCFilters: Only apply excluded label to namespace items"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Mon, 20 Nov 2017 18:20:45 +0000 (18:20 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Mon, 20 Nov 2017 18:20:45 +0000 (18:20 +0000)
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ItemMenuOptionWidget.js

index db43a53..97000d4 100644 (file)
                this.excludeLabel = new OO.ui.LabelWidget( {
                        label: mw.msg( 'rcfilters-filter-excluded' )
                } );
-               this.excludeLabel.toggle( this.itemModel.isSelected() && this.invertModel.isSelected() );
+               this.excludeLabel.toggle(
+                       this.itemModel.getGroupModel().getView() === 'namespace' &&
+                       this.itemModel.isSelected() &&
+                       this.invertModel.isSelected()
+               );
 
                layout = new OO.ui.FieldLayout( this.checkboxWidget, {
                        label: $label,
                this.checkboxWidget.setSelected( this.itemModel.isSelected() );
 
                this.highlightButton.toggle( this.filtersViewModel.isHighlightEnabled() );
-               this.excludeLabel.toggle( this.itemModel.isSelected() && this.invertModel.isSelected() );
+               this.excludeLabel.toggle(
+                       this.itemModel.getGroupModel().getView() === 'namespace' &&
+                       this.itemModel.isSelected() &&
+                       this.invertModel.isSelected()
+               );
        };
 
        /**