Make convertUserOptions.php more self-contained
authorKevin Israel <pleasestand@live.com>
Sun, 25 May 2014 11:00:13 +0000 (07:00 -0400)
committerKevin Israel <pleasestand@live.com>
Sun, 1 Jun 2014 03:10:47 +0000 (23:10 -0400)
commit3385d6d157638de6275a48725798d0806025a705
tree625ac6bf1089b1632439263a5cd0894e9e3c3c43
parent25f051d22716dff6788a7154812a7a756429dd36
Make convertUserOptions.php more self-contained

* Moved the code from User::decodeOptions() to the maintenance script,
  the only place it is (indirectly) used.
* Changed the script to insert new rows itself rather than calling
  User::saveSettings(), avoiding bug 63677.
* Removed FOR UPDATE and COMMIT lacking a matching BEGIN.
* Made ORDER BY explicit.
* Removed pointless "Do each user sequentially [...]" comment dating
  back to r48732, in which the script would increment a user's ID
  to get the next one.

Bug: 63677
Change-Id: I86365a7363af3376cc4f55fa528b050b44378656
includes/User.php
maintenance/convertUserOptions.php