From e0dbc41f7b15002f76d009202f776c7b032e2e10 Mon Sep 17 00:00:00 2001
From: Timo Tijhof <krinklemail@gmail.com>
Date: Thu, 21 Sep 2017 23:31:48 +0100
Subject: [PATCH] resourceloader: Use ES5 Array#filter instead of jQuery.grep

Same or better performance in Chrome Canary and latest WebKit.
Further reduces reliance on jQuery in base module.

Change-Id: I691b73b837178b76cff665cbd52f5e5067672a6e
---
 resources/src/mediawiki/mediawiki.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js
index b5224867d2..39d01275c1 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -625,7 +625,7 @@
 		 * @param {Function} callback
 		 */
 		trackUnsubscribe: function ( callback ) {
-			trackHandlers = $.grep( trackHandlers, function ( fns ) {
+			trackHandlers = trackHandlers.filter( function ( fns ) {
 				if ( fns[ 1 ] === callback ) {
 					trackCallbacks.remove( fns[ 0 ] );
 					// Ensure the tuple is removed to avoid holding on to closures
@@ -1465,7 +1465,7 @@
 				if ( ready !== undefined || error !== undefined ) {
 					jobs.push( {
 						// Narrow down the list to modules that are worth waiting for
-						dependencies: $.grep( dependencies, function ( module ) {
+						dependencies: dependencies.filter( function ( module ) {
 							var state = mw.loader.getState( module );
 							return state === 'registered' || state === 'loaded' || state === 'loading' || state === 'executing';
 						} ),
@@ -1782,7 +1782,7 @@
 					if ( mw.loader.store.enabled ) {
 						implementations = [];
 						sourceModules = [];
-						batch = $.grep( batch, function ( module ) {
+						batch = batch.filter( function ( module ) {
 							var implementation = mw.loader.store.get( module );
 							if ( implementation ) {
 								implementations.push( implementation );
@@ -1807,7 +1807,7 @@
 
 							mw.track( 'resourceloader.exception', { exception: err, source: 'store-eval' } );
 							// Re-add the failed ones that are still pending back to the batch
-							failed = $.grep( sourceModules, function ( module ) {
+							failed = sourceModules.filter( function ( module ) {
 								return registry[ module ].state === 'loading';
 							} );
 							batchRequest( failed );
@@ -2071,7 +2071,7 @@
 					}
 
 					// Filter out top-level modules that are unknown or failed to load before.
-					filtered = $.grep( modules, function ( module ) {
+					filtered = modules.filter( function ( module ) {
 						var state = mw.loader.getState( module );
 						return state !== 'error' && state !== 'missing';
 					} );
@@ -2773,7 +2773,7 @@
 	$( function () {
 		var loading, modules;
 
-		modules = $.grep( mw.loader.getModuleNames(), function ( module ) {
+		modules = mw.loader.getModuleNames().filter( function ( module ) {
 			return mw.loader.getState( module ) === 'loading';
 		} );
 		// We only need a callback, not any actual module. First try a single using()
-- 
2.20.1