From d4863dea270c4d12d742991e48fc067c7890413d Mon Sep 17 00:00:00 2001 From: Kaldari Date: Fri, 28 Apr 2017 13:45:25 -0700 Subject: [PATCH] Adding explantation for why to use User::incEditCount() ... rather than User::incEditCountImmediate() for most cases. Change-Id: Ia16baabaeaca5c726e1dd1fc2506dc0b85500b6e --- includes/user/User.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/includes/user/User.php b/includes/user/User.php index 3edd49f783..3d6cbe4401 100644 --- a/includes/user/User.php +++ b/includes/user/User.php @@ -5077,6 +5077,9 @@ class User implements IDBAccessObject { /** * Deferred version of incEditCountImmediate() + * + * This function, rather than incEditCountImmediate(), should be used for + * most cases as it avoids potential deadlocks caused by concurrent editing. */ public function incEditCount() { wfGetDB( DB_MASTER )->onTransactionPreCommitOrIdle( -- 2.20.1