From c03589c7a387ba3d8f597cf85e44f77f21dd8fc3 Mon Sep 17 00:00:00 2001 From: Moriel Schottlender Date: Thu, 23 Feb 2017 10:06:58 -0800 Subject: [PATCH] RCFilters UI: Reassess interaction after resetting filters Both resetting to defaults or resetting to no-filters state should retrigger the interaction assessment so all filters should get their included, fullyCovered and conflicted states resetted. Bug: T158135 Change-Id: Iae23129b7fb378adb712b34e8e64208bbb70ccd7 --- .../src/mediawiki.rcfilters/mw.rcfilters.Controller.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js index 3ba4dc0703..1df31a279a 100644 --- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js +++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js @@ -59,6 +59,9 @@ */ mw.rcfilters.Controller.prototype.resetToDefaults = function () { this.filtersModel.setFiltersToDefaults(); + // Check all filter interactions + this.filtersModel.reassessFilterInteractions(); + this.updateURL(); this.updateChangesList(); }; @@ -69,6 +72,9 @@ mw.rcfilters.Controller.prototype.emptyFilters = function () { this.filtersModel.emptyAllFilters(); this.filtersModel.clearAllHighlightColors(); + // Check all filter interactions + this.filtersModel.reassessFilterInteractions(); + this.updateURL(); this.updateChangesList(); }; -- 2.20.1