From a9eae0b6308d2d3746156677355163cd7381e7e8 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Mon, 29 Dec 2014 19:24:20 +0100 Subject: [PATCH] Fix warning on Special:ListGroupRights for group with invalid group page Avoids Notice: Linker::link: Requires $target to be a Title object. [Called from SpecialListGroupRights::execute in \includes\specials\SpecialListgrouprights.php at line 97] Change-Id: Ie90ea33b0f57861985a296380e4ee7296dac79af --- includes/specials/SpecialListgrouprights.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/includes/specials/SpecialListgrouprights.php b/includes/specials/SpecialListgrouprights.php index 8b9a0ee450..828a93b9b9 100644 --- a/includes/specials/SpecialListgrouprights.php +++ b/includes/specials/SpecialListgrouprights.php @@ -86,13 +86,14 @@ class SpecialListGroupRights extends SpecialPage { $grouppageLocalized = !$msg->isBlank() ? $msg->text() : MWNamespace::getCanonicalName( NS_PROJECT ) . ':' . $groupname; + $grouppageLocalizedTitle = Title::newFromText( $grouppageLocalized ); - if ( $group == '*' ) { - // Do not make a link for the generic * group + if ( $group == '*' || !$grouppageLocalizedTitle ) { + // Do not make a link for the generic * group or group with invalid group page $grouppage = htmlspecialchars( $groupnameLocalized ); } else { $grouppage = Linker::link( - Title::newFromText( $grouppageLocalized ), + $grouppageLocalizedTitle, htmlspecialchars( $groupnameLocalized ) ); } -- 2.20.1