From 9de31b0ad070bf24071ce06c8430d5b94d64cf83 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Niklas=20Laxstr=C3=B6m?= Date: Sat, 7 Aug 2010 23:43:28 +0000 Subject: [PATCH] Use for loops for iterating query results --- includes/MessageCache.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/includes/MessageCache.php b/includes/MessageCache.php index 0524ccd62e..1e77504801 100644 --- a/includes/MessageCache.php +++ b/includes/MessageCache.php @@ -343,10 +343,9 @@ class MessageCache { # Load titles for all oversized pages in the MediaWiki namespace $res = $dbr->select( 'page', 'page_title', $bigConds, __METHOD__ . "($code)-big" ); - while ( $row = $dbr->fetchObject( $res ) ) { + foreach ( $res as $row ) { $cache[$row->page_title] = '!TOO BIG'; } - $dbr->freeResult( $res ); # Conditions to load the remaining pages with their contents $smallConds = $conds; @@ -358,10 +357,9 @@ class MessageCache { array( 'page_title', 'old_text', 'old_flags' ), $smallConds, __METHOD__ . "($code)-small" ); - for ( $row = $dbr->fetchObject( $res ); $row; $row = $dbr->fetchObject( $res ) ) { + foreach ( $res as $row ) { $cache[$row->page_title] = ' ' . Revision::getRevisionText( $row ); } - $dbr->freeResult( $res ); $cache['VERSION'] = MSG_CACHE_VERSION; wfProfileOut( __METHOD__ ); -- 2.20.1