From 21b0801a2c3f93d93149d5ab02efa33507a77cf5 Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Mon, 28 Sep 2015 13:44:39 +0200 Subject: [PATCH] Fix PHP CS warning in LogPager.php Change-Id: I31f074ad77309bf02163810eb6689dc0bb56460e --- includes/logging/LogPager.php | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/includes/logging/LogPager.php b/includes/logging/LogPager.php index 598a45f07c..3583599bd0 100644 --- a/includes/logging/LogPager.php +++ b/includes/logging/LogPager.php @@ -218,17 +218,19 @@ class LogPager extends ReverseChronologicalPager { } } - # Using the (log_namespace, log_title, log_timestamp) index with a - # range scan (LIKE) on the first two parts, instead of simple equality, - # makes it unusable for sorting. Sorted retrieval using another index - # would be possible, but then we might have to scan arbitrarily many - # nodes of that index. Therefore, we need to avoid this if $wgMiserMode - # is on. - # - # This is not a problem with simple title matches, because then we can - # use the page_time index. That should have no more than a few hundred - # log entries for even the busiest pages, so it can be safely scanned - # in full to satisfy an impossible condition on user or similar. + /** + * Using the (log_namespace, log_title, log_timestamp) index with a + * range scan (LIKE) on the first two parts, instead of simple equality, + * makes it unusable for sorting. Sorted retrieval using another index + * would be possible, but then we might have to scan arbitrarily many + * nodes of that index. Therefore, we need to avoid this if $wgMiserMode + * is on. + * + * This is not a problem with simple title matches, because then we can + * use the page_time index. That should have no more than a few hundred + * log entries for even the busiest pages, so it can be safely scanned + * in full to satisfy an impossible condition on user or similar. + */ $this->mConds['log_namespace'] = $ns; if ( $doUserRightsLogLike ) { $params = array( $name . $wgUserrightsInterwikiDelimiter ); -- 2.20.1