Timo Tijhof [Sat, 9 Mar 2019 05:06:36 +0000 (05:06 +0000)]
resourceloader: Remove redundant var-freeing in addScript()
This was copied from jQuery 1.x, where it existed to reduce
memory usage in IE6-8. This was because it's JS engine was not
able to break the circular closure reference (the function
invocation has a reference to the script element, the script
element has an event listener with closure access to the script
element). This bug is no longer relevant.
Change-Id: I6fd66c5fbf3afb3c9e09bba6322dc3fac2fad4a6
Timo Tijhof [Sat, 9 Mar 2019 05:05:06 +0000 (05:05 +0000)]
resourceloader: Reduce size of ES5 StringSet fallback
Over 90% of browsers have ES6 Set implemented.
Make the fallback a bit smaller.
Change-Id: Icfd18cbeac6d95702ac409297a01c81829d5a41b
Timo Tijhof [Sat, 9 Mar 2019 04:56:54 +0000 (04:56 +0000)]
resourceloader: Minor optimisation in variable declarations
Trying out Safari after a while and, it's Dev Tools have a
way to see the compiler's type inference, showing that Safari
is not able to always detect some numbers as non-optional.
While I generally avoid optimising for an optimiser, I believe
being more explicit is always better or equal. Plus, it saves a
few bytes while at it.
Change-Id: I4084452a74c51953ff0a1609b3b52d696f14a7e1
Aaron Schulz [Sat, 9 Mar 2019 01:36:21 +0000 (17:36 -0800)]
Make HTMLCacheUpdateJob avoid waiting on replication for no reason
Change-Id: Ica381dad0bdb0555add1c7925e0e48991e7e0964
jenkins-bot [Sat, 9 Mar 2019 00:41:04 +0000 (00:41 +0000)]
Merge "Make addIdentifierQuotes part of IDatabase"
Brian Wolff [Sun, 17 Feb 2019 11:02:34 +0000 (11:02 +0000)]
Make addIdentifierQuotes part of IDatabase
This is so it can be used in places that typehint an IDatabase,
ultimately so that I can make phan-taint-check happy.
Bug: T216348
Change-Id: Iabf3e9a6add380322a12cdbb6a337bad690f1370
jenkins-bot [Sat, 9 Mar 2019 00:15:00 +0000 (00:15 +0000)]
Merge "objectcache: Use constant for $ttl param default in WANObjectCache::set()"
Andrew Green [Mon, 17 Oct 2016 15:21:08 +0000 (10:21 -0500)]
objectcache: Use constant for $ttl param default in WANObjectCache::set()
Change-Id: I3f936088cd63af4d535d7f46fe5619e8bb866999
jenkins-bot [Fri, 8 Mar 2019 23:37:14 +0000 (23:37 +0000)]
Merge "rdbms: optimize Database::selectDomain() to avoid extra queries"
jenkins-bot [Fri, 8 Mar 2019 23:37:08 +0000 (23:37 +0000)]
Merge "Remove `list-style-type` declaration from elements.css"
jenkins-bot [Fri, 8 Mar 2019 23:12:31 +0000 (23:12 +0000)]
Merge "resourceloader: Omit default 'debug=false' from load.php urls"
jenkins-bot [Fri, 8 Mar 2019 23:12:26 +0000 (23:12 +0000)]
Merge "resourceloader: Separate context from extraQuery in ClientHtmlTest"
jenkins-bot [Fri, 8 Mar 2019 23:12:20 +0000 (23:12 +0000)]
Merge "ApiQueryLogEvents: Add IGNORE INDEX to avoid MariaDB optimizer bug"
jenkins-bot [Fri, 8 Mar 2019 23:05:29 +0000 (23:05 +0000)]
Merge "resourceloader: Replace ResourceLoaderDebug config use with context"
Volker E [Fri, 8 Mar 2019 22:24:53 +0000 (14:24 -0800)]
Remove `list-style-type` declaration from elements.css
This doesn't make any sense here, as
a) we should apply `disc` in alignment to Design Style Guide
b) it's overwritten anyways in both, Vector and MonoBook, with
different styles
Bug: T151100
Change-Id: Ied6810a78d8fbe5371838921cda468e6873d2e57
Aaron Schulz [Fri, 8 Mar 2019 22:04:54 +0000 (14:04 -0800)]
rdbms: optimize Database::selectDomain() to avoid extra queries
Also clean up and align the mysql subclass versions of the method.
Enforce that raw "USE" queries are not passed in, since they would
break the tracking (even before this change).
Change-Id: I11c9145c6c0525f27a4ec8d94c500a22a712b320
jenkins-bot [Fri, 8 Mar 2019 21:45:58 +0000 (21:45 +0000)]
Merge "jquery.tablesorter: Optimise getElementSortKey() code"
jenkins-bot [Fri, 8 Mar 2019 21:45:31 +0000 (21:45 +0000)]
Merge "Move CacheDependency classes to own files"
jenkins-bot [Fri, 8 Mar 2019 21:40:12 +0000 (21:40 +0000)]
Merge "objectcache: add metrics for WAN cache deletes and check key touches/resets"
jenkins-bot [Fri, 8 Mar 2019 21:40:04 +0000 (21:40 +0000)]
Merge "objectcache: move ERR_* constants to IExpiringStore"
Timo Tijhof [Fri, 8 Mar 2019 20:37:12 +0000 (20:37 +0000)]
resourceloader: Omit default 'debug=false' from load.php urls
Change-Id: I2a2f92b0f0438420105e6a4e4d97eb5f8c480917
Timo Tijhof [Fri, 8 Mar 2019 20:58:16 +0000 (20:58 +0000)]
resourceloader: Separate context from extraQuery in ClientHtmlTest
The test was dual-purposing the same array both to create
a ResourceLoaderContext object, and to pass further down as
$extraQuery parameter.
This meant that ResourceLoaderClientHtml::makeLoad, and indirectly
ResourceLoader::makeLoaderQuery, did not have any control over
the formatting of the query string, due to it forcing the key/value
pairs regardless (in addition to being redundant).
This is needed in order to omit debug=false by default, which is
the next commit.
Change-Id: I3c098a9a5055ec8f2b64319c6cadd13c030ba76a
Umherirrender [Fri, 8 Mar 2019 21:27:29 +0000 (22:27 +0100)]
Move CacheDependency classes to own files
Change-Id: Icacf36674f10fa19a09499d68d596d5e2cc235f0
Aaron Schulz [Thu, 7 Mar 2019 23:12:33 +0000 (15:12 -0800)]
objectcache: remove BagOStuff::modifySimpleRelayEvent()
This was only there as part of EventRelayer use by WAN cache, which
has since been removed. No other usage really makes sense.
Change-Id: I201425bb88739dd8febbfbc3d24a15e6d3d88d9c
Aaron Schulz [Fri, 8 Mar 2019 21:11:54 +0000 (13:11 -0800)]
objectcache: move ERR_* constants to IExpiringStore
Also removed unused ERR_* constant from WANObjectCache and fixed
comment in the constructor.
Change-Id: I4377fc3f533113a459b648fad084ba097ff51762
Timo Tijhof [Fri, 8 Mar 2019 16:02:44 +0000 (16:02 +0000)]
jquery.tablesorter: Optimise getElementSortKey() code
* Document why this uses $().data() instead of $.data(),
as the rest of this file does.
* Move single-use $() to where it is needed.
* Use native Image.alt directly instead of going via jQuery
and attributes. This also obviates the need for a default,
as the DOM handles that already.
* Remove needless $.makeArray(), use $.map() directly which
supports the same array-like objects as $.makeArray().
* Use native elem.textContent directly for text nodes,
instead of $(elem).text().
Change-Id: I92da50e1c01f11585d2bac4f01dba1f671444a63
Translation updater bot [Fri, 8 Mar 2019 21:06:23 +0000 (22:06 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: If38e8f3671ef5a53006836c5ac14bbadc6930098
jenkins-bot [Fri, 8 Mar 2019 20:52:52 +0000 (20:52 +0000)]
Merge "jquery.tablesorter: Remove dead node check in getElementSortKey()"
jenkins-bot [Fri, 8 Mar 2019 20:50:07 +0000 (20:50 +0000)]
Merge "Convert a few call_user_func*() calls to native PHP syntax"
Timo Tijhof [Fri, 8 Mar 2019 15:30:27 +0000 (15:30 +0000)]
jquery.tablesorter: Remove dead node check in getElementSortKey()
In 2012, commit
39d1f3967be9d added special handling image elements,
and for Cite references. This inadvertently broke handling of sorting
for tables with colspanned cells, which have node = undefined in the
cache.
In 2013, commit
e203fdfc74f18 restored handling of node = undefined.
In 2015, commit
7a5f4e46d10ea made colspan expanded in the cache
just as rowspan was already. Thus making this code dead.
It's odd to see $(node) before this check, and even a call within
this conditional. This worked, as long way to return ''.
Change-Id: Ia823a3ec29371be39fab3d626ed8647ee469951b
Timo Tijhof [Fri, 8 Mar 2019 20:33:04 +0000 (20:33 +0000)]
resourceloader: Replace ResourceLoaderDebug config use with context
Reduce our reliance on static state and configuration, and
propagate more state in explicit ways, through context, and
request parameters.
OutputPage creates ResourceLoaderContext and ResourceLoaderClientHtml
based on the configuration (via ResourceLoader::inDebugMode).
Everything within those classes should not need to check it
again.
* ResourceLoaderClientHtml:
Already doesn't check MW config, but it's test was still
mocking it. Removed now, and confirmed that it passes both
with true and false. The individual test cases set
debug=true/false as needed already.
It's sets were previously relying on the accidental behaviour
that within a unit test, we don't serialise over HTTP, which
meant that a pure PHP boolean would survive. With the new
raw `=== 'true'` check, this no longer works. Set it as a
string explicitly instead, which is the only thing we support
outside unit tests as well.
* ResourceLoaderContext:
Remove fallback to MW config when 'debug' is unset.
This is never unset in practice given that all load.php
urls have it set by OutputPage based on ResourceLoader::inDebugMode.
This change means that manually constructed ad-hoc load.php
urls that are missing 'debug=' parameter, will now always be
read as debug=false. This was the default already, but could
previously be changed through wgResourceLoaderDebug.
When changing wgResourceLoaderDebug, everything will still have
debug=true as before. The only change is when constructing load.php
urls manually and explicitly not set it.
Bug: T32956
Change-Id: Ie3424be46e2b8311968f3068ca08ba6a1139224a
Umherirrender [Fri, 8 Mar 2019 19:19:26 +0000 (20:19 +0100)]
Move class JobQueueAggregatorNull to own file
Change-Id: Icb76f25eb9c2a26c91ba564a78edd4c07b49b944
Fomafix [Sat, 2 Mar 2019 11:14:28 +0000 (12:14 +0100)]
Remove deprecated Language::markNoConversion
Language::markNoConversion was hard-deprecated in
7de2c566d included in
1.32.
Change-Id: I2cc200d7a814e73d9c6138860190f44232a6bd3c
jenkins-bot [Fri, 8 Mar 2019 08:15:51 +0000 (08:15 +0000)]
Merge "Check normalization rules of usernames during signup"
Max Semenik [Fri, 8 Mar 2019 03:25:40 +0000 (19:25 -0800)]
Convert a few call_user_func*() calls to native PHP syntax
Change-Id: I54d94f4369eb4fa0b0ebe892a1d6cc57b2bdb1f9
jenkins-bot [Fri, 8 Mar 2019 01:28:38 +0000 (01:28 +0000)]
Merge "build: Remove failing HHVM test from Travis CI config"
jenkins-bot [Fri, 8 Mar 2019 00:51:25 +0000 (00:51 +0000)]
Merge "objectcache: add $flags argument to BagOStuff::delete()"
jenkins-bot [Fri, 8 Mar 2019 00:34:31 +0000 (00:34 +0000)]
Merge "rdbms: undeprecate DBReplicationWaitError to align with current use"
jenkins-bot [Fri, 8 Mar 2019 00:05:37 +0000 (00:05 +0000)]
Merge "Do not bother with WAN cache set options for immutable text blob keys"
jenkins-bot [Fri, 8 Mar 2019 00:05:31 +0000 (00:05 +0000)]
Merge "Make IndexPager query direction code more readable"
jenkins-bot [Fri, 8 Mar 2019 00:05:26 +0000 (00:05 +0000)]
Merge "objectcache: remove obsolete code from SqlBagOStuff::handleWriteError()"
jenkins-bot [Thu, 7 Mar 2019 23:58:57 +0000 (23:58 +0000)]
Merge "Make ApiStashEdit use a separate key for the parser output due to size"
jenkins-bot [Thu, 7 Mar 2019 23:58:51 +0000 (23:58 +0000)]
Merge "objectcache: fix comment typo for addBusyCallback()"
Timo Tijhof [Thu, 7 Mar 2019 23:17:59 +0000 (23:17 +0000)]
build: Remove failing HHVM test from Travis CI config
This is the only version of HHVM that MediaWiki still supports,
and while it is passing on WMF's Jenkins, its redundant counterpart
on Travis has been failing for months.
It doesn't appear to be adding value in its current form,
and it's unlikely that after failing so long, that someone would
invest in making it pass before support for HHVM is dropped later
this year (in master, which is the only branch we test in Travis).
It's also delayed feedback by a third (~10min -> 15min), because
it seems to be much slower than the others (unsure why).
Change-Id: I89bd09cb04afde89c8e8ec9a06f69ecb4b094714
jenkins-bot [Thu, 7 Mar 2019 21:51:27 +0000 (21:51 +0000)]
Merge "UserTest: correctly reset fake time"
jenkins-bot [Thu, 7 Mar 2019 21:51:21 +0000 (21:51 +0000)]
Merge "Add @var to Pager classes"
jenkins-bot [Thu, 7 Mar 2019 21:49:56 +0000 (21:49 +0000)]
Merge "Added Id to the input box"
Aaron Schulz [Thu, 7 Mar 2019 21:25:06 +0000 (13:25 -0800)]
rdbms: undeprecate DBReplicationWaitError to align with current use
Change-Id: I2a180558b1a8cfaccf72bec7a809158de25eebc4
jenkins-bot [Thu, 7 Mar 2019 21:24:54 +0000 (21:24 +0000)]
Merge "Update OOUI to v0.30.4"
Aaron Schulz [Thu, 7 Mar 2019 21:21:41 +0000 (13:21 -0800)]
objectcache: remove obsolete code from SqlBagOStuff::handleWriteError()
Given that the DB classes already check read-only mode and bad
transaction states are already handled by
3975e04cf4d, this
code was not useful.
Change-Id: I4b6e8909196448a12cf74598de0272fa43bdfc62
Stephane Bisson [Thu, 7 Mar 2019 21:18:22 +0000 (16:18 -0500)]
UserTest: correctly reset fake time
Change-Id: I5fc64506781fbc40e81719aa03441643c38d4e54
Follows-Up: Ica3e6e7165496bdc9b8f12972cf93847ecfffa50
Bug: T216631
Aaron Schulz [Thu, 7 Mar 2019 21:15:29 +0000 (13:15 -0800)]
objectcache: add $flags argument to BagOStuff::delete()
This makes it consistent with set() and merge(). Also, one subclass
was already using the field in this manner.
Clean up the code related to WRITE_SYNC in SqlBagOStuff.
Change-Id: I0fb84f4475311889507d3ef98afd4476fb81174f
Translation updater bot [Thu, 7 Mar 2019 21:02:11 +0000 (22:02 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I28265dca10ec71e558c1df9135430c9d9c498a4e
jenkins-bot [Thu, 7 Mar 2019 20:52:45 +0000 (20:52 +0000)]
Merge "Use short assignment operator in PHP"
Aaron Schulz [Thu, 7 Mar 2019 20:25:02 +0000 (12:25 -0800)]
objectcache: fix comment typo for addBusyCallback()
Change-Id: I05a4d84d40b81ba25b89238b36cdb64c71e2de1e
Stephane Bisson [Wed, 6 Mar 2019 16:28:51 +0000 (11:28 -0500)]
Introducing User::getLatestEditTimestamp()
This will be used by the GrowthExperiments
Mentorship module to show when a user made their
latest contribution.
* Introduce a private function to reduce duplication with
getFirstEditTimestamp()
* Add unit tests for both
Bug: T216631
Change-Id: Ica3e6e7165496bdc9b8f12972cf93847ecfffa50
jenkins-bot [Thu, 7 Mar 2019 19:44:11 +0000 (19:44 +0000)]
Merge "Normalize "LEFT OUTER JOIN" to "LEFT JOIN" in SQL queries"
Umherirrender [Thu, 3 Jan 2019 15:15:07 +0000 (16:15 +0100)]
Add @var to Pager classes
Some are needed to make better results with phan in extensions
For example:
File CentralNoticeCampaignLogPager.php line 12:
Assigning array{0:20,1:50,2:100} to property but
\CentralNoticeCampaignLogPager->mLimitsShown is
array{0:20,1:50,2:100,3:250,4:500}
[PhanTypeMismatchProperty]
With "@var int[]" the type is correct
Change-Id: Ic68910bf17344852ad11fcc000a47891e4bf0179
Thiemo Kreuz [Thu, 28 Feb 2019 11:33:47 +0000 (12:33 +0100)]
Update PHPDoc types in several maintenance scripts and related
There is like a billion of these in our core codebase. I would love to
update them all. But I don't have the time, at least not to do them all
at once.
TL;DR: It's an improvement. :-)
Change-Id: I0a9c51bdcf0f261f971586bb8703f418324b0f98
jenkins-bot [Thu, 7 Mar 2019 10:39:22 +0000 (10:39 +0000)]
Merge "Remove various references to cURL in code comments"
James D. Forrester [Thu, 7 Mar 2019 09:22:27 +0000 (09:22 +0000)]
Update OOUI to v0.30.4
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.30.4
Bug: T92026
Bug: T145674
Bug: T206729
Bug: T213884
Bug: T216780
Bug: T217014
Bug: T217213
Bug: T217381
Bug: T217790
Depends-On: Id50f068908accd022c7847c40795286c32199b4e
Change-Id: Id50f068908accd022c7847c40795286c32199b4a
Fomafix [Mon, 1 May 2017 17:18:38 +0000 (19:18 +0200)]
Use short assignment operator in PHP
Use
$var .= $foo
instead of
$var = $var . $foo
Change-Id: I5dcdd7278e618c14968e5ac1fb8ea43ac2200deb
jenkins-bot [Thu, 7 Mar 2019 00:07:40 +0000 (00:07 +0000)]
Merge "Report logs for each individual test failure"
jenkins-bot [Thu, 7 Mar 2019 00:07:34 +0000 (00:07 +0000)]
Merge "Title: Minor clean up for stricter checks, casting style, and doc types"
Erik Bernhardson [Mon, 4 Mar 2019 21:44:39 +0000 (13:44 -0800)]
Report logs for each individual test failure
The initial implementation of reporting logs with test failures was
incorrect, it always reported the logs of the most recent test run.
Attach logs to the Test when a failure is reported and pull them
back out in the result printer.
Bug: T217489
Change-Id: I5aa55d6fa7a7ec03a2e71636b6b0366ea40605cb
jenkins-bot [Wed, 6 Mar 2019 23:02:42 +0000 (23:02 +0000)]
Merge "Use the .= operator to concatenate a var with another"
Aaron Schulz [Wed, 6 Mar 2019 22:19:41 +0000 (14:19 -0800)]
Do not bother with WAN cache set options for immutable text blob keys
Doing so can only result in occasional needless set() call rejections
or automatically lowered TTLs.
Change-Id: I2f007ba88e8f9c9f1ac3cd3d2daf3cd2289e315a
Aaron Schulz [Wed, 6 Mar 2019 18:51:43 +0000 (10:51 -0800)]
Make IndexPager query direction code more readable
Rename $descending variable in doQuery() to $order, along with the
$descending argument to reallyDoQuery() and buildQueryInfo(). Use
new IndexPager::QUERY_* constants for checking and inverting such
values. Fix the comments so that they do not imply the opposite of
what is true anymore.
For compatibility, the constants are boolean values such that any
subclass defining reallyDoQuery()/buildQueryInfo() can use that
argument the same way as before.
Change-Id: I912d3678c755c25463a2fadbec6888f3a87d4215
Translation updater bot [Wed, 6 Mar 2019 22:26:10 +0000 (23:26 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I337a2609e45ccd9b3bb71c7d60e3847e320b5db6
Derick Alangi [Wed, 6 Mar 2019 22:20:56 +0000 (23:20 +0100)]
Use the .= operator to concatenate a var with another
Rather than using $var = $var . $foo, to avoid the redundancy, use
$var .= $foo which is a valid PHP syntax and popularly used.
Change-Id: Idbbdb31a7b5561ed97f9ba0f05f6ac78c9419f82
jenkins-bot [Wed, 6 Mar 2019 22:11:00 +0000 (22:11 +0000)]
Merge "ActiveUsersPager: Fix ordering and return 0-action users"
Aaron Schulz [Wed, 6 Mar 2019 22:01:20 +0000 (14:01 -0800)]
Normalize "LEFT OUTER JOIN" to "LEFT JOIN" in SQL queries
Change-Id: I4de7f0527d9e16f9128ef3b24567511d4c74245d
jenkins-bot [Wed, 6 Mar 2019 21:18:00 +0000 (21:18 +0000)]
Merge "Stash WatchedItem changes so that the jobs run from the queue"
jenkins-bot [Wed, 6 Mar 2019 20:51:50 +0000 (20:51 +0000)]
Merge "resourceloader: Remove wgAvailableSkins from mw.config"
jenkins-bot [Wed, 6 Mar 2019 20:20:22 +0000 (20:20 +0000)]
Merge "Normalize use of "INNER JOIN" to "JOIN" in database queries"
Timo Tijhof [Wed, 6 Mar 2019 15:00:47 +0000 (15:00 +0000)]
resourceloader: Remove wgAvailableSkins from mw.config
Added in 2011 for use in QUnit tests (r80790, r80792).
That was a terrible idea in hindsight, which I removed again in
2015 with
6b758fc982972e, and
0f9e4ca0fb7c.
If a need for it were to arise in the future, we'd export it
within the file module that needs it, or via addJsConfigVars()
on only the pages that need it – not globally.
Bug: T217772
Change-Id: I3885cacaa9b33e6947dbaf26f9b6839e19588603
Brad Jorsch [Mon, 4 Mar 2019 04:01:29 +0000 (23:01 -0500)]
ActiveUsersPager: Fix ordering and return 0-action users
Ia9d2ff00 introduced two incompatibilities with what the base classes
were trying to do:
* The $descending flag passed to buildQueryInfo() does not actually mean
DESC if $this->mIsBackwards is set. The old code just blindly assumed
that was the case.
* For paging to work right, we must return all $limit rows, we can't
filter out users with 0 actions. Thus we need to LEFT JOIN
recentchanges (and move some conditions around to cope)..
Bug: T217525
Change-Id: Iba105a31ff61fbb14931bf8903538bfe7b0ba48b
jenkins-bot [Wed, 6 Mar 2019 18:54:05 +0000 (18:54 +0000)]
Merge "resourceloader: Remove ResourceLoaderMaxQueryLength from mw.config"
jenkins-bot [Wed, 6 Mar 2019 18:13:59 +0000 (18:13 +0000)]
Merge "resourceloader: Use local var for getConfig() calls in StartUpModule"
jenkins-bot [Wed, 6 Mar 2019 17:45:51 +0000 (17:45 +0000)]
Merge "Fix HeaderCallback failing on headers without a colon"
jenkins-bot [Wed, 6 Mar 2019 17:26:26 +0000 (17:26 +0000)]
Merge "Add help text to "partial" and "sitewide" options on Special:Block"
Aaron Schulz [Wed, 6 Mar 2019 17:17:27 +0000 (09:17 -0800)]
Normalize use of "INNER JOIN" to "JOIN" in database queries
The ANSI SQL default join type is INNER and this might save
some line breaks here and there.
Change-Id: Ibd39976f46ca3f9b71190d3b60b76ca085787a00
Aaron Schulz [Sat, 2 Mar 2019 02:30:29 +0000 (18:30 -0800)]
Make ApiStashEdit use a separate key for the parser output due to size
Bug: T204742
Change-Id: Ibab189c8e0dee5e840770bdb0336516fdfc75e4b
Aaron Schulz [Tue, 5 Mar 2019 19:31:55 +0000 (11:31 -0800)]
objectcache: add metrics for WAN cache deletes and check key touches/resets
Change-Id: I3dc707af53e480b27b7349aca53292f3bb26c45a
jenkins-bot [Wed, 6 Mar 2019 16:38:02 +0000 (16:38 +0000)]
Merge "Make LinksUpdate::getPropertyDeletions private"
jenkins-bot [Wed, 6 Mar 2019 16:36:29 +0000 (16:36 +0000)]
Merge "Add more documentation to DeferredUpdates::doUpdates"
Thalia [Wed, 27 Feb 2019 22:11:40 +0000 (22:11 +0000)]
Add help text to "partial" and "sitewide" options on Special:Block
Describe the differences between sitewide and partial blocks under the
respective radio options.
Bug: T213101
Change-Id: Ibf098c6becaf4824f8da2cade22e23f4ce00283b
Timo Tijhof [Wed, 6 Mar 2019 15:46:44 +0000 (15:46 +0000)]
resourceloader: Remove ResourceLoaderMaxQueryLength from mw.config
This is only used internally. It doesn't need to be exported
as part of mw.config.
Change-Id: If4206d797b5d426eb999c34ad5dde3ba141c6f05
Timo Tijhof [Wed, 6 Mar 2019 15:45:55 +0000 (15:45 +0000)]
resourceloader: Use local var for getConfig() calls in StartUpModule
Change-Id: I53af241454872fd228869b45dc74175c56026d6e
jenkins-bot [Wed, 6 Mar 2019 15:11:07 +0000 (15:11 +0000)]
Merge "Hard deprecate MWNamespace::canTalk()"
Derick Alangi [Sat, 2 Mar 2019 15:47:40 +0000 (16:47 +0100)]
Title: Minor clean up for stricter checks, casting style, and doc types
These improvements touch areas around cleaning up deprecated functions
such as intval(), strval() into casting with (int), (string), etc.
If such improvements is welcomed into the Title class, I can make more
of such but for now, I've just made a few, like 1/20 of these kind of
changes in the file so that, if it's merged and encouraged to continue,
I'll cleanup the file. Or as proposed on this patch, phpcs rules can be
used to handle such cases.
Change-Id: Ib90e880cb124e765379ddad531d4c89289d364de
jenkins-bot [Wed, 6 Mar 2019 09:58:52 +0000 (09:58 +0000)]
Merge "user_group, the nonexistent table that keeps on giving"
Aaron Schulz [Wed, 6 Mar 2019 09:23:22 +0000 (01:23 -0800)]
Make LinksUpdate::getPropertyDeletions private
Change-Id: Iec1ae929566e25a278ef918f9f6b22343dce6cec
Jack Phoenix [Wed, 6 Mar 2019 09:07:26 +0000 (11:07 +0200)]
user_group, the nonexistent table that keeps on giving
Follow-up to
27c61fb1e94da9114314468fd00bcf129ec064b6.
Bug: T199474
Change-Id: Ie8e054f5898209c51538669149e966bee7754f1e
Antoine Musso [Wed, 6 Mar 2019 08:52:34 +0000 (08:52 +0000)]
Revert "Convert MultiHttpClient to use Guzzle"
That breaks on Wikimedia beta cluster (T217733):
Warning: Invalid argument: option: 6 in
vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php on line 56
Warning: Invalid argument: option: 6 in
vendor/guzzlehttp/guzzle/src/Handler/CurlFactory.php on line 56
Warning: Invalid argument: function: not string, closure, or array in
vendor/guzzlehttp/guzzle/src/Handler/CurlMultiHandler.php on line 108
Fatal error: Uncaught exception 'ConfigException'
Failed to load configuration from etcd: cURL error 23: Failed writing
header
This reverts commit
1e048a08b565ae909e85465f8b09a27ed8480ce2.
Bug: T202352
Bug: T217733
Change-Id: I2384355043896128d3f191941e8da00fdc62361e
Aaron Schulz [Wed, 6 Mar 2019 08:04:12 +0000 (00:04 -0800)]
Add more documentation to DeferredUpdates::doUpdates
Change-Id: Id2f1fb624d03943e5eb4bed49d3435cf9c99fc25
jenkins-bot [Wed, 6 Mar 2019 04:25:11 +0000 (04:25 +0000)]
Merge "resourceloader: Minor clean up in saveFileDependencies()"
Timo Tijhof [Wed, 6 Mar 2019 01:35:05 +0000 (01:35 +0000)]
resourceloader: Minor clean up in saveFileDependencies()
* Use early return instead of all-encapsulating conditional.
* Document why the try/catch is so big.
Change-Id: Ie19e18556e7ac0a12ad6b979367f8c6b786bbe31
Timo Tijhof [Tue, 5 Mar 2019 23:55:03 +0000 (23:55 +0000)]
Remove various references to cURL in code comments
Given we now use Guzzle as well, and don't require cURL for any
features at a basic level, our code should not be as assumptious
about the backend being curl. Such assumptions may be wrong
and lead to confusion and/or bugs.
Bug: T137926
Change-Id: I6ad7f76768348e1eb8c1fb46c8125cce9285dc22
jenkins-bot [Tue, 5 Mar 2019 23:38:56 +0000 (23:38 +0000)]
Merge "Fix a rather fatal typo in rebuildrecentchanges.php"