From: Rob Church <robchurch@users.mediawiki.org>
Date: Wed, 31 May 2006 01:08:41 +0000 (+0000)
Subject: (bug 4940) $action uninitialised
X-Git-Tag: 1.31.0-rc.0~56958
X-Git-Url: http://git.cyclocoop.org/%22%2C%20generer_url_ecrire%28?a=commitdiff_plain;h=f7cdcc7bca768170213818be7545f53661c656b6;p=lhc%2Fweb%2Fwiklou.git

(bug 4940) $action uninitialised
---

diff --git a/includes/Skin.php b/includes/Skin.php
index 5246e2a812..5bf36abec4 100644
--- a/includes/Skin.php
+++ b/includes/Skin.php
@@ -330,7 +330,6 @@ class Skin extends Linker {
 
 	/**
 	 * Some styles that are set by user through the user settings interface.
-	 * @todo undefined variables (bug #4940)
 	 */
 	function doGetUserStyles() {
 		global $wgUser, $wgUser, $wgRequest, $wgTitle, $wgAllowUserCss;
@@ -338,8 +337,7 @@ class Skin extends Linker {
 		$s = '';
 
 		if( $wgAllowUserCss && $wgUser->isLoggedIn() ) { # logged in
-			# FIXME: $action undefined, bug #4940
-			if($wgTitle->isCssSubpage() && $this->userCanPreview( $action ) ) {
+			if($wgTitle->isCssSubpage() && $this->userCanPreview( $wgRequest->getText( 'action' ) ) ) {
 				$s .= $wgRequest->getText('wpTextbox1');
 			} else {
 				$userpage = $wgUser->getUserPage();