From: Niklas Laxström <nikerabbit@users.mediawiki.org>
Date: Sat, 7 Aug 2010 23:43:28 +0000 (+0000)
Subject: Use for loops for iterating query results
X-Git-Tag: 1.31.0-rc.0~35631
X-Git-Url: http://git.cyclocoop.org/%22%2C%20generer_url_ecrire%28?a=commitdiff_plain;h=9de31b0ad070bf24071ce06c8430d5b94d64cf83;p=lhc%2Fweb%2Fwiklou.git

Use for loops for iterating query results
---

diff --git a/includes/MessageCache.php b/includes/MessageCache.php
index 0524ccd62e..1e77504801 100644
--- a/includes/MessageCache.php
+++ b/includes/MessageCache.php
@@ -343,10 +343,9 @@ class MessageCache {
 
 		# Load titles for all oversized pages in the MediaWiki namespace
 		$res = $dbr->select( 'page', 'page_title', $bigConds, __METHOD__ . "($code)-big" );
-		while ( $row = $dbr->fetchObject( $res ) ) {
+		foreach ( $res as $row ) {
 			$cache[$row->page_title] = '!TOO BIG';
 		}
-		$dbr->freeResult( $res );
 
 		# Conditions to load the remaining pages with their contents
 		$smallConds = $conds;
@@ -358,10 +357,9 @@ class MessageCache {
 			array( 'page_title', 'old_text', 'old_flags' ),
 			$smallConds, __METHOD__ . "($code)-small" );
 
-		for ( $row = $dbr->fetchObject( $res ); $row; $row = $dbr->fetchObject( $res ) ) {
+		foreach ( $res as $row ) {
 			$cache[$row->page_title] = ' ' . Revision::getRevisionText( $row );
 		}
-		$dbr->freeResult( $res );
 
 		$cache['VERSION'] = MSG_CACHE_VERSION;
 		wfProfileOut( __METHOD__ );