From: Kunal Mehta <legoktm@member.fsf.org>
Date: Wed, 12 Jul 2017 01:30:33 +0000 (-0700)
Subject: Advise extensions not to modify $wgWhitelistRead
X-Git-Tag: 1.31.0-rc.0~2728^2
X-Git-Url: http://git.cyclocoop.org/%22%2C%20generer_url_ecrire%28?a=commitdiff_plain;h=867c79be202de0656efc5b42dd46be1916b82a39;p=lhc%2Fweb%2Fwiklou.git

Advise extensions not to modify $wgWhitelistRead

Instead they should use the TitleReadWhitelist hook. I've seen this
pattern in multiple extensions now, each causing different problems, so
it should be explicitly documented.

Change-Id: I670b0acde660bdc27a6c7e91c4b1b3baeea8b2e5
---

diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 11f08b2bb5..6ce9a66974 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -5027,6 +5027,9 @@ $wgBlockDisablesLogin = false;
  * @note Also that this will only protect _pages in the wiki_. Uploaded files
  * will remain readable. You can use img_auth.php to protect uploaded files,
  * see https://www.mediawiki.org/wiki/Manual:Image_Authorization
+ *
+ * @note Extensions should not modify this, but use the TitleReadWhitelist
+ * hook instead.
  */
 $wgWhitelistRead = false;